From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-178.mta0.migadu.com (out-178.mta0.migadu.com [91.218.175.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8DFB7080C for ; Wed, 13 Nov 2024 02:12:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731463928; cv=none; b=TFXfd2TY7G/rV0rq8lS+ieKH2YX27dljggkukOuVvTSzjiBt90D4XLfG8oc3dXrcX5RWMePBkdjEfKc2AV3A1fur1l1j9RW5RletgQA7/xbdo3xG109+OpuFvb83nOcpVsxdmug3ISPNI/8vGT/axCLe85FI1H/CcqyHfVamy3k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731463928; c=relaxed/simple; bh=LPAFNR/5ZvSKqaLMt8rTiosnu4xB/7YjXsTMr1zPqOs=; h=MIME-Version:Date:Content-Type:From:Message-ID:Subject:To:Cc: In-Reply-To:References; b=jgbpjU+f0lxL246NEez2JereybvQlIE/O3u81/Wj+A9E9B0uPIFWWLx8RTo5gv8FMFe6fQXhgU85SVWOUXjSyhFjFIyUTRTQiDntil6NWnxYUxpqCBlCtXLNbWQCeB3Lbio2W96wenBvSxbUyPs9Cy4rXyQPl1rQfOSlDqNZxd0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vahedi.org; spf=pass smtp.mailfrom=vahedi.org; dkim=pass (2048-bit key) header.d=vahedi.org header.i=@vahedi.org header.b=H2f2josU; arc=none smtp.client-ip=91.218.175.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vahedi.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vahedi.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vahedi.org header.i=@vahedi.org header.b="H2f2josU" Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vahedi.org; s=key1; t=1731463920; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LPAFNR/5ZvSKqaLMt8rTiosnu4xB/7YjXsTMr1zPqOs=; b=H2f2josUl02/QYj8HZeK0rhfBW6wwfVszOKFy00+KMFCobNMnOgLX3ceyVgX5NmtlRw6zd 8G8Xv2G+3sz83sam2oY8/QuiGn7+pZwBn1Chh8Vazt6mWq3fk9uAVEraWPhm7F2B47Q3Q8 9lyp+fMnJIj8pgcBbJU7hUNVPHsjr2aDml1RU+nDl66E5eqVotaz/qY6ri6AOjjhuEg9km BUpn19H7FWrEPcslYwLfLL27hkE23aQK4D6pA+PF4WA0rNGates1me/kgFJUTdKDLF2b+j tQlbG7VpURI233Ox21yfSYt7Hk6TtsaFOglq+5akdVm7R9HghmdvpVs+xoJxVQ== Date: Wed, 13 Nov 2024 02:11:54 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Shahab Vahedi" Message-ID: <6454497ff35d2a534cd34b7635fb044e4033fe6b@vahedi.org> TLS-Required: No Subject: Re: [PATCH] ARC: bpf_jit_arcv2: Remove redundant condition check To: "Vadim Fedorenko" , "Hardevsinh Palaniya" , ast@kernel.org, andrii@kernel.org Cc: "Daniel Borkmann" , "Martin KaFai Lau" , "Eduard Zingerman" , "Song Liu" , "Yonghong Song" , "John Fastabend" , "KP Singh" , "Stanislav Fomichev" , "Hao Luo" , "Jiri Olsa" , "Vineet Gupta" , bpf@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org In-Reply-To: References: <20241111142028.67708-1-hardevsinh.palaniya@siliconsignals.io> X-Migadu-Flow: FLOW_OUT Vadim Fedorenko wrote: =20 >=20The original code is obviously optimized out, but the intention, I > believe, was to check if the jump is conditional or not. > So the proper fix should change the code to check cond: >=20 >=20- if (ARC_CC_AL) > + if (cond =3D=3D ARC_CC_AL) That is absolutely correct. If a new patch is not submitted soon I'll try to fix it myself. Cheers, Shahab