From: Alexei Starovoitov <ast@fb.com>
To: Martin Lau <kafai@fb.com>
Cc: Stanislav Fomichev <sdf@fomichev.me>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
David Miller <davem@davemloft.net>,
Kernel Team <Kernel-team@fb.com>
Subject: Re: [PATCH bpf-next 2/2] bpf: Add test for SO_REUSEPORT_DETACH_BPF
Date: Wed, 12 Jun 2019 22:25:47 +0000 [thread overview]
Message-ID: <64cf5b03-bb3e-ee4d-932e-46433bd0ecdb@fb.com> (raw)
In-Reply-To: <20190612221549.7rmv56yjg7a64zad@kafai-mbp.dhcp.thefacebook.com>
On 6/12/19 3:15 PM, Martin Lau wrote:
> On Wed, Jun 12, 2019 at 02:53:35PM -0700, Alexei Starovoitov wrote:
>> On 6/12/19 2:47 PM, Stanislav Fomichev wrote:
>>>>>> CFLAGS += -Wall -O2 -I$(APIDIR) -I$(LIBDIR) -I$(BPFDIR) -I$(GENDIR) $(GENFLAGS) -I../../../include \
>>>>>> + -I../../../../usr/include/ \
>>>>> Why not copy inlude/uapi/asm-generic/socket.h into tools/include
>>>>> instead? Will that work?
>>>> Sure. I am ok with copy. I don't think we need to sync very often.
>>>> Do you know how to do that considering multiple arch's socket.h
>>>> have been changed in Patch 1?
>>> No, I don't know how to handle arch specific stuff. I suggest to copy
>>> asm-generic and have ifdefs in the tests if someone complains:-)
> It is not very nice but I am ok with that also. It is the only
> arch I can test ;)
>
>>>
>>>> Is copy better?
>>> Doesn't ../../../../usr/include provide the same headers we have in
>>> tools/include/uapi? If you add -I../../../../usr/include, then is there
>>> a point of having copies under tools/include/uapi? I don't really
>>> know why we keep the copies under tools/include/uapi rather than including
>>> ../../../usr/include directly.
>>
>> for out-of-src builds ../../../../usr/include/ directory doesn't exist.
> Is out-of-src build mostly for libbpf?
> or selftests/bpf also requires out-of-src build?
out-of-src for kernel.
In my setup:
$ pwd -P
..../bpf-next/tools/testing/selftests/bpf
$ ls ../../../../usr/include/
ls: cannot access ../../../../usr/include/: No such file or directory
$ ls ../../../../bld_x64/usr/include/
asm asm-generic drm linux misc mtd rdma scsi sound video xen
next prev parent reply other threads:[~2019-06-13 17:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 19:05 [PATCH bpf-next 0/2] bpf: net: Detach BPF prog from reuseport sk Martin KaFai Lau
2019-06-12 19:05 ` [PATCH bpf-next 1/2] bpf: net: Add SO_DETACH_REUSEPORT_BPF Martin KaFai Lau
2019-06-13 4:39 ` Andrii Nakryiko
2019-06-13 19:18 ` kbuild test robot
2019-06-13 20:14 ` Andrii Nakryiko
2019-06-13 21:18 ` Martin Lau
2019-06-12 19:05 ` [PATCH bpf-next 2/2] bpf: Add test for SO_REUSEPORT_DETACH_BPF Martin KaFai Lau
2019-06-12 19:59 ` Stanislav Fomichev
2019-06-12 21:30 ` Martin Lau
2019-06-12 21:47 ` Stanislav Fomichev
2019-06-12 21:53 ` Alexei Starovoitov
2019-06-12 22:15 ` Martin Lau
2019-06-12 22:25 ` Alexei Starovoitov [this message]
2019-06-12 22:39 ` Martin Lau
2019-06-12 21:47 ` Martin Lau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64cf5b03-bb3e-ee4d-932e-46433bd0ecdb@fb.com \
--to=ast@fb.com \
--cc=Kernel-team@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=kafai@fb.com \
--cc=netdev@vger.kernel.org \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox