From: shaozhengchao <shaozhengchao@huawei.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: <netdev@vger.kernel.org>, <bpf@vger.kernel.org>,
<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <jhs@mojatatu.com>, <jiri@resnulli.us>,
<ast@kernel.org>, <daniel@iogearbox.net>, <andrii@kernel.org>,
<martin.lau@linux.dev>, <song@kernel.org>, <yhs@fb.com>,
<john.fastabend@gmail.com>, <kpsingh@kernel.org>,
<sdf@google.com>, <haoluo@google.com>, <jolsa@kernel.org>,
<weiyongjun1@huawei.com>, <yuehaibing@huawei.com>
Subject: Re: [RFC PATCH net-next 1/2] net: sched: act_api: add helper macro for tcf_action in module and net init/exit
Date: Mon, 19 Sep 2022 19:07:22 +0800 [thread overview]
Message-ID: <6524401a-4e1f-61bf-5b8d-e56b4fcdc67d@huawei.com> (raw)
In-Reply-To: <YyYZ5cKm5TiuKBgv@pop-os.localdomain>
On 2022/9/18 3:03, Cong Wang wrote:
> On Fri, Sep 16, 2022 at 04:51:54PM +0800, Zhengchao Shao wrote:
>> Helper macro for tcf_action that don't do anything special in module
>> and net init/exit. This eliminates a lot of boilerplate. Each module
>> may only use this macro once, and calling it replaces module/net_init()
>> and module/net_exit().
>>
>
> This looks over engineering to me. I don't think this reduces any code
> size or help any readability.
>
> Thanks.
Hi Wang:
Thank you for your review. I think this macro can simplify
repeated code when adding action modules later.
Zhengchao Shao
next prev parent reply other threads:[~2022-09-19 11:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 8:51 [RFC PATCH net-next 0/2] refactor the module and net init/exit functions in tc_action Zhengchao Shao
2022-09-16 8:51 ` [RFC PATCH net-next 1/2] net: sched: act_api: add helper macro for tcf_action in module and net init/exit Zhengchao Shao
2022-09-17 19:03 ` Cong Wang
2022-09-19 11:07 ` shaozhengchao [this message]
2022-09-19 16:50 ` Cong Wang
2022-09-16 8:51 ` [RFC PATCH net-next 2/2] net: sched: use module_net_tcf_action macro when module and net init/exit in action Zhengchao Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6524401a-4e1f-61bf-5b8d-e56b4fcdc67d@huawei.com \
--to=shaozhengchao@huawei.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=haoluo@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=weiyongjun1@huawei.com \
--cc=xiyou.wangcong@gmail.com \
--cc=yhs@fb.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox