From: John Fastabend <john.fastabend@gmail.com>
To: Manu Bretelle <chantr4@gmail.com>,
bpf@vger.kernel.org, andrii@kernel.org, daniel@iogearbox.net,
ast@kernel.org, martin.lau@linux.dev, song@kernel.org,
john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com,
haoluo@google.com, jolsa@kernel.org
Subject: RE: [PATCH bpf-next ] selftests/bpf: Fixes tests for filesystem kfuncs
Date: Mon, 11 Dec 2023 13:01:58 -0800 [thread overview]
Message-ID: <657778c650992_edaa20895@john.notmuch> (raw)
In-Reply-To: <20231211180733.763025-1-chantr4@gmail.com>
Manu Bretelle wrote:
> `fs_kfuncs.c`'s `test_xattr` would fail the test even when the
> filesystem did not support xattr, for instance when /tmp is mounted as
> tmpfs.
>
> This change checks errno when setxattr fail. If the failure is due to
> the operation being unsupported, we will skip the test (just like we
> would if verity was not enabled on the FS.
>
> Before the change, fs_kfuncs test would fail in test_axattr:
>
...
> Fixes: 341f06fdddf7 ("selftests/bpf: Add tests for filesystem kfuncs")
> Signed-off-by: Manu Bretelle <chantr4@gmail.com>
> ---
Acked-by: John Fastabend <john.fastabend@gmail.com>
next prev parent reply other threads:[~2023-12-11 21:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-11 18:07 [PATCH bpf-next ] selftests/bpf: Fixes tests for filesystem kfuncs Manu Bretelle
2023-12-11 21:01 ` John Fastabend [this message]
2023-12-12 18:00 ` patchwork-bot+netdevbpf
2023-12-12 18:12 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=657778c650992_edaa20895@john.notmuch \
--to=john.fastabend@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=chantr4@gmail.com \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=martin.lau@linux.dev \
--cc=sdf@google.com \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox