BPF List
 help / color / mirror / Atom feed
From: John Fastabend <john.fastabend@gmail.com>
To: Andrii Nakryiko <andrii@kernel.org>,
	 bpf@vger.kernel.org,  ast@kernel.org,  daniel@iogearbox.net,
	 martin.lau@kernel.org
Cc: andrii@kernel.org,  kernel-team@meta.com
Subject: RE: [PATCH bpf-next 0/2] BPF FS mount options parsing follow ups
Date: Wed, 13 Dec 2023 22:56:24 -0800	[thread overview]
Message-ID: <657aa718c8f1c_4a65f208f1@john.notmuch> (raw)
In-Reply-To: <20231213222327.934981-1-andrii@kernel.org>

Andrii Nakryiko wrote:
> Original BPF token patch set ([0]) added delegate_xxx mount options which
> supported only special "any" value and hexadecimal bitmask. This patch set
> attempts to make specifying and inspecting these mount options more
> human-friendly by supporting string constants matching corresponding bpf_cmd,
> bpf_map_type, bpf_prog_type, and bpf_attach_type enumerators.
> 
> This implementation relies on BTF information to find all supported symbolic
> names. If kernel wasn't built with BTF, BPF FS will still support "any" and
> hex-based mask.
> 
>   [0] https://patchwork.kernel.org/project/netdevbpf/list/?series=805707&state=*
> 
> Andrii Nakryiko (2):
>   bpf: support symbolic BPF FS delegation mount options
>   selftests/bpf: utilize string values for delegate_xxx mount options
> 
>  kernel/bpf/inode.c                            | 231 +++++++++++++++---
>  .../testing/selftests/bpf/prog_tests/token.c  |  52 ++--
>  2 files changed, 225 insertions(+), 58 deletions(-)
> 
> -- 
> 2.34.1
> 
> 

Acked-by: John Fastabend <john.fastabend@gmail.com>

      parent reply	other threads:[~2023-12-14  6:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-13 22:23 [PATCH bpf-next 0/2] BPF FS mount options parsing follow ups Andrii Nakryiko
2023-12-13 22:23 ` [PATCH bpf-next 1/2] bpf: support symbolic BPF FS delegation mount options Andrii Nakryiko
2023-12-14  1:05   ` John Fastabend
2023-12-14 15:49   ` Daniel Borkmann
2023-12-14 15:58   ` Alexei Starovoitov
2023-12-14 19:38     ` Andrii Nakryiko
2023-12-13 22:23 ` [PATCH bpf-next 2/2] selftests/bpf: utilize string values for delegate_xxx " Andrii Nakryiko
2023-12-14  1:06   ` John Fastabend
2023-12-14  6:56 ` John Fastabend [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=657aa718c8f1c_4a65f208f1@john.notmuch \
    --to=john.fastabend@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=kernel-team@meta.com \
    --cc=martin.lau@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox