From: Alan Maguire <alan.maguire@oracle.com>
To: Jeongjun Park <aha310510@gmail.com>, martin.lau@linux.dev
Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
eddyz87@gmail.com, song@kernel.org, yonghong.song@linux.dev,
john.fastabend@gmail.com, kpsingh@kernel.org, sdf@fomichev.me,
haoluo@google.com, jolsa@kernel.org, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH bpf-next] bpf: remove __btf_name_valid() and change to btf_name_valid_identifier()
Date: Wed, 7 Aug 2024 17:53:14 +0100 [thread overview]
Message-ID: <659e71b8-e714-4141-901f-3b494a49a9e9@oracle.com> (raw)
In-Reply-To: <20240807143110.181497-1-aha310510@gmail.com>
On 07/08/2024 15:31, Jeongjun Park wrote:
> __btf_name_valid() can be completely replaced with
> btf_name_valid_identifier, and since most of the time you already call
> btf_name_valid_identifier instead of __btf_name_valid , it would be
> appropriate to rename the __btf_name_valid function to
> btf_name_valid_identifier and remove __btf_name_valid.
>
> Signed-off-by: Jeongjun Park <aha310510@gmail.com>
Looks good to me
Reviewed-by: Alan Maguire <alan.maguire@oracle.com>
> ---
> kernel/bpf/btf.c | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
>
next prev parent reply other threads:[~2024-08-07 16:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-07 14:31 [PATCH bpf-next] bpf: remove __btf_name_valid() and change to btf_name_valid_identifier() Jeongjun Park
2024-08-07 16:53 ` Alan Maguire [this message]
2024-08-15 23:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=659e71b8-e714-4141-901f-3b494a49a9e9@oracle.com \
--to=alan.maguire@oracle.com \
--cc=aha310510@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=sdf@fomichev.me \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox