From: John Fastabend <john.fastabend@gmail.com>
To: Andrii Nakryiko <andrii@kernel.org>,
bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net,
martin.lau@kernel.org
Cc: andrii@kernel.org, kernel-team@meta.com
Subject: RE: [PATCH bpf-next] bpftool: use __typeof__() instead of typeof() in BPF skeleton
Date: Mon, 01 Apr 2024 18:44:13 -0700 [thread overview]
Message-ID: <660b62ed3561d_8015208e4@john.notmuch> (raw)
In-Reply-To: <20240401170713.2081368-1-andrii@kernel.org>
Andrii Nakryiko wrote:
> When generated BPF skeleton header is included in C++ code base, some
> compiler setups will emit warning about using language extensions due to
> typeof() usage, resulting in something like:
>
> error: extension used [-Werror,-Wlanguage-extension-token]
> obj->struct_ops.empty_tcp_ca = (typeof(obj->struct_ops.empty_tcp_ca))
> ^
>
> It looks like __typeof__() is a preferred way to do typeof() with better
> C++ compatibility behavior, so switch to that. With __typeof__() we get
> no such warning.
>
> Fixes: c2a0257c1edf ("bpftool: Cast pointers for shadow types explicitly.")
> Fixes: 00389c58ffe9 ("bpftool: Add support for subskeletons")
> Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
> ---
> tools/bpf/bpftool/gen.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/bpf/bpftool/gen.c b/tools/bpf/bpftool/gen.c
> index 786268f1a483..b3979ddc0189 100644
> --- a/tools/bpf/bpftool/gen.c
> +++ b/tools/bpf/bpftool/gen.c
> @@ -386,7 +386,7 @@ static int codegen_subskel_datasecs(struct bpf_object *obj, const char *obj_name
> */
> needs_typeof = btf_is_array(var) || btf_is_ptr_to_func_proto(btf, var);
> if (needs_typeof)
> - printf("typeof(");
> + printf("__typeof__(");
>
> err = btf_dump__emit_type_decl(d, var_type_id, &opts);
> if (err)
> @@ -1131,7 +1131,7 @@ static void gen_st_ops_shadow_init(struct btf *btf, struct bpf_object *obj)
> continue;
> codegen("\
> \n\
> - obj->struct_ops.%1$s = (typeof(obj->struct_ops.%1$s))\n\
> + obj->struct_ops.%1$s = (__typeof__(obj->struct_ops.%1$s))\n\
> bpf_map__initial_value(obj->maps.%1$s, NULL);\n\
> \n\
> ", ident);
> --
> 2.43.0
>
>
sure.
Acked-by: John Fastabend <john.fastabend@gmail.com>
next prev parent reply other threads:[~2024-04-02 1:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-01 17:07 [PATCH bpf-next] bpftool: use __typeof__() instead of typeof() in BPF skeleton Andrii Nakryiko
2024-04-01 17:59 ` Kui-Feng Lee
2024-04-01 19:50 ` Quentin Monnet
2024-04-02 1:44 ` John Fastabend [this message]
2024-04-02 14:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=660b62ed3561d_8015208e4@john.notmuch \
--to=john.fastabend@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@meta.com \
--cc=martin.lau@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox