From: John Fastabend <john.fastabend@gmail.com>
To: Daniel Borkmann <daniel@iogearbox.net>, bpf@vger.kernel.org
Cc: jjlopezjaimez@google.com, Daniel Borkmann <daniel@iogearbox.net>
Subject: RE: [PATCH bpf 2/2] selftests/bpf: Add test coverage for reg_set_min_max handling
Date: Wed, 12 Jun 2024 16:12:52 -0700 [thread overview]
Message-ID: <666a2b749d47d_12372081d@john.notmuch> (raw)
In-Reply-To: <20240612221405.3378-2-daniel@iogearbox.net>
Daniel Borkmann wrote:
> Add a test case for the jmp32/k fix to ensure selftests have coverage.
>
> Before fix:
>
> # ./vmtest.sh -- ./test_progs -t verifier_or_jmp32_k
> [...]
> ./test_progs -t verifier_or_jmp32_k
> tester_init:PASS:tester_log_buf 0 nsec
> process_subtest:PASS:obj_open_mem 0 nsec
> process_subtest:PASS:specs_alloc 0 nsec
> run_subtest:PASS:obj_open_mem 0 nsec
> run_subtest:FAIL:unexpected_load_success unexpected success: 0
> #492/1 verifier_or_jmp32_k/or_jmp32_k: bit ops + branch on unknown value:FAIL
> #492 verifier_or_jmp32_k:FAIL
> Summary: 0/0 PASSED, 0 SKIPPED, 1 FAILED
>
> After fix:
>
> # ./vmtest.sh -- ./test_progs -t verifier_or_jmp32_k
> [...]
> ./test_progs -t verifier_or_jmp32_k
> #492/1 verifier_or_jmp32_k/or_jmp32_k: bit ops + branch on unknown value:OK
> #492 verifier_or_jmp32_k:OK
> Summary: 1/1 PASSED, 0 SKIPPED, 0 FAILED
>
> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
> ---
Acked-by: John Fastabend <john.fastabend@gmail.com>
next prev parent reply other threads:[~2024-06-12 23:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-12 22:14 [PATCH bpf 1/2] bpf: Fix reg_set_min_max corruption of fake_reg Daniel Borkmann
2024-06-12 22:14 ` [PATCH bpf 2/2] selftests/bpf: Add test coverage for reg_set_min_max handling Daniel Borkmann
2024-06-12 23:12 ` John Fastabend [this message]
2024-06-12 23:10 ` [PATCH bpf 1/2] bpf: Fix reg_set_min_max corruption of fake_reg John Fastabend
2024-06-12 23:13 ` Alexei Starovoitov
2024-06-13 12:00 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=666a2b749d47d_12372081d@john.notmuch \
--to=john.fastabend@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jjlopezjaimez@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox