From: Hengqi Chen <hengqi.chen@gmail.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: bpf <bpf@vger.kernel.org>, Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>, Yonghong Song <yhs@fb.com>,
john fastabend <john.fastabend@gmail.com>,
Martin Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>
Subject: Re: [PATCH bpf-next 2/2] tools: Switch to new btf__type_cnt/btf__raw_data APIs
Date: Wed, 20 Oct 2021 21:54:32 +0800 [thread overview]
Message-ID: <66bfc72b-0cac-3c16-7224-49884e83b8be@gmail.com> (raw)
In-Reply-To: <CAEf4Bza6iFBn6FJ4ps+ONwDQ-Otqt=QtBm7Tw00qg+zVYM0wdQ@mail.gmail.com>
On 2021/10/20 1:50 AM, Andrii Nakryiko wrote:
> On Sat, Oct 9, 2021 at 8:01 AM Hengqi Chen <hengqi.chen@gmail.com> wrote:
>>
>> Replace the calls to btf__get_nr_types/btf__get_raw_data in tools
>> with new APIs btf__type_cnt/btf__raw_data. The old APIs will be
>> deprecated in recent release of libbpf.
>
> "in libbpf v0.7+"
>
>>
>> Signed-off-by: Hengqi Chen <hengqi.chen@gmail.com>
>> ---
>> tools/bpf/bpftool/btf.c | 12 ++++++------
>> tools/bpf/bpftool/gen.c | 4 ++--
>> tools/bpf/resolve_btfids/main.c | 4 ++--
>> tools/perf/util/bpf-event.c | 2 +-
>> tools/testing/selftests/bpf/btf_helpers.c | 4 ++--
>> tools/testing/selftests/bpf/prog_tests/btf.c | 10 +++++-----
>> tools/testing/selftests/bpf/prog_tests/btf_dump.c | 8 ++++----
>> tools/testing/selftests/bpf/prog_tests/btf_endian.c | 12 ++++++------
>> tools/testing/selftests/bpf/prog_tests/btf_split.c | 2 +-
>> .../testing/selftests/bpf/prog_tests/core_autosize.c | 2 +-
>> tools/testing/selftests/bpf/prog_tests/core_reloc.c | 2 +-
>> .../selftests/bpf/prog_tests/resolve_btfids.c | 4 ++--
>> 12 files changed, 33 insertions(+), 33 deletions(-)
>>
>
> Please split each tool into a separate patch, and selftests separate
> from tools as well. Otherwise, great job, thanks!
>
I was hesitant to separate these changes to individual patches.
Will do since you ask for it. Thanks.
> [...]
>
prev parent reply other threads:[~2021-10-20 13:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-09 15:00 [PATCH bpf-next 0/2] libbpf: Add btf__type_cnt() and btf__raw_data() APIs Hengqi Chen
2021-10-09 15:00 ` [PATCH bpf-next 1/2] " Hengqi Chen
2021-10-19 17:48 ` Andrii Nakryiko
2021-10-20 13:51 ` Hengqi Chen
2021-10-20 23:14 ` Andrii Nakryiko
2021-10-21 13:53 ` Hengqi Chen
2021-10-09 15:00 ` [PATCH bpf-next 2/2] tools: Switch to new btf__type_cnt/btf__raw_data APIs Hengqi Chen
2021-10-19 17:50 ` Andrii Nakryiko
2021-10-20 13:54 ` Hengqi Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66bfc72b-0cac-3c16-7224-49884e83b8be@gmail.com \
--to=hengqi.chen@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox