BPF List
 help / color / mirror / Atom feed
From: John Fastabend <john.fastabend@gmail.com>
To: zijianzhang@bytedance.com,  bpf@vger.kernel.org
Cc: john.fastabend@gmail.com,  jakub@cloudflare.com,
	 davem@davemloft.net,  edumazet@google.com,  kuba@kernel.org,
	 pabeni@redhat.com,  dsahern@kernel.org,  horms@kernel.org,
	 ast@kernel.org,  daniel@iogearbox.net,  netdev@vger.kernel.org,
	 Zijian Zhang <zijianzhang@bytedance.com>
Subject: RE: [PATCH v2 bpf 0/2] tcp_bpf: update the rmem scheduling for
Date: Fri, 20 Dec 2024 08:51:32 -0800	[thread overview]
Message-ID: <6765a094c9db5_21de2208d9@john.notmuch> (raw)
In-Reply-To: <20241210012039.1669389-1-zijianzhang@bytedance.com>

zijianzhang@ wrote:
> From: Zijian Zhang <zijianzhang@bytedance.com>
> 
> We should do sk_rmem_schedule instead of sk_wmem_schedule in function
> bpf_tcp_ingress. We also need to update sk_rmem_alloc in bpf_tcp_ingress
> accordingly to account for the rmem.
> 
> v2:
>   - Update the commit message to indicate the reason for msg->skb check
> 
> Cong Wang (1):
>   tcp_bpf: charge receive socket buffer in bpf_tcp_ingress()
> 
> Zijian Zhang (1):
>   tcp_bpf: add sk_rmem_alloc related logic for tcp_bpf ingress
>     redirection
> 
>  include/linux/skmsg.h | 11 ++++++++---
>  include/net/sock.h    | 10 ++++++++--
>  net/core/skmsg.c      |  6 +++++-
>  net/ipv4/tcp_bpf.c    |  6 ++++--
>  4 files changed, 25 insertions(+), 8 deletions(-)
> 
> -- 
> 2.20.1
> 

Thanks. Sorry fo rthe delay I thought this had an ACK already. My fault.

Reviewed-by: John Fastabend <john.fastabend@gmail.com>

  parent reply	other threads:[~2024-12-20 16:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-10  1:20 [PATCH v2 bpf 0/2] tcp_bpf: update the rmem scheduling for zijianzhang
2024-12-10  1:20 ` [PATCH v2 bpf 1/2] tcp_bpf: charge receive socket buffer in bpf_tcp_ingress() zijianzhang
2024-12-10  1:20 ` [PATCH v2 bpf 2/2] tcp_bpf: add sk_rmem_alloc related logic for tcp_bpf ingress redirection zijianzhang
2024-12-20 16:51 ` John Fastabend [this message]
2024-12-20 17:10 ` [PATCH v2 bpf 0/2] tcp_bpf: update the rmem scheduling for patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6765a094c9db5_21de2208d9@john.notmuch \
    --to=john.fastabend@gmail.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=jakub@cloudflare.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=zijianzhang@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox