From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-177.mta0.migadu.com (out-177.mta0.migadu.com [91.218.175.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7431D2F5A for ; Wed, 13 Nov 2024 00:59:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731459557; cv=none; b=sVT3EmvJh30CZQpcQrYmfSYxSsNYBU/jKZ0BJB/megboORXrMQq96LRmsWEVkWxoWqE2ceB1T933LWulrEi3MYVj2v6iFI5mTxH+7haAJw2VrJWPu4fh3ToolAOn9Soi9ZgIt4TFJjne3RxS7Csxkeq8t5wzC4oyvT26KGDvBeQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731459557; c=relaxed/simple; bh=9XX5N+TdO/BUetwj4AmO4rLoKNvezuERJXKfJcR1eLQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NKa3bZpAoZ15zwMFmL1GJ1dc5FNrf98LqZq1CaE8AzCEaoveZ1VNXssnpagV144w888+TDoC+JCI91luCGqj8a2QwZLxSr2Gh7o6DaO1xo7n9vXVWQ4jmhBPqMlQ51nWrUbDGHmahZG/lilGAP0TEiVdFEqxj7I2RsDebK7YAhg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=LsdLzszk; arc=none smtp.client-ip=91.218.175.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="LsdLzszk" Message-ID: <677fac6c-e66d-4fba-a89a-982888209523@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1731459551; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JvrHNLX9AABBSynCrSCTX1QYMPJbE/ts/ugS+jCT1/g=; b=LsdLzszkcmZH8TwpENa+L0H+MTI/6+NeWZ2++OvFO6YvWJL95XFTbPzVluJls1c9VKZnJz 0nm/LjGTem+lhQxR64mbrcEkyGOZcAdTTOMoZQHIPi0zv61sfDasQlQMj0tVOnC1fm4aQS vRezM0OeHdf2Dh2gPme0Hg+dq6AJv3o= Date: Tue, 12 Nov 2024 16:59:02 -0800 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH bpf-next v4 0/3] Add kernel symbol for struct_ops trampoline To: Xu Kuohai Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Yonghong Song , Kui-Feng Lee , bpf@vger.kernel.org, netdev@vger.kernel.org References: <20241112145849.3436772-1-xukuohai@huaweicloud.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Martin KaFai Lau In-Reply-To: <20241112145849.3436772-1-xukuohai@huaweicloud.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 11/12/24 6:58 AM, Xu Kuohai wrote: > Add kernel symbol for struct_ops trampoline. > > Without kernel symbol for struct_ops trampoline, the unwinder may > produce unexpected stacktraces. For example, the x86 ORC and FP > unwinder stops stacktrace on a struct_ops trampoline address since > there is no kernel symbol for the address. Reviewed-by: Martin KaFai Lau