From: Eduard Zingerman <eddyz87@gmail.com>
To: Cupertino Miranda <cupertino.miranda@oracle.com>, bpf@vger.kernel.org
Cc: jose.marchesi@oracle.com, david.faust@oracle.com,
Yonghong Song <yonghong.song@linux.dev>,
Andrii Nakryiko <andrii.nakryiko@gmail.com>
Subject: Re: [PATCH bpf-next v4 2/2] selftests/bpf: Match tests against regular expression
Date: Thu, 13 Jun 2024 13:09:58 -0700 [thread overview]
Message-ID: <6786876cd4b7eaf6c249bf5ed1e4ebf02f26aad7.camel@gmail.com> (raw)
In-Reply-To: <20240613152037.395298-3-cupertino.miranda@oracle.com>
On Thu, 2024-06-13 at 16:20 +0100, Cupertino Miranda wrote:
> This patch changes a few tests to make use of regular expressions.
> Fixed tests otherwise fail when compiled with GCC.
>
> Signed-off-by: Cupertino Miranda <cupertino.miranda@oracle.com>
> Cc: jose.marchesi@oracle.com
> Cc: david.faust@oracle.com
> Cc: Yonghong Song <yonghong.song@linux.dev>
> Cc: Eduard Zingerman <eddyz87@gmail.com>
> Cc: Andrii Nakryiko <andrii.nakryiko@gmail.com>
> ---
Acked-by: Eduard Zingerman <eddyz87@gmail.com>
[...]
The two tests below are __naked inline assembly,
so there is no need to change alloc_insn for them.
> SEC("sk_skb")
> __description("bpf_map_lookup_elem(sockmap, &key)")
> -__failure __msg("Unreleased reference id=2 alloc_insn=6")
> +__failure __regex("Unreleased reference id=2 alloc_insn=[0-9]+")
> __naked void map_lookup_elem_sockmap_key(void)
> {
> asm volatile (" \
> @@ -819,7 +819,7 @@ __naked void map_lookup_elem_sockmap_key(void)
>
> SEC("sk_skb")
> __description("bpf_map_lookup_elem(sockhash, &key)")
> -__failure __msg("Unreleased reference id=2 alloc_insn=6")
> +__failure __regex("Unreleased reference id=2 alloc_insn=[0-9]+")
> __naked void map_lookup_elem_sockhash_key(void)
> {
> asm volatile (" \
prev parent reply other threads:[~2024-06-13 20:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 15:20 [PATCH bpf-next v4 0/2] Regular expression support for test output matching Cupertino Miranda
2024-06-13 15:20 ` [PATCH bpf-next v4 1/2] selftests/bpf: Support checks against a regular expression Cupertino Miranda
2024-06-13 15:20 ` [PATCH bpf-next v4 2/2] selftests/bpf: Match tests against " Cupertino Miranda
2024-06-13 20:09 ` Eduard Zingerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6786876cd4b7eaf6c249bf5ed1e4ebf02f26aad7.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=cupertino.miranda@oracle.com \
--cc=david.faust@oracle.com \
--cc=jose.marchesi@oracle.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox