From: Eduard Zingerman <eddyz87@gmail.com>
To: Fuyu Zhao <zhaofuyu@vivo.com>,
bpf@vger.kernel.org, andrii.nakryiko@gmail.com,
alan.maguire@oracle.com
Cc: andrii@kernel.org, ast@kernel.org, daniel@iogearbox.net,
memxor@gmail.com, martin.lau@linux.dev, song@kernel.org,
yonghong.song@linux.dev, jolsa@kernel.org, emil@etsalapatis.com,
ihor.solodrai@linux.dev, shuah@kernel.org, yatsenko@meta.com,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [RFC PATCH bpf-next v3 2/2] selftests/bpf: add tests for selective kmod BTF loading
Date: Thu, 20 Aug 2026 17:10:05 -0700 [thread overview]
Message-ID: <67d62b1943b093ac1eb16c9cc1ff38e0d5eda72b.camel@gmail.com> (raw)
In-Reply-To: <20260819090426.267-3-zhaofuyu@vivo.com>
On Wed, 2026-08-19 at 17:04 +0800, Fuyu Zhao wrote:
...
> +++ b/tools/testing/selftests/bpf/prog_tests/kmod_btfs.c
> @@ -0,0 +1,196 @@
> +// SPDX-License-Identifier: GPL-2.0
> +#include <test_progs.h>
> +#include "kmod_btfs.skel.h"
> +
> +static bool btf_skipped;
> +static bool dup_ignored;
> +
> +static const char btf_skip_fmt[] =
> + "libbpf: skipping module BTF '%s', not in kmod_btf_names\n";
> +static const char dup_ignore_fmt[] =
> + "libbpf: duplicate kmod BTF name '%s' ignored\n";
> +
> +static int libbpf_print_cb(enum libbpf_print_level level, const char *fmt,
> + va_list args)
> +{
> + if (!strcmp(fmt, btf_skip_fmt)) {
> + if (!strcmp(va_arg(args, char *), "bpf_test_no_cfi"))
> + btf_skipped = true;
> + } else if (!strcmp(fmt, dup_ignore_fmt)) {
> + if (!strcmp(va_arg(args, char *), "bpf_testmod"))
> + dup_ignored = true;
> + }
> +
> + return 0;
> +}
Idk what Andrii would say about this, but I'd rather add an internal
function akin to:
size_t bpf_object_btf_module_cnt(const struct bpf_object *obj);
in libbpf.c and expose it via libbpf_internal.h (*not* via API),
instead of intercepting log messages.
...
next prev parent reply other threads:[~2026-08-21 0:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-19 9:04 [RFC PATCH bpf-next v3 0/2] libbpf: Improve BPF load performance by selectively loading kmod BTFs Fuyu Zhao
2026-08-19 9:04 ` [RFC PATCH bpf-next v3 1/2] libbpf: support selective kernel module BTF loading via bpf_object_open_opts Fuyu Zhao
2026-08-19 9:12 ` sashiko-bot
2026-08-20 3:19 ` Fuyu Zhao
2026-08-19 9:35 ` bot+bpf-ci
2026-08-20 3:27 ` Fuyu Zhao
2026-08-20 23:58 ` Eduard Zingerman
2026-08-21 3:51 ` Fuyu Zhao
2026-08-21 18:51 ` Andrii Nakryiko
2026-08-22 11:57 ` Fuyu Zhao
2026-08-19 9:04 ` [RFC PATCH bpf-next v3 2/2] selftests/bpf: add tests for selective kmod BTF loading Fuyu Zhao
2026-08-19 9:12 ` sashiko-bot
2026-08-20 3:20 ` Fuyu Zhao
2026-08-19 9:50 ` bot+bpf-ci
2026-08-20 3:28 ` Fuyu Zhao
2026-08-21 0:10 ` Eduard Zingerman [this message]
2026-08-21 3:51 ` Fuyu Zhao
2026-08-21 18:55 ` Andrii Nakryiko
2026-08-22 11:57 ` Fuyu Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67d62b1943b093ac1eb16c9cc1ff38e0d5eda72b.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=alan.maguire@oracle.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=emil@etsalapatis.com \
--cc=ihor.solodrai@linux.dev \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=yatsenko@meta.com \
--cc=yonghong.song@linux.dev \
--cc=zhaofuyu@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox