From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E03119F461 for ; Wed, 14 Aug 2024 10:20:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723630842; cv=none; b=EjLmw8pHz2M5B9gbtOBw9cgVIdrxfh9s7u6ESEKgOtf7jZNUQUaKXTDeRAwFYGvW/JL8/+1968RU9xPChw9uLCxPC70xYVIwbrEEWS/kYuPsSzWMhxpo4+TlSkpPFzSD19JVQHd3/0mribM+70pwfG8NX1rv2pHrs3Gs8fy29Z8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723630842; c=relaxed/simple; bh=OesaZVG85sa5tJ2CWd0ZRjKD4AAHsYi37iOiX+FHu/A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AZPUteEvINl8hVUb7XoolkbGoSjXaXgEQWcoapO1/KeSC7BSAlVQ5FoR6ig6cfGdQzg0NOtqODftfDXiGPHPMbgYCpbH0cqHwMhZrqDA9UI96Y4QGQdGacQR6icr7PrtPN/Th0hqHvGnHT5LNtqxPvOOpPw+Z8oTzw7x0gBJvdo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=EBQxMtO8; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="EBQxMtO8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723630840; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ArvT52QZCzAIBxygYJAvMZW0y/eajEvYt8KDonFX9zk=; b=EBQxMtO8uLPG4qafiGO+zJoRgrixDMDhYP/Jb0r9CuaAtm0wD+4poyclRESyR4B7m+Nutl /MDwXc/Y6sYyE46KnSkMCbRKe3jamrdWT9GazPvfnFHUhAMXu63nYPsfdJeE4+bkhFHmzN 5PsCZaLnlmcigQcmylHGujx8+jMeoUA= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-148-fEZsEvU4NlCHfq8e-W3MrQ-1; Wed, 14 Aug 2024 06:20:38 -0400 X-MC-Unique: fEZsEvU4NlCHfq8e-W3MrQ-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-42809bbece7so997005e9.0 for ; Wed, 14 Aug 2024 03:20:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723630837; x=1724235637; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ArvT52QZCzAIBxygYJAvMZW0y/eajEvYt8KDonFX9zk=; b=LooMd3VhUyVLIN12tY6gnxB+vx+PvHncxn3CtUJ+h58/HMHhvfD0diOVpmeCOmaR9B hFhNqXtFqUsA7EnU8TjPR5uPNYpoXluVTrkX4NaKYIq4/ZYPk4MRpoAPUaiDsPtrnmP/ EULQ0ibNbp94HOVcJXO4TvbyalO2r2aQSNxL2nJ7+deK+bi332zLLQru4b7VpksvJaIi ClZFjPz0cW0GZ1WjQRGPWeDadOGmLyxLyeLentXlJ2oXY2ZKU2W5lK90n1gSo6P0/JpK Xwb/nHYCGzUvOR5LjysEN+L7chzg7mGiYGPhEwM+fcPftiN0meYbLDfvZ4kUL6YSREas XWJA== X-Forwarded-Encrypted: i=1; AJvYcCVlF40e7NRmJMnyAioufWMDks3VcsPy+xcuepHD4QmqxavrLuz6b6tji/QHEu2/330yKGvcNnbny9YIGHwiAjpTTczy X-Gm-Message-State: AOJu0YxlTosDbJ9WLAOncjEaVt68Vqq6gZCU0aG+yXsbYutUFlPesMa4 xAZ3srg+/WILCm9EEs1EiDGtvnKN+SsUBB8VuHCUrotpOtFKFUlqjPU3BwNu8mlR13m4eQc7MvM UcDKQ3o+2zcOJQPkW5MqEr31JyGcOxkERL2enm3QG7JvFRt/0rA== X-Received: by 2002:a05:6000:1a8d:b0:36d:1d66:554f with SMTP id ffacd0b85a97d-371777b426cmr1041936f8f.3.1723630837327; Wed, 14 Aug 2024 03:20:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEWUqTtYdG3Z83woA9aA35QcrGb+K5syL0svoCJ4GlfCHLPwm9xo1NeGshX8quWbWdeBH9ywQ== X-Received: by 2002:a05:6000:1a8d:b0:36d:1d66:554f with SMTP id ffacd0b85a97d-371777b426cmr1041911f8f.3.1723630836299; Wed, 14 Aug 2024 03:20:36 -0700 (PDT) Received: from ?IPV6:2a0d:3344:1711:4010:5731:dfd4:b2ed:d824? ([2a0d:3344:1711:4010:5731:dfd4:b2ed:d824]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36e4c36bea4sm12524894f8f.13.2024.08.14.03.20.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Aug 2024 03:20:35 -0700 (PDT) Message-ID: <696bc883-68f5-48f0-bf7e-258b4dc05bcc@redhat.com> Date: Wed, 14 Aug 2024 12:20:34 +0200 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net 2/2] selftests: udpgro: no need to load xdp for gro To: Hangbin Liu , netdev@vger.kernel.org Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Shuah Khan , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , =?UTF-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= , Ignat Korchagin , linux-kselftest@vger.kernel.org, bpf@vger.kernel.org, Yi Chen References: <20240814075758.163065-1-liuhangbin@gmail.com> <20240814075758.163065-3-liuhangbin@gmail.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20240814075758.163065-3-liuhangbin@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/14/24 09:57, Hangbin Liu wrote: > After commit d7db7775ea2e ("net: veth: do not manipulate GRO when using > XDP"), there is no need to load XDP program to enable GRO. On the other > hand, the current test is failed due to loading the XDP program. e.g. > > # selftests: net: udpgro.sh > # ipv4 > # no GRO ok > # no GRO chk cmsg ok > # GRO ./udpgso_bench_rx: recv: bad packet len, got 1472, expected 14720 > # > # failed > > [...] > > # bad GRO lookup ok > # multiple GRO socks ./udpgso_bench_rx: recv: bad packet len, got 1452, expected 14520 > # > # ./udpgso_bench_rx: recv: bad packet len, got 1452, expected 14520 > # > # failed > ok 1 selftests: net: udpgro.sh > > After fix, all the test passed. > > # ./udpgro.sh > ipv4 > no GRO ok > [...] > multiple GRO socks ok > > Fixes: d7db7775ea2e ("net: veth: do not manipulate GRO when using XDP") > Reported-by: Yi Chen > Closes: https://issues.redhat.com/browse/RHEL-53858 > Signed-off-by: Hangbin Liu LGTM, Acked-by: Paolo Abeni