From: Eduard Zingerman <eddyz87@gmail.com>
To: Cupertino Miranda <cupertino.miranda@oracle.com>, bpf@vger.kernel.org
Cc: Yonghong Song <yonghong.song@linux.dev>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
David Faust <david.faust@oracle.com>,
Jose Marchesi <jose.marchesi@oracle.com>,
Elena Zannoni <elena.zannoni@oracle.com>,
Andrii Nakryiko <andrii.nakryiko@gmail.com>
Subject: Re: [PATCH bpf-next v4 7/7] bpf/verifier: improve code after range computation recent changes.
Date: Tue, 30 Apr 2024 09:48:45 -0700 [thread overview]
Message-ID: <6d9cf43b7465da52bdd028143809110a9c9658e5.camel@gmail.com> (raw)
In-Reply-To: <c1d17ea3c74e7cec4ba2457e2d6b88d324064af9.camel@gmail.com>
On Mon, 2024-04-29 at 16:29 -0700, Eduard Zingerman wrote:
> On Mon, 2024-04-29 at 16:16 -0700, Eduard Zingerman wrote:
> [...]
>
> > Still, I'm not sure if we want to remove this safety check.
>
> ... and if we are going to remove the safety check,
> then at-least there should be a warning like there was before the
> commit from 2018. Which is almost the same amount of code as current
> 'check + invalid flag'.
My bad. I've been reminded by Yonghong that adjust_reg_min_max_vals()
is called from check_alu_op(), which does reg_bounds_sanity_check()
upon return.
This patch is fine and there is also no need to change anything in
patch #2, as it would be removed. Sorry for the noise.
Acked-by: Eduard Zingerman <eddyz87@gmail.com>
next prev parent reply other threads:[~2024-04-30 16:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 21:22 [PATCH bpf-next v4 0/7] bpf/verifier: range computation improvements Cupertino Miranda
2024-04-29 21:22 ` [PATCH bpf-next v4 1/7] bpf/verifier: replace calls to mark_reg_unknown Cupertino Miranda
2024-04-29 21:22 ` [PATCH bpf-next v4 2/7] bpf/verifier: refactor checks for range computation Cupertino Miranda
2024-04-29 23:18 ` Eduard Zingerman
2024-04-30 7:17 ` Cupertino Miranda
2024-04-30 14:52 ` Alexei Starovoitov
2024-04-29 21:22 ` [PATCH bpf-next v4 3/7] bpf/verifier: improve XOR and OR " Cupertino Miranda
2024-04-29 21:22 ` [PATCH bpf-next v4 4/7] selftests/bpf: XOR and OR range computation tests Cupertino Miranda
2024-04-29 21:22 ` [PATCH bpf-next v4 5/7] bpf/verifier: relax MUL range computation check Cupertino Miranda
2024-04-29 21:22 ` [PATCH bpf-next v4 6/7] selftests/bpf: MUL range computation tests Cupertino Miranda
2024-04-29 21:22 ` [PATCH bpf-next v4 7/7] bpf/verifier: improve code after range computation recent changes Cupertino Miranda
2024-04-29 23:16 ` Eduard Zingerman
2024-04-29 23:29 ` Eduard Zingerman
2024-04-30 16:48 ` Eduard Zingerman [this message]
2024-05-03 14:14 ` [PATCH bpf-next v4 0/7] bpf/verifier: range computation improvements Cupertino Miranda
2024-05-03 16:20 ` Alexei Starovoitov
2024-05-03 16:42 ` Cupertino Miranda
2024-05-03 18:18 ` Eduard Zingerman
2024-05-03 19:33 ` Cupertino Miranda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d9cf43b7465da52bdd028143809110a9c9658e5.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=cupertino.miranda@oracle.com \
--cc=david.faust@oracle.com \
--cc=elena.zannoni@oracle.com \
--cc=jose.marchesi@oracle.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).