From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37ABEC77B60 for ; Fri, 28 Apr 2023 15:45:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229526AbjD1PpF (ORCPT ); Fri, 28 Apr 2023 11:45:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345961AbjD1Pot (ORCPT ); Fri, 28 Apr 2023 11:44:49 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC15E1BEE for ; Fri, 28 Apr 2023 08:44:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682696640; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z52A2epDMtjRB7IyuBnSb7ySFSqz6b9gtxUebojTu/U=; b=A4Ory1LyjDGwONQcNSrOaX+Lh/m/H8LpIdMA8Kb9KrhxirfKsYQbws1h4wY+0uSJOw9S3v lA3sGRYX5IEOZF971xkFZ2Wyx8hPJ8yZ9hduRPcN/lG0x6Bud/PSHuC4pgMKIGTiuyk6Dg oCs3CmOCtkD3q4xWfrDU278+ZMe/+OE= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-316-mbkrzcFHMLO3PgFtuHvwhg-1; Fri, 28 Apr 2023 11:43:58 -0400 X-MC-Unique: mbkrzcFHMLO3PgFtuHvwhg-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-3f170a1fbe7so62513625e9.2 for ; Fri, 28 Apr 2023 08:43:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682696637; x=1685288637; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=z52A2epDMtjRB7IyuBnSb7ySFSqz6b9gtxUebojTu/U=; b=d3hdVY5xxoVnlizf8l71iIpfLGsP8k4kXNj8FkFTeBHLDRES9q12OKmJA7zYYXFjFk PzPctXShZ9QglWGUjIo521iXKmUYzux8TG4OitS+4orM1g87S0T6y8EDgZaA3D9o6Wop pbwE7EEcycesePZhnyhuD14w1aQod89RjnKYdxBu2LZwvWiOv007yRlEuisNW3DKM127 nr2pDn1Wdjzzd2XD7cwGM0ZhHyzPc0QpFSZU8sx/LWzuvg0KhPHct2SAfwQZ6GRfYu6L aqzEWD2fiqFofoJtKY+48wF22w9S97mqyFzL7rCJQlVV5jgm30NmMac82oGY4lflHbWh DKFg== X-Gm-Message-State: AC+VfDxSe0TUkPGm5iM432kPd04rXWGuSSSXTNmQo4/PaQS7QnJdI/Rv Idv0Tr+lIIUzLWkJN8ssaSs15o0mFjyTVq1hkn3CIDEIOOrvz9lTJIfwuHNysQ+kTeWX68h9zaG M/h5yf6sJNK83 X-Received: by 2002:adf:e5c2:0:b0:2f0:2e3a:cc04 with SMTP id a2-20020adfe5c2000000b002f02e3acc04mr4464930wrn.8.1682696637440; Fri, 28 Apr 2023 08:43:57 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6wEhjz0VVh2A4yxTM88Y8pY83WdtJTvH5OQ/Kn0YUc/whJBUGLAJhUYYchTfzNdSztLQVdkw== X-Received: by 2002:adf:e5c2:0:b0:2f0:2e3a:cc04 with SMTP id a2-20020adfe5c2000000b002f02e3acc04mr4464893wrn.8.1682696637049; Fri, 28 Apr 2023 08:43:57 -0700 (PDT) Received: from ?IPV6:2003:cb:c726:9300:1711:356:6550:7502? (p200300cbc72693001711035665507502.dip0.t-ipconnect.de. [2003:cb:c726:9300:1711:356:6550:7502]) by smtp.gmail.com with ESMTPSA id r16-20020a5d4e50000000b002c7066a6f77sm21439153wrt.31.2023.04.28.08.43.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Apr 2023 08:43:55 -0700 (PDT) Message-ID: <6ddc7ac4-4091-632a-7b2c-df2005438ec4@redhat.com> Date: Fri, 28 Apr 2023 17:43:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v5] mm/gup: disallow GUP writing to file-backed mappings by default Content-Language: en-US From: David Hildenbrand To: Lorenzo Stoakes Cc: Jason Gunthorpe , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Jens Axboe , Matthew Wilcox , Dennis Dalessandro , Leon Romanovsky , Christian Benvenuti , Nelson Escobar , Bernard Metzler , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Bjorn Topel , Magnus Karlsson , Maciej Fijalkowski , Jonathan Lemon , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Christian Brauner , Richard Cochran , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , linux-fsdevel@vger.kernel.org, linux-perf-users@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, Oleg Nesterov , John Hubbard , Jan Kara , "Kirill A . Shutemov" , Pavel Begunkov , Mika Penttila , David Howells , Christoph Hellwig References: <6b73e692c2929dc4613af711bdf92e2ec1956a66.1682638385.git.lstoakes@gmail.com> <094d2074-5b69-5d61-07f7-9f962014fa68@redhat.com> <400da248-a14e-46a4-420a-a3e075291085@redhat.com> <077c4b21-8806-455f-be98-d7052a584259@lucifer.local> <62ec50da-5f73-559c-c4b3-bde4eb215e08@redhat.com> Organization: Red Hat In-Reply-To: <62ec50da-5f73-559c-c4b3-bde4eb215e08@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On 28.04.23 17:34, David Hildenbrand wrote: > On 28.04.23 17:33, Lorenzo Stoakes wrote: >> On Fri, Apr 28, 2023 at 05:23:29PM +0200, David Hildenbrand wrote: >>>>> >>>>> Security is the primary case where we have historically closed uAPI >>>>> items. >>>> >>>> As this patch >>>> >>>> 1) Does not tackle GUP-fast >>>> 2) Does not take care of !FOLL_LONGTERM >>>> >>>> I am not convinced by the security argument in regard to this patch. >>>> >>>> >>>> If we want to sells this as a security thing, we have to block it >>>> *completely* and then CC stable. >>> >>> Regarding GUP-fast, to fix the issue there as well, I guess we could do >>> something similar as I did in gup_must_unshare(): >>> >>> If we're in GUP-fast (no VMA), and want to pin a !anon page writable, >>> fallback to ordinary GUP. IOW, if we don't know, better be safe. >> >> How do we determine it's non-anon in the first place? The check is on the >> VMA. We could do it by following page tables down to folio and checking >> folio->mapping for PAGE_MAPPING_ANON I suppose? > > PageAnon(page) can be called from GUP-fast after grabbing a reference. > See gup_must_unshare(). IIRC, PageHuge() can also be called from GUP-fast and could special-case hugetlb eventually, as it's table while we hold a (temporary) reference. Shmem might be not so easy ... -- Thanks, David / dhildenb