From: Daniel Borkmann <daniel@iogearbox.net>
To: John Fastabend <john.fastabend@gmail.com>,
Liu Jian <liujian56@huawei.com>,
jakub@cloudflare.com, ast@kernel.org, andrii@kernel.org,
martin.lau@linux.dev, song@kernel.org, yonghong.song@linux.dev,
kpsingh@kernel.org, sdf@google.com, haoluo@google.com,
jolsa@kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, dsahern@kernel.org
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH bpf-next v6 0/7] add BPF_F_PERMANENT flag for sockmap skmsg redirect
Date: Thu, 26 Oct 2023 15:56:10 +0200 [thread overview]
Message-ID: <6e117922-e249-37cf-2327-55355de200e2@iogearbox.net> (raw)
In-Reply-To: <65383d6f3d15c_1969a2084a@john.notmuch>
On 10/24/23 11:55 PM, John Fastabend wrote:
> Liu Jian wrote:
>> v5->v6: Modified the description of the helper function.
>> v4->v5: Fix one refcount bug caused by patch1.
>> v3->v4: Change the two helpers's description.
>> Let BPF_F_PERMANENT takes precedence over apply/cork_bytes.
>>
>> Liu Jian (7):
>> bpf, sockmap: add BPF_F_PERMANENT flag for skmsg redirect
>> selftests/bpf: Add txmsg permanently test for sockmap
>> selftests/bpf: Add txmsg redir permanently test for sockmap
>> selftests/bpf: add skmsg verdict tests
>> selftests/bpf: add two skmsg verdict tests for BPF_F_PERMANENT flag
>> selftests/bpf: add tests for verdict skmsg to itself
>> selftests/bpf: add tests for verdict skmsg to closed socket
>>
>> include/linux/skmsg.h | 1 +
>> include/uapi/linux/bpf.h | 45 +++++--
>> net/core/skmsg.c | 6 +-
>> net/core/sock_map.c | 4 +-
>> net/ipv4/tcp_bpf.c | 12 +-
>> tools/include/uapi/linux/bpf.h | 45 +++++--
>> .../selftests/bpf/prog_tests/sockmap_basic.c | 122 ++++++++++++++++++
>> .../selftests/bpf/progs/test_sockmap_kern.h | 3 +-
>> .../bpf/progs/test_sockmap_msg_verdict.c | 25 ++++
>> tools/testing/selftests/bpf/test_sockmap.c | 41 +++++-
>> 10 files changed, 272 insertions(+), 32 deletions(-)
>> create mode 100644 tools/testing/selftests/bpf/progs/test_sockmap_msg_verdict.c
>>
>
> Reviewed-by: John Fastabend <john.fastabend@gmail.com>
Looks like this needs one last rebase, doesn't apply against bpf-next:
Switched to a new branch 'mbox'
Applying: bpf, sockmap: Add BPF_F_PERMANENT flag for skmsg redirect
Applying: selftests/bpf: Add txmsg permanently test for sockmap
Applying: selftests/bpf: Add txmsg redir permanently test for sockmap
Applying: selftests/bpf: Add skmsg verdict tests
error: patch failed: tools/testing/selftests/bpf/prog_tests/sockmap_basic.c:475
error: tools/testing/selftests/bpf/prog_tests/sockmap_basic.c: patch does not apply
Patch failed at 0004 selftests/bpf: Add skmsg verdict tests
hint: Use 'git am --show-current-patch' to see the failed patch
Thanks,
Daniel
next prev parent reply other threads:[~2023-10-26 13:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-14 12:16 [PATCH bpf-next v6 0/7] add BPF_F_PERMANENT flag for sockmap skmsg redirect Liu Jian
2023-10-14 12:17 ` [PATCH bpf-next v6 1/7] bpf, sockmap: add BPF_F_PERMANENT flag for " Liu Jian
2023-10-14 12:17 ` [PATCH bpf-next v6 2/7] selftests/bpf: Add txmsg permanently test for sockmap Liu Jian
2023-10-14 12:17 ` [PATCH bpf-next v6 3/7] selftests/bpf: Add txmsg redir " Liu Jian
2023-10-14 12:17 ` [PATCH bpf-next v6 4/7] selftests/bpf: add skmsg verdict tests Liu Jian
2023-10-14 12:17 ` [PATCH bpf-next v6 5/7] selftests/bpf: add two skmsg verdict tests for BPF_F_PERMANENT flag Liu Jian
2023-10-14 12:17 ` [PATCH bpf-next v6 6/7] selftests/bpf: add tests for verdict skmsg to itself Liu Jian
2023-10-14 12:17 ` [PATCH bpf-next v6 7/7] selftests/bpf: add tests for verdict skmsg to closed socket Liu Jian
2023-10-24 21:55 ` [PATCH bpf-next v6 0/7] add BPF_F_PERMANENT flag for sockmap skmsg redirect John Fastabend
2023-10-26 13:56 ` Daniel Borkmann [this message]
2023-10-28 9:59 ` liujian (CE)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e117922-e249-37cf-2327-55355de200e2@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=haoluo@google.com \
--cc=jakub@cloudflare.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=liujian56@huawei.com \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox