From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-185.mta1.migadu.com (out-185.mta1.migadu.com [95.215.58.185]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1150F10A09 for ; Wed, 10 Jul 2024 19:02:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.185 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720638148; cv=none; b=dln8OrwViGSnVLreYOuk+COfe4lrWljXfI9ZvLFFFvhvxDDjVNY85c3bYv18FjqT0TcnteRhIy1S2CmRJaWj348qio0PbAUdwlpQyUE15fyTCxAOG6nh/fanPy7NNxtEtHlxuTYGu77b1HZDZPoFNeiXt87YkKKHfOteEx4RUg4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720638148; c=relaxed/simple; bh=fc437HQY8yiJIsjlX9F0RjRqMTWZVkDc7aa8GqbmVJk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HYzXHOHoYV9bD/SZnpQaWgHPze33fJa4qICWLlnIOpA2rKssV1wSWl35b3iDN/4seGjpivodchq9285eQWRz+++fXf+7cTPE7Pl2aEqBmoa+1uGQ1n7UXtafHpYNSYdo3i692UxdO4xhT8MOvneMvzIRoZ6oXMNPQQ38emku8eE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=W8s8hqpR; arc=none smtp.client-ip=95.215.58.185 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="W8s8hqpR" X-Envelope-To: geliang@kernel.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1720638145; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ma0qYEzNM5cTb8Uw4LJ05n3jlw6cmx0IGuI5qsyPeAw=; b=W8s8hqpRQQdSyaG4qvUkFN7peQYdBoPmj82vZqNx8OxQ4cA85kykw0EEa2bMBszqwMGYMo /6t1ITaF+eMMLZnMLbFhmLIyOhVS9tHRyYKaeP1++QXTaNiJqsXYniTVZGdkeYFwgHa9o1 UkfAKRRxd0YNgpW9ZKji3Lec4voxCQU= X-Envelope-To: andrii@kernel.org X-Envelope-To: eddyz87@gmail.com X-Envelope-To: mykolal@fb.com X-Envelope-To: ast@kernel.org X-Envelope-To: daniel@iogearbox.net X-Envelope-To: song@kernel.org X-Envelope-To: yonghong.song@linux.dev X-Envelope-To: john.fastabend@gmail.com X-Envelope-To: kpsingh@kernel.org X-Envelope-To: haoluo@google.com X-Envelope-To: jolsa@kernel.org X-Envelope-To: shuah@kernel.org X-Envelope-To: tanggeliang@kylinos.cn X-Envelope-To: bpf@vger.kernel.org X-Envelope-To: linux-kselftest@vger.kernel.org X-Envelope-To: sdf@fomichev.me Message-ID: <6e1b4388-bd07-4315-8bc6-b13226eac2dc@linux.dev> Date: Wed, 10 Jul 2024 12:02:17 -0700 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH bpf-next v11 3/9] selftests/bpf: Close fd in error path in drop_on_reuseport To: Geliang Tang Cc: Andrii Nakryiko , Eduard Zingerman , Mykola Lysenko , Alexei Starovoitov , Daniel Borkmann , Song Liu , Yonghong Song , John Fastabend , KP Singh , Hao Luo , Jiri Olsa , Shuah Khan , Geliang Tang , bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, Stanislav Fomichev References: <86aed33b4b0ea3f04497c757845cff7e8e621a2d.1720515893.git.tanggeliang@kylinos.cn> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Martin KaFai Lau In-Reply-To: <86aed33b4b0ea3f04497c757845cff7e8e621a2d.1720515893.git.tanggeliang@kylinos.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 7/9/24 2:16 AM, Geliang Tang wrote: > From: Geliang Tang > > In the error path when update_lookup_map() fails in drop_on_reuseport in > prog_tests/sk_lookup.c, "server1", the fd of server 1, should be closed. > This patch fixes this by using "goto close_srv1" lable instead of "detach" > to close "server1" in this case. > A reference to the Fixes tag will be useful Fixes: 0ab5539f8584 ("selftests/bpf: Tests for BPF_SK_LOOKUP attach point")