From: Quentin Monnet <qmo@kernel.org>
To: "Alexis Lothoré" <alexis.lothore@bootlin.com>,
liujing <liujing@cmss.chinamobile.com>,
daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev,
eddyz87@gmail.com, song@kernel.org, yonghong.song@linux.dev,
john.fastabend@gmail.com, kpsingh@kernel.org, sdf@fomichev.me,
haoluo@google.com, jolsa@kernel.org
Cc: bpf@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bpftool: Fix the wrong format specifier
Date: Thu, 21 Nov 2024 15:35:29 +0000 [thread overview]
Message-ID: <6e2e589b-4ddd-411e-a1a7-a2caf9689417@kernel.org> (raw)
In-Reply-To: <edfccd59-007c-411d-8ca0-17bf3b9f1f43@bootlin.com>
2024-11-21 13:43 UTC+0100 ~ Alexis Lothoré <alexis.lothore@bootlin.com>
> Hi Liujing,
>
> On 11/21/24 13:17, liujing wrote:
>> The type of lines is unsigned int, so the correct format specifier should be
>> %u instead of %d.
>>
>> Signed-off-by: liujing <liujing@cmss.chinamobile.com>
>>
>> V1 -> V2: Fixed two other wrong type outputs about lines
>
> This commit changelog line should not appear in the commit message. This is
> still useful for review though, so you can keep it in the commit by using a ---
> separator (see other patches on the ML), which will make it automatically
> trimmed when the maintainers will apply the patch.
Also next time please remember to tag your patch as "v2" in the email
subject.
Patch looks good, thank you!
Reviewed-by: Quentin Monnet <qmo@kernel.org>
next prev parent reply other threads:[~2024-11-21 15:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-21 12:17 [PATCH] bpftool: Fix the wrong format specifier liujing
2024-11-21 12:43 ` Alexis Lothoré
2024-11-21 15:35 ` Quentin Monnet [this message]
2024-11-25 22:32 ` Alexei Starovoitov
-- strict thread matches above, loose matches on Subject: below --
2024-11-21 8:55 liujing
2024-11-21 11:46 ` Quentin Monnet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e2e589b-4ddd-411e-a1a7-a2caf9689417@kernel.org \
--to=qmo@kernel.org \
--cc=alexis.lothore@bootlin.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liujing@cmss.chinamobile.com \
--cc=martin.lau@linux.dev \
--cc=sdf@fomichev.me \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox