From: "libaokun (A)" <libaokun1@huawei.com>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: <akpm@linux-foundation.org>, <keescook@chromium.org>,
<yzaikin@google.com>, <ast@kernel.org>, <daniel@iogearbox.net>,
<andrii@kernel.org>, <kafai@fb.com>, <songliubraving@fb.com>,
<yhs@fb.com>, <john.fastabend@gmail.com>, <kpsingh@kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>,
<netdev@vger.kernel.org>, <bpf@vger.kernel.org>,
<yukuai3@huawei.com>, Hulk Robot <hulkci@huawei.com>,
Baokun Li <libaokun1@huawei.com>
Subject: Re: [PATCH -next V2] sysctl: returns -EINVAL when a negative value is passed to proc_doulongvec_minmax
Date: Tue, 21 Dec 2021 09:21:08 +0800 [thread overview]
Message-ID: <6ec2155c-c976-4c9b-1975-c28792bb3144@huawei.com> (raw)
In-Reply-To: <YcDWx1P1NdqgED1i@bombadil.infradead.org>
在 2021/12/21 3:17, Luis Chamberlain 写道:
> On Mon, Dec 20, 2021 at 05:26:27PM +0800, Baokun Li wrote:
>> When we pass a negative value to the proc_doulongvec_minmax() function,
>> the function returns 0, but the corresponding interface value does not
>> change.
>>
>> we can easily reproduce this problem with the following commands:
>> `cd /proc/sys/fs/epoll`
>> `echo -1 > max_user_watches; echo $?; cat max_user_watches`
>>
>> This function requires a non-negative number to be passed in, so when
>> a negative number is passed in, -EINVAL is returned.
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: Baokun Li <libaokun1@huawei.com>
> Acked-by: Luis Chamberlain <mcgrof@kernel.org>
>
> Luis
> .
Thank you for your Ack.
--
With Best Regards,
Baokun Li
prev parent reply other threads:[~2021-12-21 1:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-20 9:26 [PATCH -next V2] sysctl: returns -EINVAL when a negative value is passed to proc_doulongvec_minmax Baokun Li
2021-12-20 19:17 ` Luis Chamberlain
2021-12-21 1:21 ` libaokun (A) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ec2155c-c976-4c9b-1975-c28792bb3144@huawei.com \
--to=libaokun1@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=hulkci@huawei.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=keescook@chromium.org \
--cc=kpsingh@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
--cc=yukuai3@huawei.com \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox