Re: [PATCH v8 bpf-next 03/10] libbpf: use kind layout to compute an unknown kind size

[Alan Maguire <alan.maguire@oracle.com>]

On 16/12/2025 06:07, Eduard Zingerman wrote:
> On Mon, 2025-12-15 at 09:17 +0000, Alan Maguire wrote:
> 
> [...]
> 
>> @@ -395,8 +416,7 @@ static int btf_type_size(const struct btf_type *t)
>>  	case BTF_KIND_DECL_TAG:
>>  		return base_size + sizeof(struct btf_decl_tag);
>>  	default:
>> -		pr_debug("Unsupported BTF_KIND:%u\n", btf_kind(t));
>> -		return -EINVAL;
>> +		return btf_type_size_unknown(btf, t);
>>  	}
>>  }
>>  
> 
> That's a matter of personal preference, of-course, but it seems to me
> that using `kind_layouts` table from your next patch for size
> computation for all kinds would be a bit more elegant.
> 
> Also, a question, should BTF validation check sizes for known kinds
> and reject kind layout sections if those sizes differ from expected?
>

yeah, I'd say we'd need your second suggestion for the first to be safe,
and it seems worthwhile doing both I think. Thanks!
 
> [...]