From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="K16+Is2c" Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00464194 for ; Tue, 21 Nov 2023 08:20:45 -0800 (PST) Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-5431614d90eso8396332a12.1 for ; Tue, 21 Nov 2023 08:20:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700583644; x=1701188444; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=jYZbYF0hpYPEjoGfF2Ku2QIZJNWhNTIS4ijhNnV+zME=; b=K16+Is2cwtxyw9/3emeoNG+XyBmxuDWAMfxOFclNjI4FXqC6Fw9+lGc+BTvNuc3lvN XbQQcENxv8w/BXVGFADGfsTuGfLDG44FuN0KRtmGMmuHcR2gnybT/yBscvBlpiSzkwzB LYIp7JuaLXSzjEksHVK3E4GBBlOZS3OrZh1JEnmWde5psMEIBS6rmiJt2QmDQ/73/2r2 qG2Ym3aJPU8aEHttKRE6fWlrKKM3O1B4e/CzKyJxRlCzhMEXrANkKA4f/F//HfF/MMV1 7ig22LGzKcrrmo2JDnKM+XhVfOj2gjrmyVjOZC0E1tecPa0Qacpgy8N8WwfpDJyeYQlK 8UZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700583644; x=1701188444; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jYZbYF0hpYPEjoGfF2Ku2QIZJNWhNTIS4ijhNnV+zME=; b=uEbdsYR/N+250L4hfiQRuz4kPbE2ZBD9D+l1ij+AhoexANG4deYlzrUlJ/4x7Y9QlT ok6VrZs5utIy6mmk7LYX82l8n0hiIryhkaXKUXCX1qJwAWBuUt64MWj/Rfi4fxVx+JXM +4nBFEXdYKJ+we6Q6516vh572PoVll8/ZJCFbP2pQTqx8LwtqleylL/BV6gnE4jPt0hx hsVXn2iXIunhLWIprVkr1gM2I5U3DXjPv0oHbdglIaBsyRbtGv/Hx9LuEXhVV0obZOCe JtE/8ZosO7an1I82c/pJHM2tTIYPMOC+hHhWiifCDcmZ7afFenPk1rxFwtw0vFDef2Jb 2EIw== X-Gm-Message-State: AOJu0YyP7mi/xcke+NCbupFBQsonopMwny/9/6Vuh/JDIyE25fOgipV8 jL2Sc59O6zlpMmeDCClOMAQ= X-Google-Smtp-Source: AGHT+IEBTfhkbdIMNz5jNyB8YtAlHr93aaTDcnP0kpYT2xQYaN1Csk5iXiDRaU+fBOZBPeWz1kvHIg== X-Received: by 2002:a05:6402:14c2:b0:548:d6ce:ec1c with SMTP id f2-20020a05640214c200b00548d6ceec1cmr2050695edx.21.1700583644301; Tue, 21 Nov 2023 08:20:44 -0800 (PST) Received: from [192.168.1.95] (host-176-36-0-241.b024.la.net.ua. [176.36.0.241]) by smtp.gmail.com with ESMTPSA id v9-20020aa7dbc9000000b005484ee5c856sm4618715edt.86.2023.11.21.08.20.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Nov 2023 08:20:43 -0800 (PST) Message-ID: <6f94c0cd5b7585a2278291b814b34acffb9dd245.camel@gmail.com> Subject: Re: [PATCH v2 bpf-next 10/10] bpf: use common instruction history across all states From: Eduard Zingerman To: Andrii Nakryiko , bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net, martin.lau@kernel.org Cc: kernel-team@meta.com Date: Tue, 21 Nov 2023 18:20:42 +0200 In-Reply-To: <20231121002221.3687787-11-andrii@kernel.org> References: <20231121002221.3687787-1-andrii@kernel.org> <20231121002221.3687787-11-andrii@kernel.org> Autocrypt: addr=eddyz87@gmail.com; prefer-encrypt=mutual; keydata=mQGNBGKNNQEBDACwcUNXZOGTzn4rr7Sd18SA5Wv0Wna/ONE0ZwZEx+sIjyGrPOIhR14/DsOr3ZJer9UJ/WAJwbxOBj6E5Y2iF7grehljNbLr/jMjzPJ+hJpfOEAb5xjCB8xIqDoric1WRcCaRB+tDSk7jcsIIiMish0diTK3qTdu4MB6i/sh4aeFs2nifkNi3LdBuk8Xnk+RJHRoKFJ+C+EoSmQPuDQIRaF9N2m4yO0eG36N8jLwvUXnZzGvHkphoQ9ztbRJp58oh6xT7uH62m98OHbsVgzYKvHyBu/IU2ku5kVG9pLrFp25xfD4YdlMMkJH6l+jk+cpY0cvMTS1b6/g+1fyPM+uzD8Wy+9LtZ4PHwLZX+t4ONb/48i5AKq/jSsb5HWdciLuKEwlMyFAihZamZpEj+9n91NLPX4n7XeThXHaEvaeVVl4hfW/1Qsao7l1YjU/NCHuLaDeH4U1P59bagjwo9d1n5/PESeuD4QJFNqW+zkmE4tmyTZ6bPV6T5xdDRHeiITGc00AEQEAAbQkRWR1YXJkIFppbmdlcm1hbiA8ZWRkeXo4N0BnbWFpbC5jb20+iQHUBBMBCgA+FiEEx+6LrjApQyqnXCYELgxleklgRAkFAmKNNQECGwMFCQPCZwAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQLgxleklgRAlWZAv/cJ5v3zlEyP0/jMKQBqbVCCHTirPEw+nqxbkeSO6r2FUds0NnGA9a6NPOpBH+qW7a6+n6q3sIbvH7jlss4pzLI7LYlDC6z+egTv7KR5X1xFrY1uR5UGs1beAjnzYeV2hK4yqRUfygsT0Wk5e4FiNBv4+DUZ8r0cNDkO6swJxU55DO21mcteC147+4aDoHZ40R0tsAu+brDGSSoOPpb0RWVsEf9XOBJqWWA+T7mluw nYzhLWGcczc6J71q1Dje0l5vIPaSFOgwmWD4DA+WvuxM/shH4rtWeodbv iCTce6yYIygHgUAtJcHozAlgRrL0jz44cggBTcoeXp/atckXK546OugZPnl00J3qmm5uWAznU6T5YDv2vCvAMEbz69ib+kHtnOSBvR0Jb86UZZqSb4ATfwMOWe9htGTjKMb0QQOLK0mTcrk/TtymaG+T4Fsos0kgrxqjgfrxxEhYcVNW8v8HISmFGFbqsJmFbVtgk68BcU0wgF8oFxo7u+XYQDdKbI1uQGNBGKNNQEBDADbQIdo8L3sdSWGQtu+LnFqCZoAbYurZCmUjLV3df1b+sg+GJZvVTmMZnzDP/ADufcbjopBBjGTRAY4L76T2niu2EpjclMMM3mtrOc738Kr3+RvPjUupdkZ1ZEZaWpf4cZm+4wH5GUfyu5pmD5WXX2i1r9XaUjeVtebvbuXWmWI1ZDTfOkiz/6Z0GDSeQeEqx2PXYBcepU7S9UNWttDtiZ0+IH4DZcvyKPUcK3tOj4u8GvO3RnOrglERzNCM/WhVdG1+vgU9fXO83TB/PcfAsvxYSie7u792s/I+yA4XKKh82PSTvTzg2/4vEDGpI9yubkfXRkQN28w+HKF5qoRB8/L1ZW/brlXkNzA6SveJhCnH7aOF0Yezl6TfX27w1CW5Xmvfi7X33V/SPvo0tY1THrO1c+bOjt5F+2/K3tvejmXMS/I6URwa8n1e767y5ErFKyXAYRweE9zarEgpNZTuSIGNNAqK+SiLLXt51G7P30TVavIeB6s2lCt1QKt62ccLqUAEQEAAYkBvAQYAQoAJhYhBMfui64wKUMqp1wmBC4MZXpJYEQJBQJijTUBAhsMBQkDwmcAAAoJEC4MZXpJYEQJkRAMAKNvWVwtXm/WxWoiLnXyF2WGXKoDe5+itTLvBmKcV/b1OKZF1s90V7WfSBz712eFAynEzyeezPbwU8QBiTpZcHXwQni3IYKvsh7s t1iq+gsfnXbPz5AnS598ScZI1oP7OrPSFJkt/z4acEbOQDQs8aUqrd46PV jsdqGvKnXZxzylux29UTNby4jTlz9pNJM+wPrDRmGfchLDUmf6CffaUYCbu4FiId+9+dcTCDvxbABRy1C3OJ8QY7cxfJ+pEZW18fRJ0XCl/fiV/ecAOfB3HsqgTzAn555h0rkFgay0hAvMU/mAW/CFNSIxV397zm749ZNLA0L2dMy1AKuOqH+/B+/ImBfJMDjmdyJQ8WU/OFRuGLdqOd2oZrA1iuPIa+yUYyZkaZfz/emQwpIL1+Q4p1R/OplA4yc301AqruXXUcVDbEB+joHW3hy5FwK5t5OwTKatrSJBkydSF9zdXy98fYzGniRyRA65P0Ix/8J3BYB4edY2/w0Ip/mdYsYQljBY0A== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.1 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2023-11-20 at 16:22 -0800, Andrii Nakryiko wrote: > Instead of allocating and copying instruction history each time we > enqueue child verifier state, switch to a model where we use one common > dynamically sized array of instruction history entries across all states. >=20 > The key observation for proving this is correct is that instruction > history is only relevant while state is active, which means it either is > a current state (and thus we are actively modifying instruction history > and no other state can interfere with us) or we are checkpointed state > with some children still active (either enqueued or being current). >=20 > In the latter case our portion of instruction history is finalized and > won't change or grow, so as long as we keep it immutable until the state > is finalized, we are good. >=20 > Now, when state is finalized and is put into state hash for potentially > future pruning lookups, instruction history is not used anymore. This is > because instruction history is only used by precision marking logic, and > we never modify precision markings for finalized states. >=20 > So, instead of each state having its own small instruction history, we > keep a global dynamically-sized instruction history, where each state in > current DFS path from root to active state remembers its portion of > instruction history. Current state can append to this history, but > cannot modify any of its parent histories. >=20 > Because the insn_hist array can be grown through realloc, states don't > keep pointers, they instead maintain two indices, [start, end), into > global instruction history array. End is exclusive index, so > `start =3D=3D end` means there is no relevant instruction history. >=20 > This eliminates a lot of allocations and minimizes overall memory usage. >=20 > Signed-off-by: Andrii Nakryiko > --- Acked-by: Eduard Zingerman [...]