From: Jesper Dangaard Brouer <jbrouer@redhat.com>
To: Quentin Monnet <quentin@isovalent.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>
Cc: brouer@redhat.com, Martin KaFai Lau <kafai@fb.com>,
Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>,
bpf@vger.kernel.org, Alejandro Colomar <alx.manpages@gmail.com>,
Jakub Wilk <jwilk@jwilk.net>,
linux-man@vger.kernel.org
Subject: Re: [PATCH bpf-next] bpf: Fix a few typos in BPF helpers documentation
Date: Fri, 26 Aug 2022 12:31:06 +0200 [thread overview]
Message-ID: <6fd7a7ef-00a4-a599-5857-8bb1c0dc0f71@redhat.com> (raw)
In-Reply-To: <20220825092631.11605-1-quentin@isovalent.com>
On 25/08/2022 11.26, Quentin Monnet wrote:
> Address a few typos in the documentation for the BPF helper functions.
> They were reported by Jakub [0], who ran spell checkers on the generated
> man page [1].
>
> Sync-up the UAPI header with its version in tools/.
>
> [0]https://lore.kernel.org/linux-man/d22dcd47-023c-8f52-d369-7b5308e6c842@gmail.com/T/#mb02e7d4b7fb61d98fa914c77b581184e9a9537af
> [1]https://lore.kernel.org/linux-man/eb6a1e41-c48e-ac45-5154-ac57a2c76108@gmail.com/T/#m4a8d1b003616928013ffcd1450437309ab652f9f
>
> Cc: Alejandro Colomar<alx.manpages@gmail.com>
> Cc: Jakub Wilk<jwilk@jwilk.net>
> Cc: Jesper Dangaard Brouer<brouer@redhat.com>
> Cc:linux-man@vger.kernel.org
> Reported-by: Jakub Wilk<jwilk@jwilk.net>
> Signed-off-by: Quentin Monnet<quentin@isovalent.com>
> ---
> include/uapi/linux/bpf.h | 16 ++++++++--------
> tools/include/uapi/linux/bpf.h | 18 +++++++++---------
> 2 files changed, 17 insertions(+), 17 deletions(-)
>
> diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h
> index 644600dbb114..e4d3810990be 100644
> --- a/include/uapi/linux/bpf.h
> +++ b/include/uapi/linux/bpf.h
> @@ -4728,12 +4728,12 @@ union bpf_attr {
> *
> * The argument*len_diff* can be used for querying with a planned
> * size change. This allows to check MTU prior to changing packet
> - * ctx. Providing an*len_diff* adjustment that is larger than the
> + * ctx. Providing a*len_diff* adjustment that is larger than the
> * actual packet size (resulting in negative packet size) will in
> - * principle not exceed the MTU, why it is not considered a
> - * failure. Other BPF-helpers are needed for performing the
> - * planned size change, why the responsability for catch a negative
> - * packet size belong in those helpers.
> + * principle not exceed the MTU, which is why it is not considered
> + * a failure. Other BPF helpers are needed for performing the
> + * planned size change, therefore the responsibility for catching
> + * a negative packet size belongs in those helpers.
> *
> * Specifying*ifindex* zero means the MTU check is performed
> * against the current net device. This is practical if this isn't
Thanks for improving these formulations.
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
prev parent reply other threads:[~2022-08-26 10:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 9:26 [PATCH bpf-next] bpf: Fix a few typos in BPF helpers documentation Quentin Monnet
2022-08-25 10:58 ` Alejandro Colomar
2022-08-26 10:31 ` Jesper Dangaard Brouer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6fd7a7ef-00a4-a599-5857-8bb1c0dc0f71@redhat.com \
--to=jbrouer@redhat.com \
--cc=alx.manpages@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=jwilk@jwilk.net \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=quentin@isovalent.com \
--cc=sdf@google.com \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox