From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 163E9C433F5 for ; Mon, 6 Dec 2021 10:20:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236174AbhLFKXq (ORCPT ); Mon, 6 Dec 2021 05:23:46 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:42134 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235804AbhLFKXp (ORCPT ); Mon, 6 Dec 2021 05:23:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1638786017; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=skvl+6MlZe2GRtwWiKsWPPv+qj696SGkXDdPY29ZI68=; b=PwGI0Gpu1MRlBizQ2/lSh7MsLRyrOsEerAqlxfuS/ymdLIize5abTNCL7K+nJAC9m+t8W4 +vAA5f+0blaXkPnnMixgHSxlSksG/vjkaxIXwKdHrJBj0DHbA4Q5HGc8bcQFh04U/sY5Mo BeGWOVbl7IYP5j4XBgk5yeDd3J8D0/Q= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-536-rrB2FglrNqq6hxgNlOEA4w-1; Mon, 06 Dec 2021 05:20:15 -0500 X-MC-Unique: rrB2FglrNqq6hxgNlOEA4w-1 Received: by mail-wm1-f70.google.com with SMTP id 144-20020a1c0496000000b003305ac0e03aso7632851wme.8 for ; Mon, 06 Dec 2021 02:20:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=skvl+6MlZe2GRtwWiKsWPPv+qj696SGkXDdPY29ZI68=; b=IKJnLsEkUIHnMOlzZY/IKIybk9hRxqiww7YOQpb5nVCJGkHJ/SejG25DccXHKCWP7T 4r67f73+OkMAw9kCYUQ/GlwyEsrpj0DQZH5xV1K0bSKwwKysvRHbgIrNtDv2Dgy5xOEN BhAJiFX6K4iRDhCH3H8BvwgkOSaB/etQruCvxq96nbkLg59NvrJcZNn9OijmEidDHi/K wdCvx8OAvdlMSLZzxFKvTu5uHqSXD7KB7lsJMj3HXllX65rEp4DjLQ38ldZ1Bjk6KN5T V2R5+8Abs9eyiJgnnoglhHnLW+X/GQW9aGIGGzlpWD2Zod/OduFx1d1727KmRP6p720N hUSQ== X-Gm-Message-State: AOAM533exg7+yc9wQcIrruGh4J25iv0j+xZducItzJ3GE/bTnQzDQXwy taiJbkESjZUtNeJcmJ++7nsdBvNTG+rL6NOFONGcr+JYyAmazQJ289jhIkWd6VZvt1MVYj0aqeo /vD1MN4fpJEPl X-Received: by 2002:adf:de0b:: with SMTP id b11mr43412671wrm.588.1638786014227; Mon, 06 Dec 2021 02:20:14 -0800 (PST) X-Google-Smtp-Source: ABdhPJyJiuKvUp0ap6UDuQ+CQtsADuNwSK6Bhc9fw6BiPV+bnd3NHq2D/xUosreRUQdLxRNZrQsDIA== X-Received: by 2002:adf:de0b:: with SMTP id b11mr43412655wrm.588.1638786014048; Mon, 06 Dec 2021 02:20:14 -0800 (PST) Received: from gerbillo.redhat.com (146-241-252-1.dyn.eolo.it. [146.241.252.1]) by smtp.gmail.com with ESMTPSA id h7sm10369117wrt.64.2021.12.06.02.20.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Dec 2021 02:20:13 -0800 (PST) Message-ID: <70c5f1a6ecdc67586d108ab5ebed4be6febf8423.camel@redhat.com> Subject: Re: [PATCH v3 net-next 2/2] bpf: let bpf_warn_invalid_xdp_action() report more info From: Paolo Abeni To: Daniel Borkmann , netdev@vger.kernel.org Cc: Alexei Starovoitov , bpf@vger.kernel.org, Toke =?ISO-8859-1?Q?H=F8iland-J=F8rgensen?= Date: Mon, 06 Dec 2021 11:20:12 +0100 In-Reply-To: <1ac2941f-b751-9cf0-f0e3-ea0f245b7503@iogearbox.net> References: <1ac2941f-b751-9cf0-f0e3-ea0f245b7503@iogearbox.net> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 (3.42.1-1.fc35) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Fri, 2021-12-03 at 23:04 +0100, Daniel Borkmann wrote: > Hi Paolo, > > Changes look good to me as well, we can route the series via bpf-next after tree > resync, or alternatively ask David/Jakub to take it directly into net-next with our > Ack given in bpf-next there is no drivers/net/ethernet/microsoft/mana/mana_bpf.c yet. > > On 11/30/21 11:08 AM, Paolo Abeni wrote: > [...]> diff --git a/net/core/filter.c b/net/core/filter.c > > index 5631acf3f10c..392838fa7652 100644 > > --- a/net/core/filter.c > > +++ b/net/core/filter.c > > @@ -8181,13 +8181,13 @@ static bool xdp_is_valid_access(int off, int size, > > return __is_valid_xdp_access(off, size); > > } > > > > -void bpf_warn_invalid_xdp_action(u32 act) > > +void bpf_warn_invalid_xdp_action(struct net_device *dev, struct bpf_prog *prog, u32 act) > > { > > const u32 act_max = XDP_REDIRECT; > > > > - pr_warn_once("%s XDP return value %u, expect packet loss!\n", > > + pr_warn_once("%s XDP return value %u on prog %s (id %d) dev %s, expect packet loss!\n", > > act > act_max ? "Illegal" : "Driver unsupported", > > - act); > > + act, prog->aux->name, prog->aux->id, dev ? dev->name : ""); > > One tiny nit, but we could fix it up while applying I'd have is that for !dev case > we should probably dump a "" or so just to avoid a kernel log message like > "dev , expect packet loss". Yep, that would probably be better. Pleas let me know it you prefer a formal new version for the patch. Thanks! Paolo