BPF List
 help / color / mirror / Atom feed
From: Eduard Zingerman <eddyz87@gmail.com>
To: Shung-Hsi Yu <shung-hsi.yu@suse.com>
Cc: bpf@vger.kernel.org, linux-kselftest@vger.kernel.org,
	Andrii Nakryiko <andrii@kernel.org>,
	Mykola Lysenko <mykolal@fb.com>,
	Yonghong Song <yonghong.song@linux.dev>,
	Jiri Olsa <jolsa@kernel.org>
Subject: Re: Re: lsm_cgroup.c selftest fails to compile when CONFIG_PACKET!=y
Date: Fri, 19 Jan 2024 14:23:44 +0200	[thread overview]
Message-ID: <71ac757d092c6103af7c6d0ebb4634afcaa0969a.camel@gmail.com> (raw)
In-Reply-To: <uf7fpvox2s3ban33ybixlg2buxbh2ys2gl7wjrphuip2qrdsjr@56dp2546tuuu>

On Fri, 2024-01-19 at 16:04 +0800, Shung-Hsi Yu wrote:

[...]

> Final goal would be have BPF selftests compiled and test against our own
> kernel, without having to come up with a specific kernel flavor that is
> used to build and run the selftest. For v5.14 and v5.19-based kernel it
> works: compilation is successful and I was able to run the verifier
> tests. (Did not try running the other tests though)

You mean ./test_verifier binary, right?
A lot of tests had been moved from ./test_verifier to ./test_progs since.

> > As far as I understand, selftests are supposed to be built and run
> > using specific configuration, here is how config for x86 CI is prepared:
> > 
> > ./scripts/kconfig/merge_config.sh \
> >          ./tools/testing/selftests/bpf/config \
> >          ./tools/testing/selftests/bpf/config.vm \
> >          ./tools/testing/selftests/bpf/config.x86_64
> > 
> > (root is kernel source).
> > I'm not sure if other configurations are supposed to be supported.
> 
> Would it make sense to have makefile target that builds/runs a smaller
> subset of general, config-agnostic selftests that tests the core feature
> (e.g. verifier + instruction set)?

In ideal world I'd say that ./test_progs should include/exclude tests
conditioned on current configuration, but I don't know how much work
would it be to adapt build system for this.

  reply	other threads:[~2024-01-19 12:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-18 11:58 lsm_cgroup.c selftest fails to compile when CONFIG_PACKET!=y Shung-Hsi Yu
2024-01-18 15:58 ` Eduard Zingerman
2024-01-18 16:05   ` Eduard Zingerman
2024-01-18 20:57     ` Yonghong Song
2024-01-19  8:04   ` Shung-Hsi Yu
2024-01-19 12:23     ` Eduard Zingerman [this message]
2024-01-19 15:00       ` Vincent Li
2024-01-19 22:26         ` Alexei Starovoitov
2024-01-19 23:12           ` Vincent Li
2024-01-19 23:35             ` Andrii Nakryiko
2024-01-19 23:54               ` Vincent Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=71ac757d092c6103af7c6d0ebb4634afcaa0969a.camel@gmail.com \
    --to=eddyz87@gmail.com \
    --cc=andrii@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mykolal@fb.com \
    --cc=shung-hsi.yu@suse.com \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox