From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F52312D76C for ; Thu, 15 Feb 2024 10:36:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707993390; cv=none; b=huos1GS/Y+JsKjJ7+lnYM0KPfWHBDforHSlM6rcwfwsaycS919bNmAokt91u1+Sp53wk2Ujp8bKVlmTHMjY/03Rm45JrMWuljCN2oS+FmvMW48DStA2j/11ha15whHHs9ycgBRMMvFbcxeRJkD3mdpYjeaFN2fS52uiLQI7PJoQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707993390; c=relaxed/simple; bh=5oS12a1+72pCetee/pRRwlcEJNXteRPPJ7auFcYDWx0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=X8Vg70T28ernPIBssI1o6sDD8LOqO8V34U3vMX4vq/sP574iGfULIvQ1lSag+iFxxpm6yIrcVIsEEXNcj0Ra+25yyYd017mzdNcfg8vsKgqsnrex8oVEX4pLnnTlwlN7k8Pk5WD5fcsSUAO0UJaqY7yNif7Gos3Ye1Cm2xGNe1Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=jYcIOh7n; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="jYcIOh7n" Received: from pps.filterd (m0353724.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 41F90FQm013242; Thu, 15 Feb 2024 10:35:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=0Lkd6nG2l1dtyAWgztLgpaGyC5DsaIeusO5eKZMkEBg=; b=jYcIOh7nez39njav3GC+DYC+yt409Qu6wbgK8IAgfjq1xHTLU8Hg3uK59a3ec2aQg7j1 S9Ngzs44XvxgSv9M0uaX0a0dOQObQvoFwEVGPyJAsKtNtTLZlsl44/YtMdlVcmhGUMHC j5YSe0Dpf+Jd25x4gkrh6nuElo1ldSJbE57Gb3WWhLz8UtQ8vWzKMi/bnGIn6NW8Vvg6 KzOzQ1tThT+6vC+mop3oMJG9WfZIVkFR/ycqkVtNchWTQc6d4nMYtbQbnc2BhLQQe0Pm crSCNy8cy/xvEYWW/jbNVpdfR6lTYas8ePKAq08WqK88bQCXB3asvPGSj/d5g8axZdn2 GQ== Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3w9fkkt7ru-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 Feb 2024 10:35:54 +0000 Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 41F9e2Ap009904; Thu, 15 Feb 2024 10:35:54 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 3w6p633mrt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 Feb 2024 10:35:54 +0000 Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 41FAZooO18154122 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 15 Feb 2024 10:35:52 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 49FEA20043; Thu, 15 Feb 2024 10:35:50 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 31D8A2004B; Thu, 15 Feb 2024 10:35:47 +0000 (GMT) Received: from [9.43.101.252] (unknown [9.43.101.252]) by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTP; Thu, 15 Feb 2024 10:35:46 +0000 (GMT) Message-ID: <71d6f107-7fd5-45f9-b2cd-e2d1b018720a@linux.ibm.com> Date: Thu, 15 Feb 2024 16:05:45 +0530 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] powerpc/bpf: enable kfunc call Content-Language: en-US To: Christophe Leroy , linuxppc-dev , "bpf@vger.kernel.org" Cc: Michael Ellerman , "Naveen N. Rao" , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Song Liu , Martin KaFai Lau References: <20240201171249.253097-1-hbathini@linux.ibm.com> <20240201171249.253097-2-hbathini@linux.ibm.com> <4dd99601-6990-444c-af23-95cb3f7b156b@csgroup.eu> From: Hari Bathini In-Reply-To: <4dd99601-6990-444c-af23-95cb3f7b156b@csgroup.eu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: TrzXTGFBWof91yLdJ646PcDA4ucgAwkv X-Proofpoint-ORIG-GUID: TrzXTGFBWof91yLdJ646PcDA4ucgAwkv X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-15_10,2024-02-14_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 phishscore=0 spamscore=0 bulkscore=0 clxscore=1015 malwarescore=0 adultscore=0 lowpriorityscore=0 mlxlogscore=999 mlxscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2402150083 On 13/02/24 1:24 pm, Christophe Leroy wrote: > > > Le 01/02/2024 à 18:12, Hari Bathini a écrit : >> With module addresses supported, override bpf_jit_supports_kfunc_call() >> to enable kfunc support. Module address offsets can be more than 32-bit >> long, so override bpf_jit_supports_far_kfunc_call() to enable 64-bit >> pointers. > > What's the impact on PPC32 ? There are no 64-bit pointers on PPC32. Yeah. Not required to return true for PPC32 case and probably not a good thing to claim support for far kfunc calls for PPC32. Changing to: +bool bpf_jit_supports_far_kfunc_call(void) +{ + return IS_ENABLED(CONFIG_PPC64); +} >> >> Signed-off-by: Hari Bathini >> --- >> >> * No changes since v1. >> >> >> arch/powerpc/net/bpf_jit_comp.c | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/arch/powerpc/net/bpf_jit_comp.c b/arch/powerpc/net/bpf_jit_comp.c >> index 7b4103b4c929..f896a4213696 100644 >> --- a/arch/powerpc/net/bpf_jit_comp.c >> +++ b/arch/powerpc/net/bpf_jit_comp.c >> @@ -359,3 +359,13 @@ void bpf_jit_free(struct bpf_prog *fp) >> >> bpf_prog_unlock_free(fp); >> } >> + >> +bool bpf_jit_supports_kfunc_call(void) >> +{ >> + return true; >> +} >> + >> +bool bpf_jit_supports_far_kfunc_call(void) >> +{ >> + return true; >> +}