From: Hengqi Chen <hengqi.chen@gmail.com>
To: Song Liu <song@kernel.org>
Cc: bpf <bpf@vger.kernel.org>, Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>, Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>
Subject: Re: [PATCH bpf-next 1/2] bpf: Add bpf_skc_to_unix_sock() helper
Date: Thu, 7 Oct 2021 12:02:58 +0800 [thread overview]
Message-ID: <733921fd-62e9-f230-3dd0-e0082ac33a39@gmail.com> (raw)
In-Reply-To: <CAPhsuW5B-C3p-1yJjzWoXm-Mp=USkW4x72pw8i9YPYH=zOMP5A@mail.gmail.com>
On 10/6/21 1:00 PM, Song Liu wrote:
> On Tue, Oct 5, 2021 at 9:08 PM Hengqi Chen <hengqi.chen@gmail.com> wrote:
>>
>> The helper is used in tracing programs to cast a socket
>> pointer to a unix_sock pointer.
>> The return value could be NULL if the casting is illegal.
>>
>> Suggested-by: Yonghong Song <yhs@fb.com>
>> Signed-off-by: Hengqi Chen <hengqi.chen@gmail.com>
>
> Acked-by: Song Liu <songliubraving@fb.com>
>
> With one nitpick below.
>
> [...]
>> --- a/scripts/bpf_doc.py
>> +++ b/scripts/bpf_doc.py
>> @@ -250,17 +250,17 @@ class PrinterRST(Printer):
>> license = '''\
>> .. Copyright (C) All BPF authors and contributors from 2014 to present.
>> .. See git log include/uapi/linux/bpf.h in kernel tree for details.
>> -..
>> +..
>
> nit: We usually exclude these trailing space changes from the patch.
>
Thanks for the review, will drop these unrelated changes in v2.
next prev parent reply other threads:[~2021-10-07 4:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-06 4:06 [PATCH bpf-next 0/2] Add bpf_skc_to_unix_sock() helper Hengqi Chen
2021-10-06 4:06 ` [PATCH bpf-next 1/2] bpf: " Hengqi Chen
2021-10-06 5:00 ` Song Liu
2021-10-07 4:02 ` Hengqi Chen [this message]
2021-10-06 4:06 ` [PATCH bpf-next 2/2] selftests/bpf: Test bpf_skc_to_unix_sock() Hengqi Chen
2021-10-06 5:09 ` Song Liu
2021-10-07 4:05 ` Hengqi Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=733921fd-62e9-f230-3dd0-e0082ac33a39@gmail.com \
--to=hengqi.chen@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=song@kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox