From: Martin KaFai Lau <martin.lau@linux.dev>
To: Jason Xing <kerneljasonxing@gmail.com>
Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
dsahern@kernel.org, willemb@google.com, ast@kernel.org,
daniel@iogearbox.net, andrii@kernel.org, eddyz87@gmail.com,
song@kernel.org, yonghong.song@linux.dev,
john.fastabend@gmail.com, kpsingh@kernel.org, sdf@fomichev.me,
haoluo@google.com, jolsa@kernel.org, horms@kernel.org,
bpf@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH bpf-next v8 10/12] bpf: make TCP tx timestamp bpf extension work
Date: Thu, 6 Feb 2025 18:07:25 -0800 [thread overview]
Message-ID: <739d6f98-8a44-446e-85a4-c499d154b57b@linux.dev> (raw)
In-Reply-To: <CAL+tcoCUjxvE-DaQ8AMxMgjLnV+J1jpYMh7BCOow4AohW1FFSg@mail.gmail.com>
On 2/5/25 10:56 PM, Jason Xing wrote:
>>> I have to rephrase a bit in case Martin visits here soon: I will
>>> compare two approaches 1) reply value, 2) bpf kfunc and then see which
>>> way is better.
>>
>> I have already explained in details why the 1) reply value from the bpf prog
>> won't work. Please go back to that reply which has the context.
>
> Yes, of course I saw this, but I said I need to implement and dig more
> into this on my own. One of my replies includes a little code snippet
> regarding reply value approach. I didn't expect you to misunderstand
> that I would choose reply value, so I rephrase it like above :)
I did see the code snippet which is incomplete, so I have to guess. afaik, it is
not going to work. I was hoping to save some time without detouring to the
reply-value path in case my earlier message was missed. I will stay quiet and
wait for v9 first then to avoid extending this long thread further.
next prev parent reply other threads:[~2025-02-07 2:07 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-04 18:30 [PATCH bpf-next v8 00/12] net-timestamp: bpf extension to equip applications transparently Jason Xing
2025-02-04 18:30 ` [PATCH bpf-next v8 01/12] bpf: add support for bpf_setsockopt() Jason Xing
2025-02-05 15:22 ` Willem de Bruijn
2025-02-05 15:34 ` Jason Xing
2025-02-05 20:57 ` Martin KaFai Lau
2025-02-05 21:25 ` Willem de Bruijn
2025-02-04 18:30 ` [PATCH bpf-next v8 02/12] bpf: prepare for timestamping callbacks use Jason Xing
2025-02-04 18:30 ` [PATCH bpf-next v8 03/12] bpf: stop unsafely accessing TCP fields in bpf callbacks Jason Xing
2025-02-05 15:24 ` Willem de Bruijn
2025-02-05 15:35 ` Jason Xing
2025-02-04 18:30 ` [PATCH bpf-next v8 04/12] bpf: stop calling some sock_op BPF CALLs in new timestamping callbacks Jason Xing
2025-02-05 15:26 ` Willem de Bruijn
2025-02-05 15:50 ` Jason Xing
2025-02-04 18:30 ` [PATCH bpf-next v8 05/12] net-timestamp: prepare for isolating two modes of SO_TIMESTAMPING Jason Xing
2025-02-05 1:47 ` Jakub Kicinski
2025-02-05 2:40 ` Jason Xing
2025-02-05 3:14 ` Jakub Kicinski
2025-02-05 3:23 ` Jason Xing
2025-02-05 1:50 ` Jakub Kicinski
2025-02-05 15:34 ` Willem de Bruijn
2025-02-05 15:52 ` Jason Xing
2025-02-06 8:43 ` Jason Xing
2025-02-06 10:22 ` Jason Xing
2025-02-06 16:13 ` Willem de Bruijn
2025-02-07 0:22 ` Jason Xing
2025-02-04 18:30 ` [PATCH bpf-next v8 06/12] bpf: support SCM_TSTAMP_SCHED " Jason Xing
2025-02-05 15:36 ` Willem de Bruijn
2025-02-05 15:55 ` Jason Xing
2025-02-04 18:30 ` [PATCH bpf-next v8 07/12] bpf: support sw SCM_TSTAMP_SND " Jason Xing
2025-02-04 18:30 ` [PATCH bpf-next v8 08/12] bpf: support hw " Jason Xing
2025-02-05 15:45 ` Willem de Bruijn
2025-02-05 16:03 ` Jason Xing
2025-02-10 22:39 ` Martin KaFai Lau
2025-02-11 0:00 ` Jason Xing
2025-02-04 18:30 ` [PATCH bpf-next v8 09/12] bpf: support SCM_TSTAMP_ACK " Jason Xing
2025-02-05 15:47 ` Willem de Bruijn
2025-02-05 16:06 ` Jason Xing
2025-02-05 21:25 ` Willem de Bruijn
2025-02-04 18:30 ` [PATCH bpf-next v8 10/12] bpf: make TCP tx timestamp bpf extension work Jason Xing
2025-02-05 1:57 ` Jakub Kicinski
2025-02-05 2:15 ` Jason Xing
2025-02-05 21:57 ` Martin KaFai Lau
2025-02-06 0:12 ` Jason Xing
2025-02-06 0:42 ` Jason Xing
2025-02-06 0:47 ` Martin KaFai Lau
2025-02-06 1:05 ` Jason Xing
2025-02-06 2:39 ` Jason Xing
2025-02-06 2:56 ` Willem de Bruijn
2025-02-06 3:09 ` Jason Xing
2025-02-06 3:25 ` Willem de Bruijn
2025-02-06 3:41 ` Jason Xing
2025-02-06 6:12 ` Martin KaFai Lau
2025-02-06 6:56 ` Jason Xing
2025-02-07 2:07 ` Martin KaFai Lau [this message]
2025-02-07 2:18 ` Jason Xing
2025-02-07 12:07 ` Jason Xing
2025-02-08 2:11 ` Martin KaFai Lau
2025-02-08 6:53 ` Jason Xing
2025-02-07 13:34 ` Jason Xing
2025-02-04 18:30 ` [PATCH bpf-next v8 11/12] bpf: add a new callback in tcp_tx_timestamp() Jason Xing
2025-02-05 5:28 ` Jason Xing
2025-02-04 18:30 ` [PATCH bpf-next v8 12/12] selftests/bpf: add simple bpf tests in the tx path for timestamping feature Jason Xing
2025-02-05 15:54 ` Willem de Bruijn
2025-02-05 16:08 ` Jason Xing
2025-02-06 1:28 ` Martin KaFai Lau
2025-02-06 2:14 ` Jason Xing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=739d6f98-8a44-446e-85a4-c499d154b57b@linux.dev \
--to=martin.lau@linux.dev \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=eddyz87@gmail.com \
--cc=edumazet@google.com \
--cc=haoluo@google.com \
--cc=horms@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kerneljasonxing@gmail.com \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=song@kernel.org \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox