* [REPOST PATCH net-next] xsk: add missing virtual address conversion for page
@ 2025-05-21 9:00 Bui Quang Minh
2025-05-21 12:53 ` Alexander Lobakin
0 siblings, 1 reply; 2+ messages in thread
From: Bui Quang Minh @ 2025-05-21 9:00 UTC (permalink / raw)
To: netdev
Cc: Alexei Starovoitov, Daniel Borkmann, David S. Miller,
Jakub Kicinski, Jesper Dangaard Brouer, John Fastabend,
Eric Dumazet, Paolo Abeni, Simon Horman, Maciej Fijalkowski,
Alexander Lobakin, bpf, linux-kernel, Bui Quang Minh
In commit 7ead4405e06f ("xsk: convert xdp_copy_frags_from_zc() to use
page_pool_dev_alloc()"), when converting from netmem to page, I missed a
call to page_address() around skb_frag_page(frag) to get the virtual
address of the page. This commit uses skb_frag_address() helper to fix
the issue.
Signed-off-by: Bui Quang Minh <minhquangbui99@gmail.com>
---
net/core/xdp.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/core/xdp.c b/net/core/xdp.c
index e6f22ba61c1e..491334b9b8be 100644
--- a/net/core/xdp.c
+++ b/net/core/xdp.c
@@ -709,8 +709,7 @@ static noinline bool xdp_copy_frags_from_zc(struct sk_buff *skb,
return false;
}
- memcpy(page_address(page) + offset,
- skb_frag_page(frag) + skb_frag_off(frag),
+ memcpy(page_address(page) + offset, skb_frag_address(frag),
LARGEST_ALIGN(len));
__skb_fill_page_desc_noacc(sinfo, i, page, offset, len);
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [REPOST PATCH net-next] xsk: add missing virtual address conversion for page
2025-05-21 9:00 [REPOST PATCH net-next] xsk: add missing virtual address conversion for page Bui Quang Minh
@ 2025-05-21 12:53 ` Alexander Lobakin
0 siblings, 0 replies; 2+ messages in thread
From: Alexander Lobakin @ 2025-05-21 12:53 UTC (permalink / raw)
To: Bui Quang Minh
Cc: netdev, Alexei Starovoitov, Daniel Borkmann, David S. Miller,
Jakub Kicinski, Jesper Dangaard Brouer, John Fastabend,
Eric Dumazet, Paolo Abeni, Simon Horman, Maciej Fijalkowski, bpf,
linux-kernel
From: Bui Quang Minh <minhquangbui99@gmail.com>
Date: Wed, 21 May 2025 16:00:35 +0700
> In commit 7ead4405e06f ("xsk: convert xdp_copy_frags_from_zc() to use
> page_pool_dev_alloc()"), when converting from netmem to page, I missed a
> call to page_address() around skb_frag_page(frag) to get the virtual
> address of the page. This commit uses skb_frag_address() helper to fix
> the issue.
>
> Signed-off-by: Bui Quang Minh <minhquangbui99@gmail.com>
As for the code, then:
Reviewed-by: Alexander Lobakin <aleksander.lobakin@intel.com>
But you need to add "Fixes:" tag pointing to the commit you mention.
> ---
> net/core/xdp.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/net/core/xdp.c b/net/core/xdp.c
> index e6f22ba61c1e..491334b9b8be 100644
> --- a/net/core/xdp.c
> +++ b/net/core/xdp.c
> @@ -709,8 +709,7 @@ static noinline bool xdp_copy_frags_from_zc(struct sk_buff *skb,
> return false;
> }
>
> - memcpy(page_address(page) + offset,
> - skb_frag_page(frag) + skb_frag_off(frag),
> + memcpy(page_address(page) + offset, skb_frag_address(frag),
> LARGEST_ALIGN(len));
> __skb_fill_page_desc_noacc(sinfo, i, page, offset, len);
Thanks,
Olek
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-05-21 12:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-21 9:00 [REPOST PATCH net-next] xsk: add missing virtual address conversion for page Bui Quang Minh
2025-05-21 12:53 ` Alexander Lobakin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).