From: Martin KaFai Lau <martin.lau@linux.dev>
To: Aditi Ghag <aditi.ghag@isovalent.com>
Cc: kafai@fb.com, Stanislav Fomichev <sdf@google.com>,
edumazet@google.com, bpf@vger.kernel.org
Subject: Re: [PATCH v3 bpf-next 2/5] bpf: Add bpf_sock_destroy kfunc
Date: Tue, 21 Mar 2023 17:36:19 -0700 [thread overview]
Message-ID: <73eafb52-76e2-81b3-93ad-a80379ba6100@linux.dev> (raw)
In-Reply-To: <181130C0-6EC6-49EB-BF16-DC23F36AF254@isovalent.com>
On 3/21/23 5:00 PM, Aditi Ghag wrote:
>> n Mar 21, 2023, at 4:43 PM, Martin KaFai Lau<martin.lau@linux.dev> wrote:
>>
>> On 3/21/23 11:45 AM, Aditi Ghag wrote:
>>> diff --git a/include/net/udp.h b/include/net/udp.h
>>> index de4b528522bb..d2999447d3f2 100644
>>> --- a/include/net/udp.h
>>> +++ b/include/net/udp.h
>>> @@ -437,6 +437,7 @@ struct udp_seq_afinfo {
>>> struct udp_iter_state {
>>> struct seq_net_private p;
>>> int bucket;
>>> + int offset;
>> All offset change is easier to review with patch 1 together, so please move them to patch 1.
> Thanks for the quick review!
>
> Oh boy... Absolutely! Looks like I misplaced the changes during interactive rebase. Can I fix this up in this patch itself instead of creating a new patch series? That way, I can batch things up in the next revision.
>
Instead of re-posting a single patch, it will be easier to batch up all the
changes in one set in the next revision after the review comments in v3.
next prev parent reply other threads:[~2023-03-22 0:36 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 18:45 [PATCH v3 bpf-next 0/5] bpf-next: Add socket destroy capability Aditi Ghag
2023-03-21 18:45 ` [PATCH v3 bpf-next 1/5] bpf: Implement batching in UDP iterator Aditi Ghag
2023-03-21 18:45 ` [PATCH v3 bpf-next 2/5] bpf: Add bpf_sock_destroy kfunc Aditi Ghag
2023-03-21 21:02 ` Stanislav Fomichev
2023-03-23 20:02 ` Aditi Ghag
2023-03-23 21:45 ` Stanislav Fomichev
2023-03-21 23:43 ` Martin KaFai Lau
2023-03-22 0:00 ` Aditi Ghag
2023-03-22 0:36 ` Martin KaFai Lau [this message]
2023-03-21 18:45 ` [PATCH v3 bpf-next 3/5] [RFC] net: Skip taking lock in BPF context Aditi Ghag
2023-03-21 21:31 ` Stanislav Fomichev
2023-03-21 21:37 ` Aditi Ghag
2023-03-21 21:41 ` Eric Dumazet
2023-03-21 21:43 ` Aditi Ghag
2023-03-21 23:39 ` Aditi Ghag
2023-03-22 0:02 ` Martin KaFai Lau
2023-03-21 18:45 ` [PATCH v3 bpf-next 4/5] [RFC] udp: Fix destroying UDP listening sockets Aditi Ghag
2023-03-22 0:29 ` Martin KaFai Lau
2023-03-22 0:59 ` Aditi Ghag
2023-03-22 22:55 ` Martin KaFai Lau
2023-03-23 0:32 ` Aditi Ghag
2023-03-23 1:08 ` Martin KaFai Lau
2023-03-23 1:35 ` Aditi Ghag
2023-03-23 6:14 ` Aditi Ghag
2023-03-21 18:45 ` [PATCH 5/5] selftests/bpf: Add tests for bpf_sock_destroy Aditi Ghag
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73eafb52-76e2-81b3-93ad-a80379ba6100@linux.dev \
--to=martin.lau@linux.dev \
--cc=aditi.ghag@isovalent.com \
--cc=bpf@vger.kernel.org \
--cc=edumazet@google.com \
--cc=kafai@fb.com \
--cc=sdf@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox