Re: [PATCH bpf-next v4 2/2] selftests/xsk: Add tail adjustment tests and support check

[Bastien Curutchet <bastien.curutchet@bootlin.com>]

Hi Maciej

On 3/22/25 2:14 PM, Maciej Fijalkowski wrote:
> On Fri, Mar 21, 2025 at 12:54:19AM +0000, Tushar Vyavahare wrote:
>> Introduce tail adjustment functionality in xskxceiver using
>> bpf_xdp_adjust_tail(). Add `xsk_xdp_adjust_tail` to modify packet sizes
>> and drop unmodified packets. Implement `is_adjust_tail_supported` to check
>> helper availability. Develop packet resizing tests, including shrinking
>> and growing scenarios, with functions for both single-buffer and
>> multi-buffer cases. Update the test framework to handle various scenarios
>> and adjust MTU settings. These changes enhance the testing of packet tail
>> adjustments, improving AF_XDP framework reliability.
>>
>> Signed-off-by: Tushar Vyavahare <tushar.vyavahare@intel.com>
> 
> Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
> 
> We carry the description of executed tests at the beginning of
> xskxceiver.c and you have not updated it with these adjust tail tests but
> it's not a show-stopper to me. I'm okay with current state of this patch.
> 
> Bastien, you probably would want to take into consideration these changes
> if they go in before your bigger work.
> 

Thanks for the pointer, I'll keep an eye on it.

Best regards,
Bastien