From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1772D1E2606; Tue, 11 Mar 2025 09:56:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741686996; cv=none; b=luMBE7qrSpq6bAl7uh3l4HLbv/Jx08+O3yVcjPKQz3yHlf2XG7oh/mUs+3md58MXkOLBMMYUcRMlMpImZqhA0oVV7mKRaPd6pznJnGLU0AEWasgHxMNCHxd54zIbI4XzF1eSrsK6czhl2LSeQvAZTvYfyLTjOXZWp+dYlFq9F5Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741686996; c=relaxed/simple; bh=n6v5ZL2E7JCVU7ELYWCvi7YT1JBg43UQ3+8r4w41cCw=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=oXnyoYJ6KX+NS4Bvzfw3mMTkDTovQJC01mVpCU+lYynv5/mDuwJfJNsywoY7tjLnHdx98RwplfHFNjx2bUP4af8nlSjTkx+zx0amLVC2fg5WdLkrMvpLHDrz8YlAkkhT+9smmIXt/bHmGKaX4xNdMvMk7E0EvazdDW+nUUhNrO4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=JDOjLNqx; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JDOjLNqx" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 07065C4CEEF; Tue, 11 Mar 2025 09:56:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741686995; bh=n6v5ZL2E7JCVU7ELYWCvi7YT1JBg43UQ3+8r4w41cCw=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=JDOjLNqxxyM7VhVBQXT5ry37kup2tD1grskvKexmkuCY/puoWM97BQtvweZDbXEuQ uTfZYj8c/oFcheddtrFAs2sOx3qMIRJ+2PQUxD+Xnmv0f20D9dZNhWOSIG0Qbza77O jtPBIkKoVYLVc4r+apIZKwe2JJ+yixcq/D3QS3Fs7wKQQrjGsj4lxll3XqzcsWkTOg J4dkskRKpqvfpj5GFrXmZ/vRbbGI8CT7BM6RjkMrzp1eNkQE1x+2iCq5uAKrRMLgVK vrD8+iosQ2mUpCdnjNH6J59lhigbzMNVaKMCMVGhIIRi5DgJYkeg//To5OXuWXkgfX PnkUVjknHK+zw== Message-ID: <76c5a00f-ae15-43b8-a917-093ca63cc396@kernel.org> Date: Tue, 11 Mar 2025 10:56:26 +0100 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6.13 102/207] fprobe: Rewrite fprobe on function-graph tracer From: Jiri Slaby To: Greg Kroah-Hartman , stable@vger.kernel.org Cc: patches@lists.linux.dev, "Masami Hiramatsu (Google)" , Alexei Starovoitov , Florent Revest , Martin KaFai Lau , bpf , Alexei Starovoitov , Jiri Olsa , Alan Maguire , Heiko Carstens , Mark Rutland , Catalin Marinas , Will Deacon , Huacai Chen , WANG Xuerui , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan , Paul Walmsley , Palmer Dabbelt , Albert Ou , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Mathieu Desnoyers , Andrew Morton , "Steven Rostedt (Google)" , Sasha Levin References: <20250310170447.729440535@linuxfoundation.org> <20250310170451.816958751@linuxfoundation.org> <8ea06b5e-ec85-42e5-a2e9-9ad747fef217@kernel.org> Content-Language: en-US Autocrypt: addr=jirislaby@kernel.org; keydata= xsFNBE6S54YBEACzzjLwDUbU5elY4GTg/NdotjA0jyyJtYI86wdKraekbNE0bC4zV+ryvH4j rrcDwGs6tFVrAHvdHeIdI07s1iIx5R/ndcHwt4fvI8CL5PzPmn5J+h0WERR5rFprRh6axhOk rSD5CwQl19fm4AJCS6A9GJtOoiLpWn2/IbogPc71jQVrupZYYx51rAaHZ0D2KYK/uhfc6neJ i0WqPlbtIlIrpvWxckucNu6ZwXjFY0f3qIRg3Vqh5QxPkojGsq9tXVFVLEkSVz6FoqCHrUTx wr+aw6qqQVgvT/McQtsI0S66uIkQjzPUrgAEtWUv76rM4ekqL9stHyvTGw0Fjsualwb0Gwdx ReTZzMgheAyoy/umIOKrSEpWouVoBt5FFSZUyjuDdlPPYyPav+hpI6ggmCTld3u2hyiHji2H cDpcLM2LMhlHBipu80s9anNeZhCANDhbC5E+NZmuwgzHBcan8WC7xsPXPaiZSIm7TKaVoOcL 9tE5aN3jQmIlrT7ZUX52Ff/hSdx/JKDP3YMNtt4B0cH6ejIjtqTd+Ge8sSttsnNM0CQUkXps w98jwz+Lxw/bKMr3NSnnFpUZaxwji3BC9vYyxKMAwNelBCHEgS/OAa3EJoTfuYOK6wT6nadm YqYjwYbZE5V/SwzMbpWu7Jwlvuwyfo5mh7w5iMfnZE+vHFwp/wARAQABzSFKaXJpIFNsYWJ5 IDxqaXJpc2xhYnlAa2VybmVsLm9yZz7CwXcEEwEIACEFAlW3RUwCGwMFCwkIBwIGFQgJCgsC BBYCAwECHgECF4AACgkQvSWxBAa0cEnVTg//TQpdIAr8Tn0VAeUjdVIH9XCFw+cPSU+zMSCH eCZoA/N6gitEcnvHoFVVM7b3hK2HgoFUNbmYC0RdcSc80pOF5gCnACSP9XWHGWzeKCARRcQR 4s5YD8I4VV5hqXcKo2DFAtIOVbHDW+0okOzcecdasCakUTr7s2fXz97uuoc2gIBB7bmHUGAH XQXHvdnCLjDjR+eJN+zrtbqZKYSfj89s/ZHn5Slug6w8qOPT1sVNGG+eWPlc5s7XYhT9z66E l5C0rG35JE4PhC+tl7BaE5IwjJlBMHf/cMJxNHAYoQ1hWQCKOfMDQ6bsEr++kGUCbHkrEFwD UVA72iLnnnlZCMevwE4hc0zVhseWhPc/KMYObU1sDGqaCesRLkE3tiE7X2cikmj/qH0CoMWe gjnwnQ2qVJcaPSzJ4QITvchEQ+tbuVAyvn9H+9MkdT7b7b2OaqYsUP8rn/2k1Td5zknUz7iF oJ0Z9wPTl6tDfF8phaMIPISYrhceVOIoL+rWfaikhBulZTIT5ihieY9nQOw6vhOfWkYvv0Dl o4GRnb2ybPQpfEs7WtetOsUgiUbfljTgILFw3CsPW8JESOGQc0Pv8ieznIighqPPFz9g+zSu Ss/rpcsqag5n9rQp/H3WW5zKUpeYcKGaPDp/vSUovMcjp8USIhzBBrmI7UWAtuedG9prjqfO wU0ETpLnhgEQAM+cDWLL+Wvc9cLhA2OXZ/gMmu7NbYKjfth1UyOuBd5emIO+d4RfFM02XFTI t4MxwhAryhsKQQcA4iQNldkbyeviYrPKWjLTjRXT5cD2lpWzr+Jx7mX7InV5JOz1Qq+P+nJW YIBjUKhI03ux89p58CYil24Zpyn2F5cX7U+inY8lJIBwLPBnc9Z0An/DVnUOD+0wIcYVnZAK DiIXODkGqTg3fhZwbbi+KAhtHPFM2fGw2VTUf62IHzV+eBSnamzPOBc1XsJYKRo3FHNeLuS8 f4wUe7bWb9O66PPFK/RkeqNX6akkFBf9VfrZ1rTEKAyJ2uqf1EI1olYnENk4+00IBa+BavGQ 8UW9dGW3nbPrfuOV5UUvbnsSQwj67pSdrBQqilr5N/5H9z7VCDQ0dhuJNtvDSlTf2iUFBqgk 3smln31PUYiVPrMP0V4ja0i9qtO/TB01rTfTyXTRtqz53qO5dGsYiliJO5aUmh8swVpotgK4 /57h3zGsaXO9PGgnnAdqeKVITaFTLY1ISg+Ptb4KoliiOjrBMmQUSJVtkUXMrCMCeuPDGHo7 39Xc75lcHlGuM3yEB//htKjyprbLeLf1y4xPyTeeF5zg/0ztRZNKZicgEmxyUNBHHnBKHQxz 1j+mzH0HjZZtXjGu2KLJ18G07q0fpz2ZPk2D53Ww39VNI/J9ABEBAAHCwV8EGAECAAkFAk6S 54YCGwwACgkQvSWxBAa0cEk3tRAAgO+DFpbyIa4RlnfpcW17AfnpZi9VR5+zr496n2jH/1ld wRO/S+QNSA8qdABqMb9WI4BNaoANgcg0AS429Mq0taaWKkAjkkGAT7mD1Q5PiLr06Y/+Kzdr 90eUVneqM2TUQQbK+Kh7JwmGVrRGNqQrDk+gRNvKnGwFNeTkTKtJ0P8jYd7P1gZb9Fwj9YLx jhn/sVIhNmEBLBoI7PL+9fbILqJPHgAwW35rpnq4f/EYTykbk1sa13Tav6btJ+4QOgbcezWI wZ5w/JVfEJW9JXp3BFAVzRQ5nVrrLDAJZ8Y5ioWcm99JtSIIxXxt9FJaGc1Bgsi5K/+dyTKL wLMJgiBzbVx8G+fCJJ9YtlNOPWhbKPlrQ8+AY52Aagi9WNhe6XfJdh5g6ptiOILm330mkR4g W6nEgZVyIyTq3ekOuruftWL99qpP5zi+eNrMmLRQx9iecDNgFr342R9bTDlb1TLuRb+/tJ98 f/bIWIr0cqQmqQ33FgRhrG1+Xml6UXyJ2jExmlO8JljuOGeXYh6ZkIEyzqzffzBLXZCujlYQ DFXpyMNVJ2ZwPmX2mWEoYuaBU0JN7wM+/zWgOf2zRwhEuD3A2cO2PxoiIfyUEfB9SSmffaK/ S4xXoB6wvGENZ85Hg37C7WDNdaAt6Xh2uQIly5grkgvWppkNy4ZHxE+jeNsU7tg= In-Reply-To: <8ea06b5e-ec85-42e5-a2e9-9ad747fef217@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 11. 03. 25, 10:49, Jiri Slaby wrote: > On 11. 03. 25, 10:46, Jiri Slaby wrote: >> On 10. 03. 25, 18:04, Greg Kroah-Hartman wrote: >>> 6.13-stable review patch.  If anyone has any objections, please let >>> me know. >>> >>> ------------------ >>> >>> From: Masami Hiramatsu (Google) >>> >>> [ Upstream commit 4346ba1604093305a287e08eb465a9c15ba05b80 ] >> ... >>> --- a/kernel/trace/Kconfig >>> +++ b/kernel/trace/Kconfig >>> @@ -302,11 +302,9 @@ config DYNAMIC_FTRACE_WITH_ARGS >>>   config FPROBE >>>       bool "Kernel Function Probe (fprobe)" >>> -    depends on FUNCTION_TRACER >>> -    depends on DYNAMIC_FTRACE_WITH_REGS || DYNAMIC_FTRACE_WITH_ARGS >>> -    depends on HAVE_FTRACE_REGS_HAVING_PT_REGS || ! >>> HAVE_DYNAMIC_FTRACE_WITH_ARGS >>> -    depends on HAVE_RETHOOK >>> -    select RETHOOK >>> +    depends on HAVE_FUNCTION_GRAPH_FREGS && HAVE_FTRACE_GRAPH_FUNC >> >> HAVE_FTRACE_GRAPH_FUNC does not exist on 6.13, so FPROBE is >> effectively disabled by this backport. >> >> Is this missing (and only this?): >> commit a762e9267dca843ced943ec24f20e110ba7c8431 >> Author: Masami Hiramatsu (Google) >> Date:   Thu Dec 26 14:13:34 2024 +0900 >> >>      ftrace: Add CONFIG_HAVE_FTRACE_GRAPH_FUNC > > With this applied, x86_64 is fixed. But ppc and s390 still loose it. HAVE_FTRACE_GRAPH_FUNC is missing in ppc completely in upstream too (a bug?). s390 has it only through (here omitted): commit 7495e179b478801433cec3cc4a82d2dcea35bf06 Author: Sven Schnelle Date: Thu Dec 26 14:13:48 2024 +0900 s390/tracing: Enable HAVE_FTRACE_GRAPH_FUNC > On the top of that, arm64 can indeed have FPROBEs now (the aim of the > patches). > >> thanks, -- js suse labs