From: Tao Chen <chen.dylane@linux.dev>
To: rostedt@goodmis.org, bristot@kernel.org
Cc: linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org,
bpf@vger.kernel.org
Subject: Re: [PATCH bpf-next 1/2] tools/latency-collector: Check pkg-config install
Date: Wed, 30 Jul 2025 19:51:29 +0800 [thread overview]
Message-ID: <7754e178-d8dd-4f11-a300-1fc964a5916f@linux.dev> (raw)
In-Reply-To: <20250730113028.1666038-1-chen.dylane@linux.dev>
在 2025/7/30 19:30, Tao Chen 写道:
The branch tag is wrong, i have resent it, sorry for the noise.
> The tool pkg-config used to check libtraceevent and libtracefs, if not
> installed, it will report the libs not found, even though they have
> already been installed.
>
> Before:
> libtraceevent is missing. Please install libtraceevent-dev/libtraceevent-devel
> libtracefs is missing. Please install libtracefs-dev/libtracefs-devel
>
> After:
> Makefile.config:10: *** Error: pkg-config needed by libtraceevent/libtracefs is missing
> on this system, please install it.
>
> Fixes: 9d56c88e5225 ("tools/tracing: Use tools/build makefiles on latency-collector")
> Signed-off-by: Tao Chen <chen.dylane@linux.dev>
> ---
> tools/tracing/latency/Makefile.config | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/tools/tracing/latency/Makefile.config b/tools/tracing/latency/Makefile.config
> index 0fe6b50f029b..6efa13e3ca93 100644
> --- a/tools/tracing/latency/Makefile.config
> +++ b/tools/tracing/latency/Makefile.config
> @@ -1,7 +1,15 @@
> # SPDX-License-Identifier: GPL-2.0-only
>
> +include $(srctree)/tools/scripts/utilities.mak
> +
> STOP_ERROR :=
>
> +ifndef ($(NO_LIBTRACEEVENT),1)
> + ifeq ($(call get-executable,$(PKG_CONFIG)),)
> + $(error Error: $(PKG_CONFIG) needed by libtraceevent/libtracefs is missing on this system, please install it)
> + endif
> +endif
> +
> define lib_setup
> $(eval LIB_INCLUDES += $(shell sh -c "$(PKG_CONFIG) --cflags lib$(1)"))
> $(eval LDFLAGS += $(shell sh -c "$(PKG_CONFIG) --libs-only-L lib$(1)"))
--
Best Regards
Tao Chen
prev parent reply other threads:[~2025-07-30 11:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-30 11:30 [PATCH bpf-next 1/2] tools/latency-collector: Check pkg-config install Tao Chen
2025-07-30 11:30 ` [PATCH bpf-next 2/2] rtla: " Tao Chen
2025-07-30 11:51 ` Tao Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7754e178-d8dd-4f11-a300-1fc964a5916f@linux.dev \
--to=chen.dylane@linux.dev \
--cc=bpf@vger.kernel.org \
--cc=bristot@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).