From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C54FB2F44; Wed, 13 Dec 2023 08:39:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="vO3EpuSM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 96B13C433C7; Wed, 13 Dec 2023 08:39:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702456752; bh=rqWbtF/NxYXvBPFQFOh7+fSc22EYlFtkkZ1q8+1HHpg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=vO3EpuSMPUKdH6YSXnpdHQY1/OD9Sz13+qESRvlFfyKShrJEzhy9vLcbZXJW25X9Y ANHpdO0bL7jiRUR1oxUXpHZrjQelCzLZ/A8wOCkOY64dR41I+4zLNUnNIuajnYt+JN CE3161OLG2rEUZODsfHcv3JOKzHFsxcc66PZuUy9R+gSotbaJtC+83ygUTfWyslraZ lTZvLg3/5ZsVFGv1PUUqHxDR41U+WEoB9j9ZQ4zWx2xtw7b7womJ4Xcjx9OPDdH4ww CdMTIk9R4jrphLTiYJP2Vr7mJ1cLZ+WmGcepVDXxDrDAnt1g0Bh5z6L4mWIOpBjD2H V4gCglzWoYYGw== Message-ID: <78c0072a-c084-4588-b973-ad4f80047914@kernel.org> Date: Wed, 13 Dec 2023 09:39:08 +0100 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net, xdp: correct grammar Content-Language: en-US To: Randy Dunlap , netdev@vger.kernel.org Cc: Alexei Starovoitov , Daniel Borkmann , "David S . Miller" , Jakub Kicinski , John Fastabend , bpf@vger.kernel.org References: <20231213043735.30208-1-rdunlap@infradead.org> From: Jesper Dangaard Brouer In-Reply-To: <20231213043735.30208-1-rdunlap@infradead.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 13/12/2023 05.37, Randy Dunlap wrote: > Use the correct verb form in 2 places. > > Signed-off-by: Randy Dunlap > Cc: Alexei Starovoitov > Cc: Daniel Borkmann > Cc: David S. Miller > Cc: Jakub Kicinski > Cc: Jesper Dangaard Brouer > Cc: John Fastabend > Cc: bpf@vger.kernel.org > --- > include/net/xdp.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Acked-by: Jesper Dangaard Brouer > diff -- a/include/net/xdp.h b/include/net/xdp.h > --- a/include/net/xdp.h > +++ b/include/net/xdp.h > @@ -16,7 +16,7 @@ > * > * The XDP RX-queue info (xdp_rxq_info) is associated with the driver > * level RX-ring queues. It is information that is specific to how > - * the driver have configured a given RX-ring queue. > + * the driver has configured a given RX-ring queue. > * > * Each xdp_buff frame received in the driver carries a (pointer) > * reference to this xdp_rxq_info structure. This provides the XDP > @@ -32,7 +32,7 @@ > * The struct is not directly tied to the XDP prog. A new XDP prog > * can be attached as long as it doesn't change the underlying > * RX-ring. If the RX-ring does change significantly, the NIC driver > - * naturally need to stop the RX-ring before purging and reallocating > + * naturally needs to stop the RX-ring before purging and reallocating > * memory. In that process the driver MUST call unregister (which > * also applies for driver shutdown and unload). The register API is > * also mandatory during RX-ring setup.