BPF List
 help / color / mirror / Atom feed
From: Quentin Monnet <qmo@kernel.org>
To: Tianyi Chen <hi@tychen.cc>, bpf@vger.kernel.org
Cc: andrii@kernel.org, eddyz87@gmail.com, ihor.solodrai@linux.dev,
	linux-kselftest@vger.kernel.org
Subject: Re: [PATCH bpf-next v5 0/2] bpftool: Consume ring buffer maps with event_pipe
Date: Mon, 21 Sep 2026 10:18:42 +0100	[thread overview]
Message-ID: <79618b75-d958-4b88-a9d8-23fedab8f898@kernel.org> (raw)
In-Reply-To: <20260921073556.99421-1-hi@tychen.cc>

2026-09-21 16:35 UTC+0900 ~ Tianyi Chen <hi@tychen.cc>
> Extend map event_pipe to consume BPF ring buffer records, with plain and
> JSON output and focused tests for records, shutdown and invalid arguments.
> 
> Changes in v5:
> - Suppress cpu/index completion after selecting a ring buffer map by id,
>   name or pinned path, using _bpftool_map_guess_map_type(). Keep the
>   existing suggestions for perf event arrays and unresolved map types.
> - Rebase onto current bpf-next. No other changes from v4.
> 
> This addresses the v4 review:
> https://lore.kernel.org/r/a89e2e325b87c215e0fb6e4a24284922d7656cfc0e2a247f0c8c1cd823764c23@mail.kernel.org
> 
> Built bpftool and reran all 18 ringbuf subtests against it in an x86-64
> VM; all passed. Also checked completion against live ringbuf and
> perf_event_array maps by id, name and pinned path, plus unresolved maps
> and already-specified selectors with mocked output.
> 
> v4: https://lore.kernel.org/r/20260919110721.1230756-1-hi@tychen.cc

Looks good to me, thanks for this.

Acked-by: Quentin Monnet <qmo@kernel.org>

  parent reply	other threads:[~2026-09-21  9:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-21  7:35 [PATCH bpf-next v5 0/2] bpftool: Consume ring buffer maps with event_pipe Tianyi Chen
2026-09-21  7:35 ` [PATCH bpf-next v5 1/2] bpftool: Read " Tianyi Chen
2026-09-21  8:34   ` bot+bpf-ci
2026-09-21  9:23   ` Quentin Monnet
2026-09-21  7:35 ` [PATCH bpf-next v5 2/2] selftests/bpf: Cover bpftool ring buffer event_pipe Tianyi Chen
2026-09-21  8:48   ` bot+bpf-ci
2026-09-21  9:18 ` Quentin Monnet [this message]
2026-09-21 22:10 ` [PATCH bpf-next v5 0/2] bpftool: Consume ring buffer maps with event_pipe patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=79618b75-d958-4b88-a9d8-23fedab8f898@kernel.org \
    --to=qmo@kernel.org \
    --cc=andrii@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=eddyz87@gmail.com \
    --cc=hi@tychen.cc \
    --cc=ihor.solodrai@linux.dev \
    --cc=linux-kselftest@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox