From: Eduard Zingerman <eddyz87@gmail.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: bpf@vger.kernel.org, ast@kernel.org, andrii@kernel.org,
daniel@iogearbox.net, martin.lau@linux.dev, kernel-team@fb.com,
yonghong.song@linux.dev
Subject: Re: [PATCH bpf-next 2/3] bpf: mark bpf_cast_to_kern_ctx and bpf_rdonly_cast as KF_NOCSR
Date: Thu, 15 Aug 2024 15:14:27 -0700 [thread overview]
Message-ID: <79cdae55d4bbe2c9543e9811997251d80e0d6ace.camel@gmail.com> (raw)
In-Reply-To: <CAEf4BzZp-sqfL-r1GfsODO_Hm7QEO+gu-dNMnFN+_+=66RZCeg@mail.gmail.com>
On Thu, 2024-08-15 at 15:12 -0700, Andrii Nakryiko wrote:
[...]
> > Here is a pull request for LLVM that lands the feature under
> > the new bpf_fastcall name: https://github.com/llvm/llvm-project/pull/101228
> > I hope that it would be approved today or tomorrow (more like tomorrow).
> >
> > Kernel side uses NOCSR in all places.
> > I can add a first patch to the series, renaming all NOCSR to bpf_fastcall,
> > now that it looks like llvm upstream won't object the name.
>
> Yep, I'd do that. Let's keep terminology consistent throughout.
Ok, will do, thank you.
> I assume you'll also eventually follow up with bpf_helpers_defs.h
> (there is a script that generates it) change to add that bpf_fastcall
> attribute for select helpers, right?
Good point.
next prev parent reply other threads:[~2024-08-15 22:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-12 23:43 [PATCH bpf-next 0/3] support nocsr patterns for calls to kfuncs Eduard Zingerman
2024-08-12 23:43 ` [PATCH bpf-next 1/3] bpf: " Eduard Zingerman
2024-08-13 5:36 ` Yonghong Song
2024-08-13 7:55 ` Eduard Zingerman
2024-08-13 15:18 ` Yonghong Song
2024-08-13 18:57 ` Eduard Zingerman
2024-08-15 21:24 ` Andrii Nakryiko
2024-08-15 22:07 ` Eduard Zingerman
2024-08-15 22:23 ` Yonghong Song
2024-08-15 22:29 ` Eduard Zingerman
2024-08-15 22:16 ` Yonghong Song
2024-08-15 22:22 ` Yonghong Song
2024-08-12 23:43 ` [PATCH bpf-next 2/3] bpf: mark bpf_cast_to_kern_ctx and bpf_rdonly_cast as KF_NOCSR Eduard Zingerman
2024-08-15 21:25 ` Andrii Nakryiko
2024-08-15 21:59 ` Eduard Zingerman
2024-08-15 22:12 ` Andrii Nakryiko
2024-08-15 22:14 ` Eduard Zingerman [this message]
2024-08-12 23:43 ` [PATCH bpf-next 3/3] selftests/bpf: check if nocsr pattern is recognized for kfuncs Eduard Zingerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79cdae55d4bbe2c9543e9811997251d80e0d6ace.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=martin.lau@linux.dev \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox