Re: [PATCH bpf-next v13 6/8] bpf: Add syscall common attributes support for map_create

[Leon Hwang <leon.hwang@linux.dev>]

On 2026/5/14 01:02, Alexei Starovoitov wrote:
> On Wed, May 13, 2026 at 3:50 AM Leon Hwang <leon.hwang@linux.dev> wrote:
>>
>> On 13/5/26 07:36, sashiko-bot@kernel.org wrote:
>> [...]
>>>> +
>>>> +    err = __map_create(attr, uattr, log);
>>>> +
>>>> +    ret = bpf_log_attr_finalize(&attr_log, log);
>>>> +    if (ret) {
>>>> +            if (err >= 0)
>>>> +                    close_fd(err);
>>>
>>> Is it safe to call close_fd() here? Since __map_create() uses
>>> bpf_map_new_fd() to allocate and publish the file descriptor via
>>> fd_install(), the file descriptor is already visible to userspace.
>>>
>>
>> I think it is acceptable to close_fd() here, that the duration between
>> fd_install() and close_fd() is short.
> 
> bot is correct. Let's avoid these races.
> Pls move bpf_log_attr_finalize() into map_create and do it
> before security_bpf_map_create.

Will do it.

Thanks,
Leon