From: Leon Hwang <leon.hwang@linux.dev>
To: Eduard Zingerman <eddyz87@gmail.com>,
Tiezhu Yang <yangtiezhu@loongson.cn>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Kumar Kartikeya Dwivedi <memxor@gmail.com>,
Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
Jiri Olsa <jolsa@kernel.org>,
Emil Tsalapatis <emil@etsalapatis.com>,
KaFai Wan <kafai.wan@linux.dev>
Cc: bpf@vger.kernel.org, loongarch@lists.linux.dev,
"Puranjay Mohan" <puranjay@kernel.org>,
"Björn Töpel" <bjorn@kernel.org>
Subject: Re: [PATCH bpf-next v8 2/2] bpf: Reject programs with inlined helpers if JIT is not available
Date: Tue, 7 Jul 2026 21:42:59 +0800 [thread overview]
Message-ID: <7b8e9361-2fc9-4302-b055-3657b19d2272@linux.dev> (raw)
In-Reply-To: <1c1738784ae321ed5c9dfa0aca6d0f483592713f.camel@gmail.com>
On 2026/7/7 17:27, Eduard Zingerman wrote:
> On Tue, 2026-07-07 at 10:03 +0800, Leon Hwang wrote:
[...]
>>
>> Vincent Thiberville reported an interpreter fallback issue for the
>> internal BPF_ADDR_PERCPU insn [1].
>
> As far as I understand, [1] is caused by map lookup helper inlining,
Correct.
> bpf_jit_inlines_helper_call() is unrelated this mechanism and only
> covers that three helpers I listed above.
Yes.
>
>> And, I was trying to fix assorted interpreter fallback issues [2].
>>
>> I think it is worth fixing the interpreter fallback issue for the JIT
>> inlineable helper.
>
> Meaning that you'd prefer the bpf_get_smp_processor_id() and co to
> work correctly w/o JIT, do I understand you correctly?
>
Hmm, no. According to Alexei's comment [1], we should reject the helper
by the way of this patch.
[1] https://lore.kernel.org/bpf/DJN001X0S57Y.18CKUS4NDDQT1@gmail.com/
Thanks,
Leon
next prev parent reply other threads:[~2026-07-07 13:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-06 4:00 [PATCH bpf-next v8 0/2] Introduce jit_required to prevent a kernel panic Tiezhu Yang
2026-07-06 4:00 ` [PATCH bpf-next v8 1/2] bpf: Introduce jit_required flag and remove bpf_prog_has_kfunc_call() Tiezhu Yang
2026-07-06 11:39 ` KaFai Wan
2026-07-07 1:43 ` Tiezhu Yang
2026-07-06 4:00 ` [PATCH bpf-next v8 2/2] bpf: Reject programs with inlined helpers if JIT is not available Tiezhu Yang
2026-07-06 21:41 ` Eduard Zingerman
2026-07-07 1:37 ` Tiezhu Yang
2026-07-07 9:13 ` Eduard Zingerman
2026-07-07 10:39 ` Tiezhu Yang
2026-07-07 17:55 ` Eduard Zingerman
2026-07-07 2:03 ` Leon Hwang
2026-07-07 9:27 ` Eduard Zingerman
2026-07-07 13:42 ` Leon Hwang [this message]
2026-07-07 16:31 ` Eduard Zingerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b8e9361-2fc9-4302-b055-3657b19d2272@linux.dev \
--to=leon.hwang@linux.dev \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=emil@etsalapatis.com \
--cc=jolsa@kernel.org \
--cc=kafai.wan@linux.dev \
--cc=loongarch@lists.linux.dev \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=puranjay@kernel.org \
--cc=song@kernel.org \
--cc=yangtiezhu@loongson.cn \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox