From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="frRFVb2t" Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 487F11B1 for ; Wed, 22 Nov 2023 07:13:03 -0800 (PST) Received: by mail-lf1-x12e.google.com with SMTP id 2adb3069b0e04-507973f3b65so9710731e87.3 for ; Wed, 22 Nov 2023 07:13:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700665981; x=1701270781; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=8/DV72YOMLT0FJSNZloJcTajl+bmvl9tRcm/EYPQqCg=; b=frRFVb2tshz74A87Np6KpQB9pHYXjSHrmqs0UYoCdwUqWTd0yxrN5nBQD0t+UtsimC 0MH7FEjVZL4w83Q5ck8ZK5TX/6yFNGBw0WPNxkKrCYAE/yeNs9qzWQLnqN1xCBW7JJZK vpe0jzgKH8EB6Z0bmQsucLoG0B8CKyeGNlp7qG5RpaXMBy9C68N/h1g8VJJXoF3mL2xK CkQcTvDDA5WA7MDMJpG8pHso7EvAgajkMOYEjRGAiboQBODGrlUtB8a9ghc26vTMKSXv /0WpQQ+3CzeVk1vpvjXauVB+MLVxlyIO+MTzQh/MPpZvl1X52gM4jqMETXL7/B80Dk26 7DaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700665981; x=1701270781; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8/DV72YOMLT0FJSNZloJcTajl+bmvl9tRcm/EYPQqCg=; b=MlkMdKDL28dnAtEKH9xPsV93VvzUJT40Lzn6q7PqbphXDPoC5TSUddXIWg0v3Pz0X1 uXsVW+8KuPut9QTwtK5bMNjMPBkI+s3UcLqnTwpoNwCxzRDL3ZdzC9cbxYUm+1FApiWA cBW4tEJfo8c2VHDCoDlPI48w/PlTXLUAfuaBAxNXxlU+VT556+gsWjMqM2shk3dsJqQ8 MpqWG9UHTzqw0P9R0IyYeFPI1QCViCVC7nqQ9htGTOSmiOuUTTvFxOtnMCAxpOxY9BxS B9WOEq5tudUs69f2Whf1wkH4J3vU/xAIYiKoau4Lo1I6e2iuVvnjjG+HjDQLE+35QSsO sRGw== X-Gm-Message-State: AOJu0YyAfMXLjnanIyDO5GT8Ozj8DKzEBlNiCzIgaSTcVZQyW+gzRHV5 35RZ4m3dkkScahIcywe71yc= X-Google-Smtp-Source: AGHT+IH23HySCRc/WDjIHgp0Y8mOlem+/BT7n1yzM8MQW8/nKxkr+cBDhpv498n8yBo/HxD7EWAxGQ== X-Received: by 2002:ac2:5921:0:b0:500:7fc1:414b with SMTP id v1-20020ac25921000000b005007fc1414bmr1797647lfi.25.1700665981434; Wed, 22 Nov 2023 07:13:01 -0800 (PST) Received: from [192.168.1.95] (host-176-36-0-241.b024.la.net.ua. [176.36.0.241]) by smtp.gmail.com with ESMTPSA id f15-20020a19ae0f000000b0050abb5b9720sm220302lfc.38.2023.11.22.07.13.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Nov 2023 07:13:00 -0800 (PST) Message-ID: <7ba3cdefcb7e21e6d38db68d8e5775c54a0c2339.camel@gmail.com> Subject: Re: [PATCH bpf-next 03/10] bpf: enforce precision of R0 on callback return From: Eduard Zingerman To: Andrii Nakryiko , bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net, martin.lau@kernel.org Cc: kernel-team@meta.com Date: Wed, 22 Nov 2023 17:12:59 +0200 In-Reply-To: <20231122011656.1105943-4-andrii@kernel.org> References: <20231122011656.1105943-1-andrii@kernel.org> <20231122011656.1105943-4-andrii@kernel.org> Autocrypt: addr=eddyz87@gmail.com; prefer-encrypt=mutual; keydata=mQGNBGKNNQEBDACwcUNXZOGTzn4rr7Sd18SA5Wv0Wna/ONE0ZwZEx+sIjyGrPOIhR14/DsOr3ZJer9UJ/WAJwbxOBj6E5Y2iF7grehljNbLr/jMjzPJ+hJpfOEAb5xjCB8xIqDoric1WRcCaRB+tDSk7jcsIIiMish0diTK3qTdu4MB6i/sh4aeFs2nifkNi3LdBuk8Xnk+RJHRoKFJ+C+EoSmQPuDQIRaF9N2m4yO0eG36N8jLwvUXnZzGvHkphoQ9ztbRJp58oh6xT7uH62m98OHbsVgzYKvHyBu/IU2ku5kVG9pLrFp25xfD4YdlMMkJH6l+jk+cpY0cvMTS1b6/g+1fyPM+uzD8Wy+9LtZ4PHwLZX+t4ONb/48i5AKq/jSsb5HWdciLuKEwlMyFAihZamZpEj+9n91NLPX4n7XeThXHaEvaeVVl4hfW/1Qsao7l1YjU/NCHuLaDeH4U1P59bagjwo9d1n5/PESeuD4QJFNqW+zkmE4tmyTZ6bPV6T5xdDRHeiITGc00AEQEAAbQkRWR1YXJkIFppbmdlcm1hbiA8ZWRkeXo4N0BnbWFpbC5jb20+iQHUBBMBCgA+FiEEx+6LrjApQyqnXCYELgxleklgRAkFAmKNNQECGwMFCQPCZwAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQLgxleklgRAlWZAv/cJ5v3zlEyP0/jMKQBqbVCCHTirPEw+nqxbkeSO6r2FUds0NnGA9a6NPOpBH+qW7a6+n6q3sIbvH7jlss4pzLI7LYlDC6z+egTv7KR5X1xFrY1uR5UGs1beAjnzYeV2hK4yqRUfygsT0Wk5e4FiNBv4+DUZ8r0cNDkO6swJxU55DO21mcteC147+4aDoHZ40R0tsAu+brDGSSoOPpb0RWVsEf9XOBJqWWA+T7mluw nYzhLWGcczc6J71q1Dje0l5vIPaSFOgwmWD4DA+WvuxM/shH4rtWeodbv iCTce6yYIygHgUAtJcHozAlgRrL0jz44cggBTcoeXp/atckXK546OugZPnl00J3qmm5uWAznU6T5YDv2vCvAMEbz69ib+kHtnOSBvR0Jb86UZZqSb4ATfwMOWe9htGTjKMb0QQOLK0mTcrk/TtymaG+T4Fsos0kgrxqjgfrxxEhYcVNW8v8HISmFGFbqsJmFbVtgk68BcU0wgF8oFxo7u+XYQDdKbI1uQGNBGKNNQEBDADbQIdo8L3sdSWGQtu+LnFqCZoAbYurZCmUjLV3df1b+sg+GJZvVTmMZnzDP/ADufcbjopBBjGTRAY4L76T2niu2EpjclMMM3mtrOc738Kr3+RvPjUupdkZ1ZEZaWpf4cZm+4wH5GUfyu5pmD5WXX2i1r9XaUjeVtebvbuXWmWI1ZDTfOkiz/6Z0GDSeQeEqx2PXYBcepU7S9UNWttDtiZ0+IH4DZcvyKPUcK3tOj4u8GvO3RnOrglERzNCM/WhVdG1+vgU9fXO83TB/PcfAsvxYSie7u792s/I+yA4XKKh82PSTvTzg2/4vEDGpI9yubkfXRkQN28w+HKF5qoRB8/L1ZW/brlXkNzA6SveJhCnH7aOF0Yezl6TfX27w1CW5Xmvfi7X33V/SPvo0tY1THrO1c+bOjt5F+2/K3tvejmXMS/I6URwa8n1e767y5ErFKyXAYRweE9zarEgpNZTuSIGNNAqK+SiLLXt51G7P30TVavIeB6s2lCt1QKt62ccLqUAEQEAAYkBvAQYAQoAJhYhBMfui64wKUMqp1wmBC4MZXpJYEQJBQJijTUBAhsMBQkDwmcAAAoJEC4MZXpJYEQJkRAMAKNvWVwtXm/WxWoiLnXyF2WGXKoDe5+itTLvBmKcV/b1OKZF1s90V7WfSBz712eFAynEzyeezPbwU8QBiTpZcHXwQni3IYKvsh7s t1iq+gsfnXbPz5AnS598ScZI1oP7OrPSFJkt/z4acEbOQDQs8aUqrd46PV jsdqGvKnXZxzylux29UTNby4jTlz9pNJM+wPrDRmGfchLDUmf6CffaUYCbu4FiId+9+dcTCDvxbABRy1C3OJ8QY7cxfJ+pEZW18fRJ0XCl/fiV/ecAOfB3HsqgTzAn555h0rkFgay0hAvMU/mAW/CFNSIxV397zm749ZNLA0L2dMy1AKuOqH+/B+/ImBfJMDjmdyJQ8WU/OFRuGLdqOd2oZrA1iuPIa+yUYyZkaZfz/emQwpIL1+Q4p1R/OplA4yc301AqruXXUcVDbEB+joHW3hy5FwK5t5OwTKatrSJBkydSF9zdXy98fYzGniRyRA65P0Ix/8J3BYB4edY2/w0Ip/mdYsYQljBY0A== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.1 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Tue, 2023-11-21 at 17:16 -0800, Andrii Nakryiko wrote: > Given verifier checks actual value, r0 has to be precise, so we need to > propagate precision properly. r0 also has to be marked as read, > otherwise subsequent state comparisons will ignore such register as > unimportant and precision won't really help here. >=20 > Fixes: 69c087ba6225 ("bpf: Add bpf_for_each_map_elem() helper") > Signed-off-by: Andrii Nakryiko > --- Acked-by: Eduard Zingerman [...]