From: Damien Le Moal <dlemoal@kernel.org>
To: Wilfred Mallawa <wilfred.opensource@gmail.com>,
Chaitanya Kulkarni <ckulkarnilinux@gmail.com>,
axboe@kernel.dk, agk@redhat.com, snitzer@kernel.org,
mpatocka@redhat.com, song@kernel.org, yukuai@fnnas.com,
hch@lst.de, sagi@grimberg.me, kch@nvidia.com, jaegeuk@kernel.org,
chao@kernel.org, cem@kernel.org
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
dm-devel@lists.linux.dev, linux-raid@vger.kernel.org,
linux-nvme@lists.infradead.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-xfs@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH V2 2/5] dm: ignore discard return value
Date: Wed, 26 Nov 2025 18:26:39 +0900 [thread overview]
Message-ID: <7cec7231-33f7-44ec-b82e-f12fba15392f@kernel.org> (raw)
In-Reply-To: <2f356d3564524c8c8b314ca759ec9cb07659d42a.camel@gmail.com>
On 11/26/25 8:41 AM, Wilfred Mallawa wrote:
> On Sun, 2025-11-23 at 18:57 -0800, Chaitanya Kulkarni wrote:
>> __blkdev_issue_discard() always returns 0, making all error checking
>> at call sites dead code.
>>
>> For dm-thin change issue_discard() return type to void, in
>> passdown_double_checking_shared_status() remove the r assignment from
>> return value of the issue_discard(), for end_discard() hardcod value
>
> Hey Chaitanya,
>
> Typo here s/hardcod/hardcode. Otherwise, with the split as other have
> suggested:
s/hardcod/hardcoded
>
>
> Reviewed-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
>
> Regards,
> Wilfred
>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2025-11-26 9:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-24 2:57 [PATCH V2 0/5] block: ignore __blkdev_issue_discard() ret value Chaitanya Kulkarni
2025-11-24 2:57 ` [PATCH V2 1/5] block: ignore discard return value Chaitanya Kulkarni
2025-11-24 6:26 ` Christoph Hellwig
2025-11-24 7:50 ` Johannes Thumshirn
2025-11-24 12:57 ` Martin K. Petersen
2025-11-25 23:33 ` Wilfred Mallawa
2025-11-24 2:57 ` [PATCH V2 2/5] dm: " Chaitanya Kulkarni
2025-11-24 6:24 ` Yu Kuai
2025-11-24 6:27 ` Christoph Hellwig
2025-11-24 7:53 ` Johannes Thumshirn
2025-11-24 12:59 ` Martin K. Petersen
2025-11-25 23:41 ` Wilfred Mallawa
2025-11-26 9:26 ` Damien Le Moal [this message]
2025-11-24 2:57 ` [PATCH V2 3/5] nvmet: " Chaitanya Kulkarni
2025-11-24 6:28 ` Christoph Hellwig
2025-11-24 7:54 ` Johannes Thumshirn
2025-11-24 13:03 ` Martin K. Petersen
2025-11-24 2:57 ` [PATCH V2 4/5] f2fs: " Chaitanya Kulkarni
2025-11-24 6:30 ` Christoph Hellwig
2025-11-24 7:56 ` Johannes Thumshirn
2025-11-24 12:58 ` Martin K. Petersen
2025-11-24 2:57 ` [PATCH V2 5/5] xfs: " Chaitanya Kulkarni
2025-11-24 6:31 ` Christoph Hellwig
2025-11-24 7:57 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7cec7231-33f7-44ec-b82e-f12fba15392f@kernel.org \
--to=dlemoal@kernel.org \
--cc=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=bpf@vger.kernel.org \
--cc=cem@kernel.org \
--cc=chao@kernel.org \
--cc=ckulkarnilinux@gmail.com \
--cc=dm-devel@lists.linux.dev \
--cc=hch@lst.de \
--cc=jaegeuk@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=sagi@grimberg.me \
--cc=snitzer@kernel.org \
--cc=song@kernel.org \
--cc=wilfred.opensource@gmail.com \
--cc=yukuai@fnnas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox