From: dongdwdw <dongdwdw@linux.vnet.ibm.com>
To: Kuniyuki Iwashima <kuniyu@amazon.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>
Cc: Kuniyuki Iwashima <kuni1840@gmail.com>,
bpf@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v1 bpf 0/4] bpf: sysctl: Fix data-races around net.core.bpf_XXX.
Date: Wed, 24 Aug 2022 09:10:21 +0800 [thread overview]
Message-ID: <7dbb9eb9-11f4-8b1a-5b57-378efe45b147@linux.vnet.ibm.com> (raw)
In-Reply-To: <20220818042339.82992-1-kuniyu@amazon.com>
This patch set got my attention because I found some issue about
bpf_jit_harden.
But after reading your patches, I did not get what the problem you are
trying resolve and what is improved.
You said there is a data race, what is that? Can you please show how
does this happen? What is the influence?
Would you please let me know these background info?
On 2022/8/18 12:23, Kuniyuki Iwashima wrote:
> This series split from [0] fixes data-races around 4 bpf knobs
> in net_core_table.
>
> [0]: https://lore.kernel.org/netdev/20220818035227.81567-1-kuniyu@amazon.com/
>
>
> Kuniyuki Iwashima (4):
> bpf: Fix data-races around bpf_jit_enable.
> bpf: Fix data-races around bpf_jit_harden.
> bpf: Fix data-races around bpf_jit_kallsyms.
> bpf: Fix a data-race around bpf_jit_limit.
>
> arch/arm/net/bpf_jit_32.c | 2 +-
> arch/arm64/net/bpf_jit_comp.c | 2 +-
> arch/mips/net/bpf_jit_comp.c | 2 +-
> arch/powerpc/net/bpf_jit_comp.c | 5 +++--
> arch/riscv/net/bpf_jit_core.c | 2 +-
> arch/s390/net/bpf_jit_comp.c | 2 +-
> arch/sparc/net/bpf_jit_comp_32.c | 5 +++--
> arch/sparc/net/bpf_jit_comp_64.c | 5 +++--
> arch/x86/net/bpf_jit_comp.c | 2 +-
> arch/x86/net/bpf_jit_comp32.c | 2 +-
> include/linux/filter.h | 16 ++++++++++------
> kernel/bpf/core.c | 2 +-
> net/core/sysctl_net_core.c | 4 ++--
> 13 files changed, 29 insertions(+), 22 deletions(-)
>
prev parent reply other threads:[~2022-08-24 1:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-18 4:23 [PATCH v1 bpf 0/4] bpf: sysctl: Fix data-races around net.core.bpf_XXX Kuniyuki Iwashima
2022-08-18 4:23 ` [PATCH v1 bpf 1/4] bpf: Fix data-races around bpf_jit_enable Kuniyuki Iwashima
2022-08-18 22:49 ` Alexei Starovoitov
2022-08-19 0:06 ` Kuniyuki Iwashima
2022-08-19 0:13 ` Alexei Starovoitov
2022-08-19 0:55 ` Kuniyuki Iwashima
2022-08-19 1:05 ` Alexei Starovoitov
2022-08-19 1:15 ` Kuniyuki Iwashima
2022-08-19 3:27 ` Alexei Starovoitov
2022-08-19 3:46 ` Kuniyuki Iwashima
2022-08-19 22:56 ` Alexei Starovoitov
2022-08-18 4:23 ` [PATCH v1 bpf 2/4] bpf: Fix data-races around bpf_jit_harden Kuniyuki Iwashima
2022-08-18 4:23 ` [PATCH v1 bpf 3/4] bpf: Fix data-races around bpf_jit_kallsyms Kuniyuki Iwashima
2022-08-18 4:23 ` [PATCH v1 bpf 4/4] bpf: Fix a data-race around bpf_jit_limit Kuniyuki Iwashima
2022-08-24 1:10 ` dongdwdw [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7dbb9eb9-11f4-8b1a-5b57-378efe45b147@linux.vnet.ibm.com \
--to=dongdwdw@linux.vnet.ibm.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kuni1840@gmail.com \
--cc=kuniyu@amazon.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox