From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C06114014 for ; Fri, 28 Jul 2023 16:18:51 +0000 (UTC) Received: from out-89.mta1.migadu.com (out-89.mta1.migadu.com [IPv6:2001:41d0:203:375::59]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72E761BF2 for ; Fri, 28 Jul 2023 09:18:50 -0700 (PDT) Message-ID: <7e8bb4a9-5f42-70ba-5149-d7c453b216f6@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1690561128; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zTvfN+q7+xEamIkOoHJ8TsPBm2GTUtqPLbopuWTrP8g=; b=iX5YjVLgakpm8Rjku8moy68BDYqqw2icYaHUVo2e1YKDmtcSoDGl3Q1t53jJO3osEI4VSV qbe2Z/iN8txf6HaYIDhotMEfr60/1gqkDoFr+Rj0cZVLF6MnHw8URoWYnSLXQo4YZov8hW SYhcFlSkFA83QQ1bI4G1TlavhrfR+kY= Date: Fri, 28 Jul 2023 09:18:41 -0700 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Reply-To: yonghong.song@linux.dev Subject: Re: [PATCH bpf-next v5 17/17] docs/bpf: Add documentation for new instructions Content-Language: en-US To: David Vernet Cc: Alexei Starovoitov , Andrii Nakryiko , bpf@vger.kernel.org, Daniel Borkmann , Martin KaFai Lau , David Faust , Fangrui Song , "Jose E . Marchesi" , kernel-team@fb.com, bpf@ietf.org References: <20230728011143.3710005-1-yonghong.song@linux.dev> <20230728011342.3724411-1-yonghong.song@linux.dev> <20230728132531.GA7328@maniforge> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yonghong Song In-Reply-To: <20230728132531.GA7328@maniforge> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On 7/28/23 6:25 AM, David Vernet wrote: > On Thu, Jul 27, 2023 at 06:13:42PM -0700, Yonghong Song wrote: >> Add documentation in instruction-set.rst for new instruction encoding >> and their corresponding operations. Also removed the question >> related to 'no BPF_SDIV' in bpf_design_QA.rst since we have >> BPF_SDIV insn now. > > Sorry for reviewing this after it was merged. Leaving some thoughts > which can be addressed in a subsequent patch. Thanks David. Ack to your below suggestions. Will send a patch later on to address your below comments. > >> >> Cc: bpf@ietf.org >> Signed-off-by: Yonghong Song >> --- >> Documentation/bpf/bpf_design_QA.rst | 5 - >> .../bpf/standardization/instruction-set.rst | 115 ++++++++++++------ >> 2 files changed, 79 insertions(+), 41 deletions(-) >> [...] From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CF8414A9F for ; Fri, 28 Jul 2023 16:19:02 +0000 (UTC) Received: from mail.ietf.org (mail.ietf.org [50.223.129.194]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C36E826B2 for ; Fri, 28 Jul 2023 09:18:57 -0700 (PDT) Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id A6366C15155E for ; Fri, 28 Jul 2023 09:18:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ietf.org; s=ietf1; t=1690561137; bh=nz0ifCwTiFdYrSE52UgceWoQeix7ZyO0b9kpOlDQ59s=; h=Date:To:Cc:References:From:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Reply-To; b=DsfCGOwQVJd4dqQn9mJajKZjFZoA84z4Y8vk9vLLOn1iryfm8AynAsFtWSZE14iXS q3oFDYNAR+TzBDFYVClo2uSGGMvJJEOQZ5Iv9b+hMtGIc/F4tbEpLNsw/oUxWWdPTH q10dyzg5EvsVR1eZHXK3qTnAu96T3UOuNUxbfEl0= X-Mailbox-Line: From bpf-bounces@ietf.org Fri Jul 28 09:18:57 2023 Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 75D29C15106E; Fri, 28 Jul 2023 09:18:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ietf.org; s=ietf1; t=1690561137; bh=nz0ifCwTiFdYrSE52UgceWoQeix7ZyO0b9kpOlDQ59s=; h=Date:To:Cc:References:From:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Reply-To; b=DsfCGOwQVJd4dqQn9mJajKZjFZoA84z4Y8vk9vLLOn1iryfm8AynAsFtWSZE14iXS q3oFDYNAR+TzBDFYVClo2uSGGMvJJEOQZ5Iv9b+hMtGIc/F4tbEpLNsw/oUxWWdPTH q10dyzg5EvsVR1eZHXK3qTnAu96T3UOuNUxbfEl0= Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 174C4C15106E for ; Fri, 28 Jul 2023 09:18:56 -0700 (PDT) X-Virus-Scanned: amavisd-new at amsl.com X-Spam-Score: -2.106 X-Spam-Level: X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=linux.dev Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ryGW2vUTWNDO for ; Fri, 28 Jul 2023 09:18:51 -0700 (PDT) Received: from out-83.mta1.migadu.com (out-83.mta1.migadu.com [95.215.58.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A546CC15106B for ; Fri, 28 Jul 2023 09:18:51 -0700 (PDT) Message-ID: <7e8bb4a9-5f42-70ba-5149-d7c453b216f6@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1690561128; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zTvfN+q7+xEamIkOoHJ8TsPBm2GTUtqPLbopuWTrP8g=; b=iX5YjVLgakpm8Rjku8moy68BDYqqw2icYaHUVo2e1YKDmtcSoDGl3Q1t53jJO3osEI4VSV qbe2Z/iN8txf6HaYIDhotMEfr60/1gqkDoFr+Rj0cZVLF6MnHw8URoWYnSLXQo4YZov8hW SYhcFlSkFA83QQ1bI4G1TlavhrfR+kY= Date: Fri, 28 Jul 2023 09:18:41 -0700 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Language: en-US To: David Vernet Cc: Alexei Starovoitov , Andrii Nakryiko , bpf@vger.kernel.org, Daniel Borkmann , Martin KaFai Lau , David Faust , Fangrui Song , "Jose E . Marchesi" , kernel-team@fb.com, bpf@ietf.org References: <20230728011143.3710005-1-yonghong.song@linux.dev> <20230728011342.3724411-1-yonghong.song@linux.dev> <20230728132531.GA7328@maniforge> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yonghong Song In-Reply-To: <20230728132531.GA7328@maniforge> X-Migadu-Flow: FLOW_OUT Archived-At: Subject: Re: [Bpf] [PATCH bpf-next v5 17/17] docs/bpf: Add documentation for new instructions X-BeenThere: bpf@ietf.org X-Mailman-Version: 2.1.39 Precedence: list List-Id: Discussion of BPF/eBPF standardization efforts within the IETF List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: yonghong.song@linux.dev Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: bpf-bounces@ietf.org Sender: "Bpf" X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Message-ID: <20230728161841.LQWEaT44h89RQ9cXnpjcT29B-omoUPw1FljG6r26LlM@z> On 7/28/23 6:25 AM, David Vernet wrote: > On Thu, Jul 27, 2023 at 06:13:42PM -0700, Yonghong Song wrote: >> Add documentation in instruction-set.rst for new instruction encoding >> and their corresponding operations. Also removed the question >> related to 'no BPF_SDIV' in bpf_design_QA.rst since we have >> BPF_SDIV insn now. > > Sorry for reviewing this after it was merged. Leaving some thoughts > which can be addressed in a subsequent patch. Thanks David. Ack to your below suggestions. Will send a patch later on to address your below comments. > >> >> Cc: bpf@ietf.org >> Signed-off-by: Yonghong Song >> --- >> Documentation/bpf/bpf_design_QA.rst | 5 - >> .../bpf/standardization/instruction-set.rst | 115 ++++++++++++------ >> 2 files changed, 79 insertions(+), 41 deletions(-) >> [...] -- Bpf mailing list Bpf@ietf.org https://www.ietf.org/mailman/listinfo/bpf