BPF List
 help / color / mirror / Atom feed
From: Eduard Zingerman <eddyz87@gmail.com>
To: Alan Maguire <alan.maguire@oracle.com>,
	dwarves@vger.kernel.org,  arnaldo.melo@gmail.com
Cc: bpf@vger.kernel.org, kernel-team@fb.com, ast@kernel.org,
	daniel@iogearbox.net, 	andrii@kernel.org,
	yonghong.song@linux.dev,
	Arnaldo Carvalho de Melo	 <acme@kernel.org>
Subject: Re: [PATCH dwarves v1 1/2] btf_loader: support for multiple BTF_DECL_TAGs pointing to same tag
Date: Thu, 12 Dec 2024 12:36:47 -0800	[thread overview]
Message-ID: <7f1eeeac169356ba9e75af3034b9e941d771561b.camel@gmail.com> (raw)
In-Reply-To: <f76a8cfa-73e7-4978-bd25-637db5d98dc9@oracle.com>

On Thu, 2024-12-12 at 20:29 +0000, Alan Maguire wrote:

[...]

> Looks good to me. I _think_ we're safe enough in assuming the tag
> ordering "bpf_kfunc bpf_fastcall" in the btf_functions.sh test, right?

For "bpf_kfunc bpf_fastcall" yes, we should be safe.
On the other hand, I don't think the below could be simplified with
this knowledge:

+	awk '{ gsub("^(bpf_kfunc |bpf_fastcall )+",""); print $0}'|sort|uniq

Because there are situations when only "bpf_kfunc" is present
and when both "bpf_kfunc", "bpf_fastcall" are present.

[...]


      reply	other threads:[~2024-12-12 20:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-11  2:12 [PATCH dwarves v1 1/2] btf_loader: support for multiple BTF_DECL_TAGs pointing to same tag Eduard Zingerman
2024-12-11  2:12 ` [PATCH dwarves v1 2/2] tests: verify that pfunct prints btf_decl_tags read from BTF Eduard Zingerman
2024-12-12 19:50   ` Alan Maguire
2024-12-12 19:54     ` Eduard Zingerman
2024-12-26 21:11     ` Arnaldo Carvalho de Melo
2024-12-26 21:14       ` Arnaldo Carvalho de Melo
2024-12-26 21:19         ` Arnaldo Carvalho de Melo
2025-01-03  1:18         ` Eduard Zingerman
2024-12-12 20:29 ` [PATCH dwarves v1 1/2] btf_loader: support for multiple BTF_DECL_TAGs pointing to same tag Alan Maguire
2024-12-12 20:36   ` Eduard Zingerman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7f1eeeac169356ba9e75af3034b9e941d771561b.camel@gmail.com \
    --to=eddyz87@gmail.com \
    --cc=acme@kernel.org \
    --cc=alan.maguire@oracle.com \
    --cc=andrii@kernel.org \
    --cc=arnaldo.melo@gmail.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=dwarves@vger.kernel.org \
    --cc=kernel-team@fb.com \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox