From: Jon Hunter <jonathanh@nvidia.com>
To: Xu Kuohai <xukuohai@huawei.com>,
bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Jean-Philippe Brucker <jean-philippe@linaro.org>,
Will Deacon <will@kernel.org>, KP Singh <kpsingh@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Zi Shen Lim <zlim.lnx@gmail.com>, Martin KaFai Lau <kafai@fb.com>,
Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
David Ahern <dsahern@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
Jakub Kicinski <kuba@kernel.org>,
Jesper Dangaard Brouer <hawk@kernel.org>,
Russell King <rmk+kernel@armlinux.org.uk>,
James Morse <james.morse@arm.com>, Hou Tao <houtao1@huawei.com>,
Jason Wang <wangborong@cdjrlc.com>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH bpf-next v9 3/4] bpf, arm64: Implement bpf_arch_text_poke() for arm64
Date: Thu, 21 Jul 2022 08:29:46 +0100 [thread overview]
Message-ID: <8489a831-1785-fa8d-183e-22fd841b65d0@nvidia.com> (raw)
In-Reply-To: <b0e740c4-9630-c539-e811-a4ad93fcca5c@huawei.com>
On 18/07/2022 16:37, Xu Kuohai wrote:
> On 7/18/2022 9:52 PM, Jon Hunter wrote:
>
> [..]
>>
>> This change appears to be causing the build to fail ...
>>
>> /tmp/cc52xO0c.s: Assembler messages:
>> /tmp/cc52xO0c.s:8: Error: operand 1 should be an integer register --
>> `mov lr,x9'
>> /tmp/cc52xO0c.s:7: Error: undefined symbol lr used as an immediate value
>> make[2]: *** [scripts/Makefile.build:250: arch/arm64/net/bpf_jit_comp.o]
>> Error 1
>> make[1]: *** [scripts/Makefile.build:525: arch/arm64/net] Error 2
>>
>> Let me know if you have any thoughts.
>>
>
> Sorry for this failure, but I can't reproduce it.
>
> I guess maybe your assembler doesn't recognize "lr". Could you give a
> try to replace "lr" with "x30"?
>
> #if IS_ENABLED(CONFIG_ARM64_BTI_KERNEL)
> " bti j\n" /* dummy_tramp is called via "br x10" */
> #endif
> -" mov x10, lr\n"
> -" mov lr, x9\n"
> +" mov x10, x30\n"
> +" mov x30, x9\n"
> " ret x10\n"
> " .size dummy_tramp, .-dummy_tramp\n"
> " .popsection\n
>
> Thanks.
Sorry for delay, this did not seem to land in my inbox. Anyway, yes this
fixes the build issue for me!
Thanks!
Jon
--
nvpublic
next prev parent reply other threads:[~2022-07-21 7:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-11 15:08 [PATCH bpf-next v9 0/4] bpf trampoline for arm64 Xu Kuohai
2022-07-11 15:08 ` [PATCH bpf-next v9 1/4] bpf: Remove is_valid_bpf_tramp_flags() Xu Kuohai
2022-07-11 15:08 ` [PATCH bpf-next v9 2/4] arm64: Add LDR (literal) instruction Xu Kuohai
2022-07-11 15:08 ` [PATCH bpf-next v9 3/4] bpf, arm64: Implement bpf_arch_text_poke() for arm64 Xu Kuohai
2022-07-18 13:52 ` Jon Hunter
2022-07-18 15:37 ` Xu Kuohai
2022-07-21 7:29 ` Jon Hunter [this message]
2022-07-11 15:08 ` [PATCH bpf-next v9 4/4] bpf, arm64: bpf trampoline " Xu Kuohai
2022-07-11 19:10 ` [PATCH bpf-next v9 0/4] " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8489a831-1785-fa8d-183e-22fd841b65d0@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bp@alien8.de \
--cc=bpf@vger.kernel.org \
--cc=catalin.marinas@arm.com \
--cc=daniel@iogearbox.net \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=hawk@kernel.org \
--cc=houtao1@huawei.com \
--cc=hpa@zytor.com \
--cc=james.morse@arm.com \
--cc=jean-philippe@linaro.org \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=songliubraving@fb.com \
--cc=tglx@linutronix.de \
--cc=wangborong@cdjrlc.com \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=xukuohai@huawei.com \
--cc=yhs@fb.com \
--cc=yoshfuji@linux-ipv6.org \
--cc=zlim.lnx@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox