From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02C082F0C69 for ; Mon, 10 Nov 2025 20:44:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762807466; cv=none; b=VPqClTww2BoHqvxAGsOKJJjM1bBQX5ycndGk3N1KYhdYuoKwlXZKcAFmkpI12OWzwFyqYrZAmmDTQdNxTn7euY3s/1C5e8jL10tPbxm7EmFBBp1N4AFk1+vJGaaGOJ0ZBq8cUucbK5TASJK04ge2Oh1HL7LPFPnbHHI+qBr/+80= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762807466; c=relaxed/simple; bh=1pRo6FcYmFekXp6UMZ3cZqMsEhMk7Ue52qE3SPSdaiA=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=hv1ygNMgV48wm7NjN3Kjq77O45rGyuY86/RD5WvF8H6bChdyrbMpUy6CVFXBYVU9wrwXTvVThOKvl9PDyeF5lUwKkGeJSpEppv3auWwgwS3lRpQ+NPjoVx6UtPUtu+cxaGdm3IHDsW8fQq3ZRnRDbYWNZSzUKuyO8hzJ+cG9aUo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JiRFOmOZ; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JiRFOmOZ" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-7aa9be9f03aso3040968b3a.2 for ; Mon, 10 Nov 2025 12:44:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1762807464; x=1763412264; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=iKPfFuPx59pn0UpS2AdXRDeAfpJEQ1HphTQyjMZvYAg=; b=JiRFOmOZX2Eq+5qgWUjRa2X3kbqiBt5jOO8rZAIrdytPrNh45dVjPnmzxlqhZz76Cy ZDrNapc5UCBTMvFwx5a2l1HeXXR1QZv8Azd2YTbQFppeRNbQXGWyeQzBzkF/xrSzMCLM fZHbtY7/brz7XKRy+RT21YF6yo/aEuQ7rbw6iwZLAuDRRlE/7eWWbe1Gv3JFXFGzpDb1 kod0FZd5/1V7jRnWvU7Rv3EPkOEi1SmdVMnzg5231H9yQXDgiPib6UXSr0Z0dQmJF1qP V+0F2VdnU9/a+5wal9AmqZkz4JLvhEQwl84L4KoWcP/5VdchsIfK3p52Gmh14O//Hs1Q INcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762807464; x=1763412264; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iKPfFuPx59pn0UpS2AdXRDeAfpJEQ1HphTQyjMZvYAg=; b=bbn2DVsyL2/oRA2019Gd7KVjm+Jfixivz398bICuAVj71PN2RgthLkyajQ/0B9Gv6K FEgvmjPBOeNfwuuc4mZtDUwwHupnrCvQAuTsnZta5CYMrizI3jIcVF1284KhZDb69YXg hJAkoC/eE/9HCu0SkfR/LL1PfDGUgS9myOltqwJIpIoiZeECZ5aEM7VeJA7ocqRihzLK 9ezyhLDMFLho1rG8YmER4In88zPqqRXFlQrfjmqm1w6RrdGUioZng4OIVCzEIH8fPIIc VuT5GzqSlccu9DkflDofT46EVRPkrMDRAI6s7ngAhjRkZYDoV64Q71jgCudz+YuQbyV4 N+RQ== X-Forwarded-Encrypted: i=1; AJvYcCUaqJ6dTJNpFYa1q8Nw6lAcL/Er/T+zdzZt2vWB1FgGxxkX1yrpJN4C0thaqzE0St8U90o=@vger.kernel.org X-Gm-Message-State: AOJu0YwmrFoxNCViZ/VuuH96ZohfkBix0blYfE5DuUi5APlLYrnOZXDo irT84giLhiXc58Nbc2MBXyssylppglmQYnDrg1ufNn24Jfx3qZ2nIFkq X-Gm-Gg: ASbGncsfZgB/vAqdd1K9wWgFHpOJNc3ZL+mVZch5CLB2dcHsi/NSdBcRlJ4Y2pG6nl1 MhvMBpftG3IkRo/BMm6ufhAMQIX7Y7gyfYXk6JJHAbZgi3g/m3jnHv4wXV6tztc5ZI0Vq51P3gl lY3JCbIG4hNCwTH7hYgq7VO53pdzBhQY4eXXV6xCKQAQA3pdKIvSkhifqHyfK/s82tmNjuj8rWh JRWaQSE4fDHUCUO8lTXT9wRZ5BIt41veWPT9WZTrV5Dn0aymaK/Ke/zXJejn2HhBJho7L/NkICP Nflpelc3o/6bfnODHhencTdyJLztGsoLgeYl4Vi2Y8z1n3o/UvubArPJ2hY9sGp/pp9Fo1VJvS5 /OKL9oBEAk3E/0lXRQWBFpdZfnn9HAmB9osgUCnjed52v+0P83S2Slk/mSm1YrUlHe5RJBRFTzE /aihtACYpI66kHi44ZgoBwZwYp X-Google-Smtp-Source: AGHT+IGLQ+TKStFopEippXXCOLfymt5XyhUQ0gz+x+HlNHUomSsmKq2g8X5d42p43jRwj51NHHo8YA== X-Received: by 2002:a17:903:988:b0:297:dde4:8024 with SMTP id d9443c01a7336-297e56622c0mr113277145ad.23.1762807464301; Mon, 10 Nov 2025 12:44:24 -0800 (PST) Received: from ?IPv6:2a03:83e0:115c:1:5ff:e0da:7503:b2a7? ([2620:10d:c090:500::7:ecb1]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-297dfcbe798sm92498915ad.19.2025.11.10.12.44.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Nov 2025 12:44:23 -0800 (PST) Message-ID: <854a2c2ceaa52f1ad26fb803d1ad5668fd3200b3.camel@gmail.com> Subject: Re: [PATCH v5 6/7] btf: Add lazy sorting validation for binary search From: Eduard Zingerman To: Donglin Peng , Alexei Starovoitov , Andrii Nakryiko , Ihor Solodrai Cc: bot+bpf-ci@kernel.org, Alexei Starovoitov , zhangxiaoqin@xiaomi.com, LKML , bpf , Alan Maguire , Song Liu , pengdonglin , Andrii Nakryiko , Daniel Borkmann , Martin KaFai Lau , Yonghong Song , Chris Mason Date: Mon, 10 Nov 2025 12:44:21 -0800 In-Reply-To: References: <20251106131956.1222864-7-dolinux.peng@gmail.com> <74d4c8e40e61dad369607ecd8b98f58a515479f0.camel@gmail.com> <5a8c765f8e2b4473d9833d468ea43ad8ea7e57b6.camel@gmail.com> <6cbeb051a6bebb75032bc724ad10efed5b65cbf7.camel@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2 (3.56.2-1.fc42) Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2025-11-10 at 09:42 +0800, Donglin Peng wrote: [...] > [[Resending in plain text format - previous HTML email was rejected] >=20 > Thanks for the feedback. Based on the previous discussions, I plan > to implement the following changes in the next version: >=20 > 1. Modify the btf__permute interface to adopt the ID map approach, as > suggested by Andrii. >=20 > 2. Remove the lazy sort check and move the verification to the BTF > parsing phase. This addresses two concerns: potential race conditions > with write operations and const-cast issues. The overhead is negligib= le > (approximately 1.4ms for vmlinux BTF). >=20 > 3. Invoke the btf__permute interface to implement BTF sorting in resolve_= btfids. >=20 > I welcome any further suggestions. Hi Donglin, I think this summarizes the discussion pretty well. One thing to notice about (2): if sorting is done by resolve_btfids, there is no need to check for BTF being sorted in vmlinux BTF. So, maybe it's a good idea to skip this check for it, as Alexei suggested (but not for programs BTF). Thanks, Eduard.