BPF List
 help / color / mirror / Atom feed
From: Alan Maguire <alan.maguire@oracle.com>
To: Eduard Zingerman <eddyz87@gmail.com>, Song Liu <songliubraving@meta.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
	"dwarves@vger.kernel.org" <dwarves@vger.kernel.org>,
	bpf <bpf@vger.kernel.org>, Andrii Nakryiko <andrii@kernel.org>,
	Martin KaFai Lau <martin.lau@linux.dev>
Subject: Re: FYI: CI regression on big-endian arch (s390) after recent pahole changes
Date: Fri, 30 Aug 2024 11:05:30 +0100	[thread overview]
Message-ID: <860fe244-157b-46cf-9b41-ee9fd36f9c1e@oracle.com> (raw)
In-Reply-To: <322d9bac47bc3732b77cf2cf23d69f2c4665bc36.camel@gmail.com>

On 30/08/2024 10:21, Eduard Zingerman wrote:
> On Fri, 2024-08-30 at 02:49 +0000, Song Liu wrote:
> 
> [...]
> 
>> Clarification: 
>>
>> With the regression, _both_ .BTF and .BTF.base sections (or at 
>> least part of these sections) are in little endian for s390:
> 
> Hi Song,
> 
> Understood, thank you for clarification and sorry for confusion.
> This makes sense because btf__distill_base() generates
> two new BTF structures and both need to inherit endianness.
> 
> Thanks,
> Eduard
> 
> [...]
> 

thanks all for the quick root-cause analysis and proposed fixes!
Explicitly checking these cases in the btf_endian selftest is probably
worthwhile; I've put together tests that do that for non-native
endianness but just noticed you mentioned you're working on tests
Eduard. Is that what you had in mind?

Arnaldo: apologies but I think we'll either need to back out the
distilled stuff for 1.28 or have a new libbpf resync that captures the
fixes for endian issues once they land. Let me know what works best for
you. Thanks!

  reply	other threads:[~2024-08-30 10:05 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-30  0:05 FYI: CI regression on big-endian arch (s390) after recent pahole changes Eduard Zingerman
2024-08-30  1:27 ` Tony Ambardar
2024-08-30  1:40   ` Eduard Zingerman
2024-08-30  6:57     ` Tony Ambardar
2024-08-30  9:13       ` Eduard Zingerman
2024-08-30  9:51         ` [PATCH bpf-next v1] libbpf: ensure new BTF objects inherit input endianness Tony Ambardar
2024-08-30 11:15           ` Eduard Zingerman
2024-08-30 11:25             ` Alan Maguire
2024-08-30 15:58               ` Andrii Nakryiko
2024-08-30 16:00           ` Andrii Nakryiko
2024-08-30 17:51             ` Andrii Nakryiko
2024-08-30  2:49 ` FYI: CI regression on big-endian arch (s390) after recent pahole changes Song Liu
2024-08-30  9:21   ` Eduard Zingerman
2024-08-30 10:05     ` Alan Maguire [this message]
2024-08-30 10:07       ` Eduard Zingerman
2024-08-30 13:19       ` Arnaldo Carvalho de Melo
2024-08-30 15:56         ` Andrii Nakryiko
2024-08-30 20:49           ` Arnaldo Carvalho de Melo
2024-08-30 22:20             ` Andrii Nakryiko
2024-08-30 22:34               ` Alan Maguire
2024-08-30 23:30                 ` Andrii Nakryiko
2024-09-02 13:06                   ` Alan Maguire
2024-09-02 14:08                 ` Arnaldo Carvalho de Melo
2024-09-02 14:59                   ` Alan Maguire
2024-09-02 18:44                     ` Arnaldo Carvalho de Melo
2024-08-30 22:22             ` Alan Maguire

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=860fe244-157b-46cf-9b41-ee9fd36f9c1e@oracle.com \
    --to=alan.maguire@oracle.com \
    --cc=acme@kernel.org \
    --cc=andrii@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=dwarves@vger.kernel.org \
    --cc=eddyz87@gmail.com \
    --cc=martin.lau@linux.dev \
    --cc=songliubraving@meta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox