From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40A90C433E0 for ; Thu, 11 Mar 2021 10:53:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CCFFF64FD2 for ; Thu, 11 Mar 2021 10:53:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232372AbhCKKws (ORCPT ); Thu, 11 Mar 2021 05:52:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232513AbhCKKwW (ORCPT ); Thu, 11 Mar 2021 05:52:22 -0500 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65DECC061574 for ; Thu, 11 Mar 2021 02:52:22 -0800 (PST) Received: by mail-lf1-x136.google.com with SMTP id k9so38972051lfo.12 for ; Thu, 11 Mar 2021 02:52:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=jrFpYE8nrsCGhuKH8Z1MPYCc2kyE8ltxYIbArqRBpcI=; b=Wr5VJhiUEj6Anx3jbX59PP65x6QGe2uBWrM0P4tR6Wm0PfJDVUYepic9Q8u5iNsm4A mj+pJT9XL3PKsaMS6TrYPbHXyt3x8xJpD5A1Xw5LW1WehV6ykMecFnSwWxcIz2dsjWX1 09R959wyWkF93AxgczxAwHnKP39FjCFVAnOPk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=jrFpYE8nrsCGhuKH8Z1MPYCc2kyE8ltxYIbArqRBpcI=; b=jSZTlfQHqLl2ryaONgCNE1En3Lqu0I45dEthPk+g29vCLuliBdT9F+hvXipm74Mwd0 ABhzA6oD+gFgklDmDp21jb6XPoX0amvnBZfMyt/0hScY4/Bzvx3e72VcJSFk2lKQq2eS T1AJczk4xvH2c8o/ITkPKR9EI+dsqOLr6Go9+TVis8qkLE5qfAHgqBtsyVGBBU/4bOpm JUgdU35c5lJvXMSVn11R2exiytoO3The3ygv30JKAhgy6PMch5mmlnl18+wmbTtpEkop 2OlKRTCDOZ7YYMt354zRuScknmVTvy6zMDboPTnCCi7Jlf4j+Vw4isBwxQFhNU5/ocTo 7hvg== X-Gm-Message-State: AOAM532NSV4unjiB9P231I1RFTfGnhz1Oexy+NItt0msUfvtnDKWXFDJ 1wNj1Eg0njwAamiddHf93e748g== X-Google-Smtp-Source: ABdhPJwJG7epJTysKQknWKjrVh02iyyuC7bGeaUjoltxNezJvmLXyUugnGAIRTVuXd8583CYavmM1g== X-Received: by 2002:a19:81d0:: with SMTP id c199mr1880836lfd.62.1615459940881; Thu, 11 Mar 2021 02:52:20 -0800 (PST) Received: from cloudflare.com (79.184.34.53.ipv4.supernova.orange.pl. [79.184.34.53]) by smtp.gmail.com with ESMTPSA id g21sm714496lfr.212.2021.03.11.02.52.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Mar 2021 02:52:20 -0800 (PST) References: <20210310053222.41371-1-xiyou.wangcong@gmail.com> <20210310053222.41371-2-xiyou.wangcong@gmail.com> User-agent: mu4e 1.1.0; emacs 27.1 From: Jakub Sitnicki To: Cong Wang Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, duanxiongchun@bytedance.com, wangdongdong.6@bytedance.com, jiang.wang@bytedance.com, Cong Wang , John Fastabend , Daniel Borkmann , Lorenz Bauer Subject: Re: [Patch bpf-next v4 01/11] skmsg: lock ingress_skb when purging In-reply-to: <20210310053222.41371-2-xiyou.wangcong@gmail.com> Date: Thu, 11 Mar 2021 11:52:18 +0100 Message-ID: <8735x23qu5.fsf@cloudflare.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Wed, Mar 10, 2021 at 06:32 AM CET, Cong Wang wrote: > From: Cong Wang > > Currently we purge the ingress_skb queue only when psock > refcnt goes down to 0, so locking the queue is not necessary, > but in order to be called during ->close, we have to lock it > here. > > Cc: John Fastabend > Cc: Daniel Borkmann > Cc: Jakub Sitnicki > Cc: Lorenz Bauer > Signed-off-by: Cong Wang > --- Acked-by: Jakub Sitnicki