From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Viktor Malik <vmalik@redhat.com>, bpf@vger.kernel.org
Cc: Andrii Nakryiko <andrii@kernel.org>,
Eduard Zingerman <eddyz87@gmail.com>,
Mykola Lysenko <mykolal@fb.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>, Shuah Khan <shuah@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
Viktor Malik <vmalik@redhat.com>, Quentin Monnet <qmo@kernel.org>
Subject: Re: [PATCH bpf-next v3 2/3] bpftool: Prevent setting duplicate _GNU_SOURCE in Makefile
Date: Mon, 04 Nov 2024 15:05:43 +0100 [thread overview]
Message-ID: <874j4n9jrc.fsf@toke.dk> (raw)
In-Reply-To: <acec3108b62d4df1436cda777e58e93e033ac7a7.1730449390.git.vmalik@redhat.com>
Viktor Malik <vmalik@redhat.com> writes:
> When building selftests with CFLAGS set via env variable, the value of
> CFLAGS is propagated into bpftool Makefile (called from selftests
> Makefile). This makes the compilation fail as _GNU_SOURCE is defined two
> times - once from selftests Makefile (by including lib.mk) and once from
> bpftool Makefile (by calling `llvm-config --cflags`):
>
> $ CFLAGS="" make -C tools/testing/selftests/bpf
> [...]
> CC /bpf-next/tools/testing/selftests/bpf/tools/build/bpftool/btf.o
> <command-line>: error: "_GNU_SOURCE" redefined [-Werror]
> <command-line>: note: this is the location of the previous definition
> cc1: all warnings being treated as errors
> [...]
>
> Filter out -D_GNU_SOURCE from the result of `llvm-config --cflags` in
> bpftool Makefile to prevent this error.
>
> Signed-off-by: Viktor Malik <vmalik@redhat.com>
> Acked-by: Quentin Monnet <qmo@kernel.org>
> Acked-by: Jiri Olsa <jolsa@kernel.org>
Reviewed-by: Toke Høiland-Jørgensen <toke@redhat.com>
next prev parent reply other threads:[~2024-11-04 14:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-01 8:27 [PATCH bpf-next v3 0/3] selftests/bpf: Improve building with extra Viktor Malik
2024-11-01 8:27 ` [PATCH bpf-next v3 1/3] selftests/bpf: Allow building with extra flags Viktor Malik
2024-11-01 19:34 ` Andrii Nakryiko
2024-11-04 13:43 ` Toke Høiland-Jørgensen
2024-11-06 20:37 ` Andrii Nakryiko
2024-11-04 14:03 ` Toke Høiland-Jørgensen
2024-11-01 8:27 ` [PATCH bpf-next v3 2/3] bpftool: Prevent setting duplicate _GNU_SOURCE in Makefile Viktor Malik
2024-11-04 14:05 ` Toke Høiland-Jørgensen [this message]
2024-11-01 8:27 ` [PATCH bpf-next v3 3/3] selftests/bpf: Disable warnings on unused flags for Clang builds Viktor Malik
2024-11-01 19:46 ` [PATCH bpf-next v3 0/3] selftests/bpf: Improve building with extra Andrii Nakryiko
2024-11-04 11:34 ` Viktor Malik
2024-11-01 19:50 ` patchwork-bot+netdevbpf
2024-11-06 20:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874j4n9jrc.fsf@toke.dk \
--to=toke@redhat.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=justinstitt@google.com \
--cc=kpsingh@kernel.org \
--cc=martin.lau@linux.dev \
--cc=morbo@google.com \
--cc=mykolal@fb.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=qmo@kernel.org \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=vmalik@redhat.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox