From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9299424215 for ; Mon, 6 Nov 2023 14:43:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b="FKLzxAib" Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ABCE4100 for ; Mon, 6 Nov 2023 06:43:49 -0800 (PST) Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-5435336ab0bso7779260a12.1 for ; Mon, 06 Nov 2023 06:43:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google09082023; t=1699281828; x=1699886628; darn=vger.kernel.org; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=NDSySmtz3iv59MVKPeBfK4m30gXKygHdiLZCdVGtoL4=; b=FKLzxAibfYMZJyga3kFlWQsSvBE4CYd97NzJ3/nAxRLofQ9to6QZntIx1tUoAobUog 2S4mWs0n2RWN7YG1AvGILrxZVb1T48JWDMJ8EOo3l/anDs0B4UvqfFR8U5j6TCRL3cJD J17ivQp9h9a/GJx6+ktRLC2WUchHSYEOuaDvr47kIG9lJP4wftHlQWf8jhfJk4fOPbhF Mtwsd8yEuXLRMsbMqNd8PoqPcFmUsfPKm/C1Kx4DkLIEJkhxzyQcZR600TXhOW2CIkw0 hExnbjNPqYrJ1AbBqHjbAiBl/C2jenxVx2EWoUy+wZawXSWg3j/j4Y0QFdZzUsnbzoAw Tnyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699281828; x=1699886628; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NDSySmtz3iv59MVKPeBfK4m30gXKygHdiLZCdVGtoL4=; b=kBOW8KkMtV3iUTVGts9L2tudXCYWGGz4A1c54tzHjtpnHUrGuoGHqX1juZ0AR9SMqW PeQq5Kw6VC8T5d+n6aFVkE2Ch5adnB4+/yfL93EzHO2cvhL50tn0qbD5r8LZLtBNtDXX Gmtbh1UE3tux8htc3LeHkW179e+Y1xD0ctkv6SvqgyfuTkrKSYkZ6wbS4L0bM56kvlgl ur1QE5OApuwxK4wv9lqbInov8yd5008TW8OWY2JI2ISBMmk2qxu3hlebBpkjc4qf/hPy Y8Drh5pTcshM+t6Wb9yfoQQH5R/EeVnCyF37vTV5WvBF2mShHX3elvzGpRia6SlR1qzn TTnw== X-Gm-Message-State: AOJu0YxC/hc4XKtCCVUdEWXON/tlpjTpyztGkOTtOFqByvXfitxtwbRF MYgSj4LmUCSpWd5bgse5akbnHA== X-Google-Smtp-Source: AGHT+IHBOBsU4XTxsmO0ZGIusix3dN8s9ToLcljRr6B+3pF2tycujXUw9E7lDLAQVi6XwymnDm46Jg== X-Received: by 2002:a17:906:7307:b0:9bd:d405:4e7e with SMTP id di7-20020a170906730700b009bdd4054e7emr15452858ejc.6.1699281828187; Mon, 06 Nov 2023 06:43:48 -0800 (PST) Received: from cloudflare.com (79.184.209.104.ipv4.supernova.orange.pl. [79.184.209.104]) by smtp.gmail.com with ESMTPSA id g17-20020a1709067c5100b0099bc8bd9066sm4268993ejp.150.2023.11.06.06.43.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Nov 2023 06:43:47 -0800 (PST) References: <20231016190819.81307-1-john.fastabend@gmail.com> <20231016190819.81307-3-john.fastabend@gmail.com> <878r7bjb1a.fsf@cloudflare.com> User-agent: mu4e 1.6.10; emacs 28.3 From: Jakub Sitnicki To: John Fastabend Cc: bpf@vger.kernel.org, netdev@vger.kernel.org, yangyingliang@huawei.com, martin.lau@kernel.org Subject: Re: [PATCH bpf 2/2] bpf: sockmap, add af_unix test with both sockets in map Date: Mon, 06 Nov 2023 15:42:17 +0100 In-reply-to: <878r7bjb1a.fsf@cloudflare.com> Message-ID: <874jhzj61o.fsf@cloudflare.com> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Mon, Nov 06, 2023 at 01:44 PM +01, Jakub Sitnicki wrote: > But I'm able to reproduce the bug by running the VSOCK redir test: I should clarify - the bug reproduces only without the patch #1 applied. The fix is good. It just has some unneeded bits (unix_dgram), IMO.