From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70994315789 for ; Wed, 10 Sep 2025 09:43:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757497406; cv=none; b=gnzgRvxmyPihqLlI7obGJ/YOmpsFbgu7x5Pg1jr10r1uWVcNLvQc5R/5imcFxiopXh0OK6wfpztHBZdReIe1w7ql6y9jkpJ0U4lRWh7T5P4+mGmWUEtWbhCnuGGIsx2+v+dDDg9Sy9JKWLWCQLNLRXtT0WrFZNia4ScQ6LpG9b0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757497406; c=relaxed/simple; bh=GeZ8gRXpmuh4zIH2qzoEpO1TgLkvX/hmsfatSykJQdM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=Dk1G2iezhsuEvX95kFtUaZBZ6pnLtRJy49obHCojW22fL59Nwlq6Dhr4gfdRZ57fshNxZvOuqvfIkPantnKyRophWrrQr3z+wLGfZdQ+GdwP8EP4PuWXLMxp6NAQWDvVkVqEaEl+tcLIWIzYb+nmZf2BXmk33NO0VdrsEBlNkG0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cloudflare.com; spf=pass smtp.mailfrom=cloudflare.com; dkim=pass (2048-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b=FjKKfRzp; arc=none smtp.client-ip=209.85.208.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cloudflare.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cloudflare.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b="FjKKfRzp" Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-622b4b14a75so9132595a12.1 for ; Wed, 10 Sep 2025 02:43:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google09082023; t=1757497403; x=1758102203; darn=vger.kernel.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=UH6/XT0kvfyB5mO2cKrXbyp31DnusO7Ul6sUo8daz10=; b=FjKKfRzp/hxCDsMl1xDnwLyR79PZ7k+UjNNip2MAJMvzJevAf8hf1i9LM2JlVoiP89 gIOxALJWod57EihdfypzXXN60vlCckxlrl40uKKNpD8oWrBcWoGOQK2JoRcB1cfTdqLk CByM1UAJwhqzmvY8DMBwNDilIpKN22S2KShATesu3ITjrvRokazM7vRejCy423xXLksO HHhgQCLMhpU0mszfYHGNXp7/x8lfsQzTqGt1mD0GpYoiPurGu8OrkqhDRQ27gZxE35tS Xjzh0dT9DrWCx7+Od9DxF+JfIAM71+dcswESBHwjNixCD9StNMTGtEWZn7mqH/8xkzAW XPxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757497403; x=1758102203; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UH6/XT0kvfyB5mO2cKrXbyp31DnusO7Ul6sUo8daz10=; b=mXZKwF2BWUxImTlutODEqgW2yUj+mClIh6RveEVwMbOGCVTeO5fRRNtjZuVPV4wePW m0BHyReRx08Z6YMxnmV9Zz7HBafMxwWHh+G2Dz0vd03z3bdXVjDf7l447d9lirAD/5UF qjHEvCO4pyhttkW+nbdNSwpm5hd60xxg/vfhuVzhb2St60kKLYXTJZsT4A1d9tGRe1rJ sW7VYFjwoywgeelLYx1z9XQ0sCw6HBUfDAE8QlzmPgJZLAdd2N1XB8dUf9pY9TYBeh8b q2ja7jO+Kq/09xeSyhDA0NTESuVkuvsjyqDjOnh1d/jIqgRpvsL1kc7tXykWKUo3jRN3 ZTXQ== X-Forwarded-Encrypted: i=1; AJvYcCV2C4AjA/YLrMuIbhA28Z+9+d9aAu//xuxRfn5fXFQwPeavdq4/YP95t1v6cC3j0XJgJO0=@vger.kernel.org X-Gm-Message-State: AOJu0YxCHNVMAaUwGExXnageHIOvZmnYMxsoUJtL7KXwZ3CDXNbGfn8u UEzb/MycMRRgZd+b9LhX8uVBn3nkq/hUSoAQOHUPLJkEcaNs0FhKBl8rYvRWp2ecPKI= X-Gm-Gg: ASbGncu7a8KYl4BjLs6uKTht9BZZ45VFq4ABR9JYsM8xfZUwbjl2Ee0WDhQnvx0bO3z oC2qoPExD7kP8CMiRtqk5R8NgrF3rle4qz6Fgs9JfBDWYpdKTwBHpaRc1kd0nHDRoTW0nCUWIyj qaG2C7KwMLsMs0YofQjVXOFyv4UwNt78FMvfOmLIlhjxH3nuTFbYbFfi//MwvzSNEqjxMyuwLoK yHeTru+HtAPi+rQCPeTUA6Zxw0695H8clhb6N2SA5WYV6BLg4oRK76cFNEcw4hsIrQ2JsX0pzYV fTpIlws3EXdMeOpcRoqdDgsx7ub+QS6mnCDqMDwy7Ll90RUkx1F9QJp6kYd2FMoe5pu0tc3AE+C +cqJzSSx8ycHqT3Sm8gt4O89e+Q== X-Google-Smtp-Source: AGHT+IHezEvVl+d9vvOZ0x6lYJthodH+9bMTe2BUEcXlfkeFgiHS5P2xoZIspY68/UNlg2yLMMtPQA== X-Received: by 2002:a05:6402:270d:b0:62c:3878:747 with SMTP id 4fb4d7f45d1cf-62c38784cc4mr4323427a12.33.1757497402738; Wed, 10 Sep 2025 02:43:22 -0700 (PDT) Received: from cloudflare.com ([2a09:bac5:5063:2432::39b:94]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-62c018f660esm2874458a12.38.2025.09.10.02.43.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Sep 2025 02:43:21 -0700 (PDT) From: Jakub Sitnicki To: Michal Luczaj Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Mykola Lysenko , Shuah Khan , bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH bpf-next 1/5] selftests/bpf: sockmap_redir: Simplify try_recv() In-Reply-To: <35912d55-eb6e-403a-9a7a-05cae551ccf3@rbox.co> (Michal Luczaj's message of "Tue, 9 Sep 2025 23:25:16 +0200") References: <20250905-redir-test-pass-drop-v1-0-9d9e43ff40df@rbox.co> <20250905-redir-test-pass-drop-v1-1-9d9e43ff40df@rbox.co> <87ikhs54z2.fsf@cloudflare.com> <87bjnk53uo.fsf@cloudflare.com> <35912d55-eb6e-403a-9a7a-05cae551ccf3@rbox.co> Date: Wed, 10 Sep 2025 11:43:20 +0200 Message-ID: <877by663t3.fsf@cloudflare.com> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Tue, Sep 09, 2025 at 11:25 PM +02, Michal Luczaj wrote: > On 9/9/25 12:15, Jakub Sitnicki wrote: >> On Tue, Sep 09, 2025 at 11:51 AM +02, Jakub Sitnicki wrote: >>> On Fri, Sep 05, 2025 at 01:11 PM +02, Michal Luczaj wrote: >>>> try_recv() was meant to support both @expect_success cases, but all the >>>> callers use @expect_success=false anyway. Drop the unused logic and fold in >>>> MSG_DONTWAIT. Adapt callers. >>>> >>>> Subtle change here: recv() return value of 0 will also be considered (an >>>> unexpected) success. >>>> >>>> Signed-off-by: Michal Luczaj >>>> --- >>>> .../selftests/bpf/prog_tests/sockmap_redir.c | 25 +++++++++------------- >>>> 1 file changed, 10 insertions(+), 15 deletions(-) >>>> >>>> diff --git a/tools/testing/selftests/bpf/prog_tests/sockmap_redir.c b/tools/testing/selftests/bpf/prog_tests/sockmap_redir.c >>>> index 9c461d93113db20de65ac353f92dfdbe32ffbd3b..c1bf1076e8152b7d83c3e07e2dce746b5a39cf7e 100644 >>>> --- a/tools/testing/selftests/bpf/prog_tests/sockmap_redir.c >>>> +++ b/tools/testing/selftests/bpf/prog_tests/sockmap_redir.c >>>> @@ -144,17 +144,14 @@ static void get_redir_params(struct redir_spec *redir, >>>> *redirect_flags = 0; >>>> } >>>> >>>> -static void try_recv(const char *prefix, int fd, int flags, bool expect_success) >>>> +static void fail_recv(const char *prefix, int fd, int more_flags) >>>> { >>>> ssize_t n; >>>> char buf; >>>> >>>> - errno = 0; >>>> - n = recv(fd, &buf, 1, flags); >>>> - if (n < 0 && expect_success) >>>> - FAIL_ERRNO("%s: unexpected failure: retval=%zd", prefix, n); >>>> - if (!n && !expect_success) >>>> - FAIL("%s: expected failure: retval=%zd", prefix, n); >>>> + n = recv(fd, &buf, 1, MSG_DONTWAIT | more_flags); >>>> + if (n >= 0) >>>> + FAIL("%s: unexpected success: retval=%zd", prefix, n); >>>> } >>> >>> This bit, which you highlighted in the description, I don't get. >>> >>> If we're expecting to receive exactly one byte, why treat a short read >>> as a succcess? Why not make it a strict "n != 1" check? >>> >>> [...] >> >> Nevermind. It makes sense now. We do want to report a failure for 0-len >> msg recv as well. You're effectively checking if the rcv queue is empty. >> >> I'd add MSG_PEEK, to signal that we're _just checking_ if the socket is >> readable, and turn the check into the below to succeed only when >> queue is empty: >> >> (n != -1 || (errno != EAGAIN && errno != EWOULDBLOCK)) > > Well, looks like adding MSG_PEEK exposed a bug in the test. I'll fix that. The gift that keeps on giving xD Other alternatives that should also work, but who knows: - select/poll/epoll readability check - ioctl(SIOCINQ) but no way to tell if 0-len msg is pending